SPEC: http://v3.sk/~lkundrak/SPECS/perl-File-Map.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-File-Map-0.31-1.el5_5.src.rpm Description: File::Map maps files or anonymous memory into perl variables.
SPEC: http://v3.sk/~lkundrak/SPECS/perl-File-Map.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-File-Map-0.31-2.el5_5.src.rpm
The standalone spec file and the embedded one in SRPM differ. I will use the standalone one for reference. Source tar ball is original. Ok. > Patch0: perl-File-Map-0.31-pod.patch FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41 (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora is affected, drop this patch or apply it conditionally on older RHEL distributions (if necessary). TODO: Submit the perl-File-Map-0.31-tie.patch patches to upstream. License verified from README and lib/File/Map.pm. Ok. FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be dual-lived package in the future <http://search.cpan.org/~gbarr/IO/>. FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>. All tests pass. Ok. $ rpmlint perl-File-Map.spec ../SRPMS/perl-File-Map-0.31-2.fc15.src.rpm ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm perl-File-Map.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so Map.so()(64bit) perl-File-Map.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so Map.so()(64bit) perl-File-Map.x86_64: W: spurious-executable-perm /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl perl-File-Map.x86_64: W: doc-file-dependency /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl /usr/bin/perl 2 packages and 1 specfiles checked; 0 errors, 4 warnings. FIX: Remove the private library from provides. You can do that by calling `%{?perl_default_filter}' macro right before %description section. See <https://fedoraproject.org/wiki/Perl_default_filter>. FIX: Remove executable bit from fastsearch.pl. $ rpm -pq -lv ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/File -rw-r--r-- 1 root root 15566 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/File/Map.pm drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File/Map -rwxr-xr-x 1 root root 28760 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/share/doc/perl-File-Map-0.31 -rw-r--r-- 1 root root 4818 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/Changes -rw-r--r-- 1 root root 17979 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/LICENSE -rw-r--r-- 1 root root 2292 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/README drwxr-xr-x 2 root root 0 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/examples -rwxr-xr-x 1 root root 355 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl -rw-r--r-- 1 root root 6899 Nov 3 17:16 /usr/share/man/man3/File::Map.3pm.gz File layout Ok. Permissions except the fastsearch.pl Ok. $ rpm -pq --requires ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.2)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl >= 0:5.008 1 perl >= 1:5.010 1 perl(Carp) 1 perl(Const::Fast) 1 perl(File::Map) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(PerlIO) 1 perl(strict) 1 perl(Sub::Exporter) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires Ok. $ rpm -pq --provides ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm |sort |uniq -c 1 Map.so()(64bit) 1 perl(File::Map) = 0.31 1 perl-File-Map = 0.31-2.fc15 1 perl-File-Map(x86-64) = 0.31-2.fc15 FIX: Remove the Map.so() as stated in rpmlint. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2574507). Ok. > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD FIX: BuildRequire perl(Test::Pod) >= 1.22 Otherwise, package is in line with Fedora and Perl packaging guildelines. Please correct all `FIX' prefixed lines and submit new spec file. Resolution: Package NOT APPROVED.
(In reply to comment #2) > > Patch0: perl-File-Map-0.31-pod.patch > FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41 > (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora is > affected, drop this patch or apply it conditionally on older RHEL distributions > (if necessary). Done. > TODO: Submit the perl-File-Map-0.31-tie.patch patches to upstream. Not done. This is a compat patch for older version of Perl, upstream may not be necessarily interested in it. Dropped it from the package instead. > FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be dual-lived > package in the future <http://search.cpan.org/~gbarr/IO/>. > FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be > dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>. Done. > FIX: Remove the private library from provides. You can do that by calling > `%{?perl_default_filter}' macro right before %description section. See > <https://fedoraproject.org/wiki/Perl_default_filter>. Done. > FIX: Remove executable bit from fastsearch.pl. Done. > > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD > FIX: BuildRequire perl(Test::Pod) >= 1.22 Done. SPEC: http://v3.sk/~lkundrak/SPECS/perl-File-Map.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-File-Map-0.31-3.fc14.src.rpm
Spec file changes: --- perl-File-Map.spec 2010-11-04 11:10:18.571439897 +0100 +++ perl-File-Map.spec.1 2010-11-03 19:31:17.000000000 +0100 @@ -1,13 +1,11 @@ Name: perl-File-Map Version: 0.31 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Memory mapping made simple and safe License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/File-Map/ Source0: http://www.cpan.org/authors/id/L/LE/LEONT/File-Map-%{version}.tar.gz -Patch0: perl-File-Map-0.31-pod.patch -Patch1: perl-File-Map-0.31-tie.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: perl >= 0:5.008 BuildRequires: perl(Const::Fast) @@ -18,16 +16,20 @@ BuildRequires: perl(Test::More) BuildRequires: perl(Test::Warn) BuildRequires: perl(Test::Pod::Coverage) +BuildRequires: perl(Test::Pod) >= 1.22 +BuildRequires: perl(IO::Handle) +BuildRequires: perl(Time::Hires) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +%{?perl_default_filter} + %description File::Map maps files or anonymous memory into perl variables. %prep %setup -q -n File-Map-%{version} -%patch0 -p1 -%patch1 -p1 +chmod -x examples/fastsearch.pl %build @@ -62,6 +64,10 @@ %changelog +* Wed Nov 03 2010 Lubomir Rintel (GoodData) <lubo.rintel> 0.31-3 +- Drop el5 secific patches +- Add more BuildRequires (Petr Pisar) + * Mon Oct 11 2010 Lubomir Rintel (GoodData) <lubo.rintel> 0.31-2 - Fix build on el5 > > > Patch0: perl-File-Map-0.31-pod.patch > > FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41 > > (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora > > is affected, drop this patch or apply it conditionally on older RHEL > > distributions (if necessary). > > Done. Ok. > > FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be > > dual-lived package in the future <http://search.cpan.org/~gbarr/IO/>. Ok. > > FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be > < dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>. > > Done. > +BuildRequires: perl(Time::Hires) Fix: Proper name is `perl(Time::HiRes)' (capital `R'). I'm sorry I got you wrong name. Use this one please, otherwise the package cannot be built. > > FIX: Remove the private library from provides. You can do that by calling > > `%{?perl_default_filter}' macro right before %description section. See > > <https://fedoraproject.org/wiki/Perl_default_filter>. > > Done. Ok. > > FIX: Remove executable bit from fastsearch.pl. > > Done. Ok. > > > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD > > FIX: BuildRequire perl(Test::Pod) >= 1.22 > > Done. Ok. FIX: Package does not build in F15 because of perl(Time::HiRes) typo (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576028). Please correct all `FIX' previxed notes and submit new spec file. Resolution: Package NOT APPROVED.
> FIX: Package does not build in F15 because of perl(Time::HiRes) typo > (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576028). I would swear I did built it... SPEC: http://v3.sk/~lkundrak/SPECS/perl-File-Map.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-File-Map-0.31-4.fc14.src.rpm
Spec file changes: --- perl-File-Map.spec 2010-11-03 19:31:17.000000000 +0100 +++ perl-File-Map.spec.1 2010-11-05 10:17:13.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-File-Map Version: 0.31 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Memory mapping made simple and safe License: GPL+ or Artistic Group: Development/Libraries @@ -18,7 +18,7 @@ BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod) >= 1.22 BuildRequires: perl(IO::Handle) -BuildRequires: perl(Time::Hires) +BuildRequires: perl(Time::HiRes) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %{?perl_default_filter} @@ -64,6 +64,9 @@ %changelog +* Fri Nov 05 2010 Lubomir Rintel (GoodData) <lubo.rintel> 0.31-4 +- Fix a BR typo + * Wed Nov 03 2010 Lubomir Rintel (GoodData) <lubo.rintel> 0.31-3 - Drop el5 secific patches - Add more BuildRequires (Petr Pisar) > > +BuildRequires: perl(Time::Hires) > Fix: Proper name is `perl(Time::HiRes)' (capital `R'). I'm sorry I got you > wrong name. Use this one please, otherwise the package cannot be built. Ok. > FIX: Package does not build in F15 because of perl(Time::HiRes) typo > (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576028). Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2579040). Ok. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-File-Map Short Description: Memory mapping made simple and safe Owners: lkundrak Branches: f13 f14 el6
Git done (by process-git-requests).
Thanks. Imported and built.
*** Bug 1547052 has been marked as a duplicate of this bug. ***