Bug 641410 - (CVE-2010-4242) CVE-2010-4242 kernel: missing tty ops write function presence check in hci_uart_tty_open()
CVE-2010-4242 kernel: missing tty ops write function presence check in hci_ua...
Status: CLOSED ERRATA
Product: Security Response
Classification: Other
Component: vulnerability (Show other bugs)
unspecified
All Linux
medium Severity medium
: ---
: ---
Assigned To: Red Hat Product Security
impact=moderate,public=20101008,sourc...
: Security
Depends On: 655661 655662 655663 655664 655666 655667 655668
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-08 11:55 EDT by Petr Matousek
Modified: 2015-08-19 04:57 EDT (History)
17 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-03-28 04:43:48 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Petr Matousek 2010-10-08 11:55:48 EDT
Problem description:

hci_uart_tty_open() is missing check that tty has a write op (a few don't), and you should check this at open and refuse if the ops you need don't exist (eg as SLIP does:

static int slip_open(struct tty_struct *tty)
{
        struct slip *sl;
        int err;

        if (!capable(CAP_NET_ADMIN))
                return -EPERM;

        if (tty->ops->write == NULL)
                return -EOPNOTSUPP;

Fortunately almost no system will have a driver loaded which lacks a write op, but this should be fixed.
Comment 1 Eugene Teo (Security Response) 2010-10-11 00:23:47 EDT
Discussion:
http://lkml.org/lkml/2010/10/7/255
Comment 2 Eugene Teo (Security Response) 2010-11-21 23:59:05 EST
Upstream commit:
http://git.kernel.org/linus/c19483cc5e56ac5e22dd19cf25ba210ab1537773
Comment 6 Eugene Teo (Security Response) 2010-12-14 22:55:56 EST
Acknowledgements:

Red Hat would like to thank Alan Cox for reporting this issue.
Comment 7 errata-xmlrpc 2011-01-04 11:52:36 EST
This issue has been addressed in following products:

  Red Hat Enterprise Linux 5

Via RHSA-2011:0004 https://rhn.redhat.com/errata/RHSA-2011-0004.html
Comment 8 errata-xmlrpc 2011-01-11 14:45:06 EST
This issue has been addressed in following products:

  Red Hat Enterprise Linux 6

Via RHSA-2011:0007 https://rhn.redhat.com/errata/RHSA-2011-0007.html
Comment 9 errata-xmlrpc 2011-01-18 12:45:10 EST
This issue has been addressed in following products:

  Red Hat Enterprise Linux 4

Via RHSA-2011:0162 https://rhn.redhat.com/errata/RHSA-2011-0162.html
Comment 11 errata-xmlrpc 2011-03-10 15:04:18 EST
This issue has been addressed in following products:

  MRG for RHEL-5

Via RHSA-2011:0330 https://rhn.redhat.com/errata/RHSA-2011-0330.html

Note You need to log in before you can comment on or make changes to this bug.