Spec URL: http://mifo.sk/RPMS/rubygem-net-sftp.spec SRPM URL: http://mifo.sk/RPMS/rubygem-net-sftp-2.0.5-1.fc13.src.rpm Description: Net::SFTP is a library built on top of Net::SSH that implements the SFTP file transfer protocol (actually, versions 1 through 6 of that protocol). Select one of the following links to read more about Net::SFTP.
Taking this one. Overall looks good with some small nits * rpmlint complains about mixing spaces / tabs, please remove the tab on line 25 "Summary: Documentation for %{name}" * Can you please change %source0 to point to the official rubygems.org gem * The license of the documentation file should be MIT and LGPLv2 as the setup.rb is licensed under the LGPL version 2.1 These are the only blockers, though I was also wondering why you specify "> 1.2" for the rubygems dependency (not wrong, just haven't see this before). Also if you have a moment the review guidelines state "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it", not a biggie though. Rpmlint looks fine (with the exception above), the package builds fine on koji, and I did a surface functionality test. Once the three blockers have been resolved about, this package is ready. APPROVED rubygem-net-sftp [mmorsi]
*** Bug 588446 has been marked as a duplicate of this bug. ***
(In reply to comment #1) > Taking this one. Overall looks good with some small nits > > * rpmlint complains about mixing spaces / tabs, please remove the tab on line > 25 > "Summary: Documentation for %{name}" Fixed. Now: rpmlint rubygem-net-sftp-2.0.5-2.fc13.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint rubygem-net-sftp-doc-2.0.5-2.fc13.noarch.rpm rubygem-net-sftp-doc.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint rubygem-net-sftp-2.0.5-2.fc13.src.rpm rubygem-net-sftp.src: W: no-buildroot-tag 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > * Can you please change %source0 to point to the official rubygems.org gem Fixed. > > * The license of the documentation file should be MIT and LGPLv2 as the > setup.rb is licensed under the LGPL version 2.1 Fixed. I write down a comment in %files to mark setup.rb file as LGPL > These are the only blockers, though I was also wondering why you specify "> > 1.2" for the rubygems dependency (not wrong, just haven't see this before). You're right. I removed that version dependency. > Also if you have a moment the review guidelines state "If the source package > does not include license text(s) as a separate file from upstream, the packager > SHOULD query upstream to include it", not a biggie though. Sure, will do :-) > > > Rpmlint looks fine (with the exception above), the package builds fine on koji, > and I did a surface functionality test. > > Once the three blockers have been resolved about, this package is ready. > > > APPROVED rubygem-net-sftp [mmorsi] Thanks for help and review! ======================== * Thu Oct 14 2010 Michal Fojtik <mfojtik> - 2.0.5-2 - Fixed license - Fixes source0 URL Spec URL: http://mifo.sk/RPMS/rubygem-net-sftp.spec SRPM URL: http://mifo.sk/RPMS/rubygem-net-sftp-2.0.5-2.fc13.src.rpm
New Package SCM Request ======================= Package Name: rubygem-net-sftp Short Description: A pure Ruby implementation of the SFTP client protocol Owners: mfojtik Branches: f12 f13 f14
Appreciate the update, though regarding the license, its still not fully right. Since setup.rb is shipped with the 'doc' subpackage, it is that package that needs the LGPLv2 in the license. Furthermore it needs to be MIT _and_ LGPLv2 (not _or_) as the provided sources are shipped under both those licenses. 'or' would be appropriate if upstream said 'you may use this project under the terms of the MIT license or the LGPL one, your choice'. So essentially the license for the main package should be 'LICENSE: MIT' and the license for the subpackage (put this under %package doc) should be 'LICENSE: MIT and LGPLv2' Now that being said, looking at setup.rb, it looks like we don't even need to ship it as it simply sets up the upstream environment for a build / install. Unless I'm wrong, you can also just remove setup.rb, and just ship the entire package (both net-sftp and the doc subpackage) under the MIT license. Your choice. Either way, once this license issue is resolved and git is setup, just push as my APPROVED still stands.
Git done (by process-git-requests). Please remember to assign reviews to the reviewer. ;)
rubygem-net-sftp-2.0.5-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-net-sftp-2.0.5-2.fc13
rubygem-net-sftp-2.0.5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-net-sftp-2.0.5-2.fc14
rubygem-net-sftp-2.0.5-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-net-sftp'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-net-sftp-2.0.5-2.fc14
rubygem-net-sftp-2.0.5-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-net-sftp-2.0.5-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.