Spec URL: http://mifo.sk/RPMS/rubygem-uuid.spec SRPM URL: http://mifo.sk/RPMS/rubygem-uuid-2.3.1-1.fc13.src.rpm Description: UUID generator for producing universally unique identifiers based on RFC 4122
I will take this review.
This review it's just NONFORMAL because i'm not in Fedora Packager Group right now. MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint rubygem-uuid-2.3.1-1.fc13.src.rpm rubygem-uuid.src: W: no-buildroot-tag rubygem-uuid.src: W: patch-not-applied Patch0: %{name}-require-rubygems-fix.patch 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [OK] MUST: The License field in the package spec file must match the actual license. License: GPLv2+ or Ruby [BAD - gem contains MIT-License] Each Ruby package MUST indicate the Ruby ABI version it depends on with a line like: Requires: ruby(abi) = 1.8 [OK - this MUST condition is written via macro in this spec file] Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname is the name from the Gem's specification. %global gemname uuid Name: rubygem-%{gemname} [OK] The Source of the package MUST be the full URL to the released Gem archive URL: http://github.com/assaf/uuid Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem [OK] The version of the package MUST be the Gem's version Version: 2.3.1 [OK] The package MUST have a Requires and a BuildRequires on rubygems %global rubyabi 1.8 Requires: ruby(abi) = %{rubyabi} Requires: rubygems Requires: rubygem(macaddr) BuildRequires: rubygems BuildRequires: rubygem(macaddr) BuildRequires: rubygem(rake) [OK] The Gem MUST be installed into %{gemdir} defined as: %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [OK] If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch BuildArch: noarch [OK] The package MUST own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [OK] The install SHOULD be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} [OK]
(In reply to comment #2) > This review it's just NONFORMAL because i'm not in Fedora Packager Group right > now. > > MUST: rpmlint must be run on every package. The output should be posted in the > review. > > rpmlint rubygem-uuid-2.3.1-1.fc13.src.rpm > rubygem-uuid.src: W: no-buildroot-tag > rubygem-uuid.src: W: patch-not-applied Patch0: > %{name}-require-rubygems-fix.patch > 1 packages and 0 specfiles checked; 0 errors, 2 warnings. > > [OK] > > MUST: The License field in the package spec file must match the actual license. > > License: GPLv2+ or Ruby > > [BAD - gem contains MIT-License] > > Each Ruby package MUST indicate the Ruby ABI version it depends on with a line > like: > Requires: ruby(abi) = 1.8 > > [OK - this MUST condition is written via macro in this spec file] > > Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname > is the name from the Gem's specification. > > %global gemname uuid > Name: rubygem-%{gemname} > > [OK] > > The Source of the package MUST be the full URL to the released Gem archive > > URL: http://github.com/assaf/uuid > Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem > > [OK] > > The version of the package MUST be the Gem's version > > Version: 2.3.1 > > [OK] > > The package MUST have a Requires and a BuildRequires on rubygems > > %global rubyabi 1.8 > > Requires: ruby(abi) = %{rubyabi} > Requires: rubygems > Requires: rubygem(macaddr) > BuildRequires: rubygems > BuildRequires: rubygem(macaddr) > BuildRequires: rubygem(rake) > > [OK] > > The Gem MUST be installed into %{gemdir} defined as: > %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) > > [OK] > > If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch > > BuildArch: noarch > > [OK] > > The package MUST own the following files and directories: > > %{gemdir}/gems/%{gemname}-%{version}/ > %{gemdir}/cache/%{gemname}-%{version}.gem > %{gemdir}/specifications/%{gemname}-%{version}.gemspec > > [OK] > > The install SHOULD be performed with the command > > gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} > > [OK] Please check this review also someone else (the best, who is sponsor)
Same as for previous package, please update with correct license.
Thanks guys for noticing that. Spec URL: http://mifo.sk/RPMS/rubygem-uuid.spec SRPM URL: http://mifo.sk/RPMS/rubygem-uuid-2.3.1-2.fc14.noarch.rpm
(In reply to comment #5) > Thanks guys for noticing that. > > Spec URL: http://mifo.sk/RPMS/rubygem-uuid.spec > SRPM URL: http://mifo.sk/RPMS/rubygem-uuid-2.3.1-2.fc14.noarch.rpm Everything is okay, so this package have REVIEW+.
Thanks for the review! New Package SCM Request ======================= Package Name: rubygem-uuid Short Description: Ruby UUID generator based on RFC 4122 Owners: mfojtik Branches: f13 f14
Git done (by process-git-requests).
Dependencies of uuid were never satisfied in Fedora and package was retired some while ago. http://pkgs.fedoraproject.org/cgit/rubygem-uuid.git/commit/?id=f38fdf0428f8e82507363e44a19d730b9b1141ba
*** This bug has been marked as a duplicate of bug 1177805 ***