Bug 642857 - Review Request: drupal6-advanced-help - Allows module developers to store their help outside the module system in html
Review Request: drupal6-advanced-help - Allows module developers to store th...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul W. Frields
Fedora Extras Quality Assurance
: 655547 (view as bug list)
Depends On:
Blocks: InsightReviews
  Show dependency treegraph
Reported: 2010-10-13 19:11 EDT by Sven Lankes
Modified: 2011-01-28 14:23 EST (History)
5 users (show)

See Also:
Fixed In Version: drupal6-advanced-help-1.2-2.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2011-01-28 14:23:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
stickster: fedora‑review+
tibbs: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Sven Lankes 2010-10-13 19:11:51 EDT
Spec URL: http://sven.lank.es/Fedora/SPECS/drupal-advanced-help.spec
SRPM URL: http://sven.lank.es/Fedora/SRPM/drupal-advanced-help-6.x.1.2-1.fc14.src.rpm
Description: The advanced help module allows module developers to store their help
outside the module system, in pure .html files. The files can be easily
translated simply by copying them into the right translations directory.
The entire system can appear in a popup or not as the module prefers.

rpmlint is clean (except some spelling fuzz)
Comment 1 Sven Lankes 2010-10-18 17:16:42 EDT
New files - changed the name to include the major drupal version this module is for in the name:

Spec URL: http://sven.lank.es/Fedora/SPECS/drupal6-advanced-help.spec
SRPM URL: http://sven.lank.es/Fedora/SRPM/drupal6-advanced-help-1.2-1.fc14.src.rpm
Comment 2 Christoph Wickert 2010-11-21 12:32:05 EST
*** Bug 655547 has been marked as a duplicate of this bug. ***
Comment 3 Paul W. Frields 2010-12-10 16:12:21 EST
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.

$ rpmlint rpmbuild/SPECS/drupal6-advanced-help.spec rpmbuild/SRPMS/drupal6-advanced-help-1.2-1.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-advanced-help-1.2-1.fc14.noarch.rpm 
drupal6-advanced-help.src: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml
drupal6-advanced-help.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
drupal6-advanced-help.noarch: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml
drupal6-advanced-help.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Please post verbatim for other reviews, thanks!

[ O K ] MUST: The package must be named according to the Package Naming

[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

[ O K ] MUST: The package must meet the Packaging Guidelines.

NOTE: The Requires: as listed will not work in EPEL, but they are fine
in Fedora.  To correct this issue, use Requires: drupal6 >= 6.0

[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.

[ O K ] MUST: The License field in the package spec file must match the actual

[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

[ O K ] MUST: The spec file must be written in American English. 

[ O K ] MUST: The spec file for the package MUST be legible. 

[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

$ md5sum rpmbuild/SOURCES/advanced_help-6.x-1.2.tar.gz ; curl -s -o - http://ftp.drupal.org/files/projects/advanced_help-6.x-1.2.tar.gz | md5sum -
a41a31032c907409ab5c330260c66fe8  rpmbuild/SOURCES/advanced_help-6.x-1.2.tar.gz
a41a31032c907409ab5c330260c66fe8  -

[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture. 

[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. 

[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

[ N/A ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun. 

[ O K ] MUST: Packages must NOT bundle copies of system libraries.

[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. 

[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory. 

[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific

[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line. 

[ O K ] MUST: Each package must consistently use macros. 

[ O K ] MUST: The package must contain code, or permissable content. 

[ O K ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). 

[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. 

[ N/A ] MUST: Header files must be in a -devel package. 

[ N/A ] MUST: Static libraries must be in a -static package. 

[ N/A ] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. 

[ N/A ] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =

[ N/A ] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[ N/A ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your packaged
GUI application does not need a .desktop file, you must put a comment in the
spec file with your explanation. 

[ O K ] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. 

[ O K ] MUST: All filenames in rpm packages must be valid UTF-8.

Package installs cleanly and module appears to work properly.
Comment 4 Sven Lankes 2010-12-21 16:48:17 EST
New Package SCM Request
Package Name: drupal6-advanced-help
Short Description: Allows module developers to store their help outside the module system in html
Owners: slankes limb
Branches: f13 f14 el6 el5
Comment 5 Jason Tibbitts 2010-12-22 12:18:34 EST
Git done (by process-git-requests).
Comment 6 Paul W. Frields 2010-12-23 10:41:54 EST
Sven, since git is now complete you can clone from git and build this package. Remember that in F-15 and/or EPEL, you may need to adjust the specfile to account for changes in the drupal6 base package. Once it's built and pushed for the appropriate branches, you can mark this bug CLOSED NEXTRELEASE.
Comment 7 Volker Fröhlich 2011-01-18 08:51:35 EST
Please check, if the license is stated as GPLv2+, as all modules hosted in Drupal's CVS must be.
Comment 8 Fedora Update System 2011-01-20 07:10:14 EST
drupal6-advanced-help-1.2-2.fc14 has been submitted as an update for Fedora 14.
Comment 9 Fedora Update System 2011-01-20 14:55:04 EST
drupal6-advanced-help-1.2-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update drupal6-advanced-help'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/drupal6-advanced-help-1.2-2.fc14
Comment 10 Fedora Update System 2011-01-28 14:23:25 EST
drupal6-advanced-help-1.2-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.