Bug 643229 - midori: MITM attacker can intercept background SSL connections without warning
Summary: midori: MITM attacker can intercept background SSL connections without warning
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: midori
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-15 00:45 UTC by Matt McCutchen
Modified: 2012-08-16 22:01 UTC (History)
5 users (show)

Fixed In Version:
Clone Of: 643224
Environment:
Last Closed: 2012-08-16 22:01:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Matt McCutchen 2010-10-15 00:45:02 UTC
+++ This bug was initially created as a clone of Bug #643224 +++

Description of problem:
The security problem I described for Epiphany in bug 643224 also affects Midori.

Version-Release number of selected component (if applicable):
midori-0.2.6-1.fc13.x86_64

How reproducible:
Always in my testing.

Steps to Reproduce:
1. Download and extract the test kit (attachment 453599 [details]).
2. Set "127.0.0.1 mattmccutchen.net" in /etc/hosts .
3. Run ./frontend (as root to bind to port 443) and ./self-signed-backend in separate terminals.
4. Start Midori and go to https://mattmccutchen.net/private/security-tests/include-script.html .  This test page embeds an image and an external script.  Midori will make one connection to request the page, which the kit proxies to my real web site, and a second connection to request the script, to which the kit responds with a self-signed certificate and "alert('xss')".  The legitimate script on my web site does not contain such an alert.

Actual results:
A dialog box saying "xss" appears, while the lock icon remains unbroken.

Expected results:
No dialog box.

Comment 1 Kevin Fenzi 2010-10-15 17:20:01 UTC
This looks to me like a webkitgtk issue, since it seems to occur with any webkitgtk based browser. 

Would you like to file this upstream? Or would you like me to do so?

WebKit has a 'xss auditor' thats enabled by default, but it seems to not do anything for this case.

Comment 2 Matt McCutchen 2010-10-15 18:07:41 UTC
(In reply to comment #1)
> This looks to me like a webkitgtk issue, since it seems to occur with any
> webkitgtk based browser.

Not exactly, see bug 643224 comment #2.

> Would you like to file this upstream? Or would you like me to do so?

Which upstream?  IIUC, not webkitgtk, because it just uses the HTTP library provided by the application.  Midori?  I would be happy to file it upstream if that would be appropriate (c.f. https://lists.fedoraproject.org/pipermail/devel/2010-July/138761.html).

Comment 3 Kevin Fenzi 2010-10-25 21:28:05 UTC
Just FYI, I have been discussing this with the upstream midori developer. 

libsoup doesn't really provide him much info to deal with this. ;( 

If ssl-strict is True, libsoup will error on non valid certs, but doesn't provide any info back aside from "this cert is not valid". It doesn't provide the binary cert data back to the caller. 

He's looking now to see if he can possibly use libgcr and pull the certs for that.

Comment 4 Fedora Admin XMLRPC Client 2011-03-15 17:20:49 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 5 Bug Zapper 2011-05-31 11:18:07 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Tomas Hoger 2011-06-01 09:08:58 UTC
midori-0.2.9-4.fc14
webkitgtk-1.3.10-1.fc14

Comment 7 Fedora End Of Life 2012-08-16 22:01:50 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.