Spec URL: http://people.redhat.com/avagarwa/files/passwdqc/passwdqc.spec SRPM URL: http://people.redhat.com/avagarwa/files/passwdqc/passwdqc-1.2.2-1.fc15.src.rpm Description: Hello, This is a review request for the package passwdqc. The package was named pam_passwdqc previously, but now renamed to passwdqc. passwdqc still provides pam_passwdqc, and also provides command line utilities pwqcheck and pwqgen for checking password strength. passwdqc also includes a libpasswdqc library and header file for building applications based on it.
Just two things: 1. move the %doc LICENSE to the -lib subpackage. 2. use %{_sysconfdir}/passwdqc.conf instead of /etc/passwdqc.conf in the %files
Tomas, thanks for the review. I have fixed these, and put the updated files at the same location, i.e., http://people.redhat.com/avagarwa/files/passwdqc/passwdqc.spec http://people.redhat.com/avagarwa/files/passwdqc/passwdqc-1.2.2-1.fc15.src.rpm
You should bump the release when you update spec file during review next time. But that doesn't matter now. rpmlint -v passwdqc-1.2.2-1.fc13.x86_64.rpm passwdqc-lib-1.2.2-1.fc13.x86_64.rpm passwdqc-devel-1.2.2-1.fc13.x86_64.rpm passwdqc-debuginfo-1.2.2-1.fc13.x86_64.rpm passwdqc-1.2.2-1.fc13.src.rpm passwdqc.x86_64: I: checking passwdqc.x86_64: W: spelling-error Summary(en_US) passphrase -> pass phrase, pass-phrase, paraphrase passwdqc.x86_64: W: spelling-error Summary(en_US) toolset -> tool set, tool-set, tools et passwdqc.x86_64: W: spelling-error %description -l en_US passphrase -> pass phrase, pass-phrase, paraphrase passwdqc.x86_64: W: spelling-error %description -l en_US toolset -> tool set, tool-set, tools et passwdqc.x86_64: W: spelling-error %description -l en_US passwd -> passed, pass wd, pass-wd passwdqc.x86_64: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases - these are just dummy warnings, no problem here passwdqc.x86_64: I: checking-url http://www.openwall.com/passwdqc/ (timeout 10 seconds) - probably some problem in rpmlint, the URL works fine in Firefox passwdqc-lib.x86_64: I: checking passwdqc-lib.x86_64: W: spelling-error %description -l en_US libpasswdqc - no problem here passwdqc-lib.x86_64: I: checking-url http://www.openwall.com/passwdqc/ (timeout 10 seconds) - same as above passwdqc-devel.x86_64: I: checking passwdqc-devel.x86_64: W: no-dependency-on passwdqc/passwdqc-libs/libpasswdqc - the dependency is on passwdqc-lib - there is only a single library so OK passwdqc-devel.x86_64: I: checking-url http://www.openwall.com/passwdqc/ (timeout 10 seconds) - same as above passwdqc-devel.x86_64: W: no-documentation - no problem passwdqc-debuginfo.x86_64: I: checking passwdqc-debuginfo.x86_64: I: checking-url http://www.openwall.com/passwdqc/ (timeout 10 seconds) - same as above passwdqc.src: I: checking passwdqc.src: W: spelling-error Summary(en_US) passphrase -> pass phrase, pass-phrase, paraphrase passwdqc.src: W: spelling-error Summary(en_US) toolset -> tool set, tool-set, tools et passwdqc.src: W: spelling-error %description -l en_US passphrase -> pass phrase, pass-phrase, paraphrase passwdqc.src: W: spelling-error %description -l en_US toolset -> tool set, tool-set, tools et passwdqc.src: W: spelling-error %description -l en_US pwqcheck -> paycheck, checkrow, hatcheck passwdqc.src: W: spelling-error %description -l en_US pwqgen -> progeny, pungent, pungency passwdqc.src: W: spelling-error %description -l en_US passwd -> passed, pass wd, pass-wd passwdqc.src: W: spelling-error %description -l en_US passphrases -> pass phrases, pass-phrases, paraphrases - same as above passwdqc.src: I: checking-url http://www.openwall.com/passwdqc/ (timeout 10 seconds) - same as above passwdqc.src: W: no-cleaning-of-buildroot %install passwdqc.src: W: no-cleaning-of-buildroot %clean passwdqc.src: W: no-buildroot-tag passwdqc.src: W: no-%clean-section - these are not required any longer passwdqc.src: I: checking-url http://www.openwall.com/passwdqc/passwdqc-1.2.2.tar.gz.sign (timeout 10 seconds) passwdqc.src: I: checking-url http://www.openwall.com/passwdqc/passwdqc-1.2.2.tar.gz (timeout 10 seconds) - I've verified that the tarball and signature can be loaded and is same as in the src.rpm provided by Avesh. 5 packages and 0 specfiles checked; 0 errors, 21 warnings. APPROVED
New Package CVS Request ======================= Package Name: passwdqc Short Description: A password/passphrase strength checking and policy enforcement toolset Owners: avesh Branches: F-14 F-15 InitialCC:
Git done (by process-git-requests). We are not yet doing f15 branches.