Spec URL: http://fedorapeople.org/~brouhaha/miglayout/miglayout.spec SRPM URL: http://fedorapeople.org/~brouhaha/miglayout/miglayout-3.7.3.1-1.fc12.src.rpm Koji scratch build for F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2541597 Koji scratch build for F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2541599 Description: MiGLayout is a versatile SWT/Swing layout manager. It uses String or API type-checked constraints to format the layout. MiGLayout can produce flowing, grid based, absolute (with links), grouped and docking layouts. MiGLayout is created to be to manually coded layouts what Matisse/GroupLayout is to IDE supported visual layouts. Additional note to potential reviewers: I am packaging miglayout because I want to package replicatorg, which is software to control 3D printers such as RepRap and MakerBot, and replicatorg depends on miglayout. Also, miglayout has been proposed for inclusion in a future release of the JDK, so this will allow those that develop Java software on Fedora to get a headstart with it.
Oh, goodie someone has alreayd packaged up miglayout, as miglayout is a new dep for upgrading freecol to the latest upstream release. I'm very interested in this! I'll start a review right away.
Full review done: Good: - rpmlint checks return: miglayout.noarch: W: no-documentation miglayout-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese 4 packages and 0 specfiles checked; 0 errors, 2 warnings. These can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text not in %doc, but that is normal for BSD, all source files do have BSD copyright headers - spec file legible, in am. english - source matches upstream - package compiles on f14 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - javadocs in -javadoc subpackage - nothing in %doc affects runtime - no need for .desktop file Now that is how easy all reviews should be, this is one well done package :) APPROVED!
Note I would be grateful if you could review one of the other 2 packages needed to be able to update freecol in return :) Bug 649777 - Review Request: jorbis - Pure Java Ogg Vorbis Decoder Bug 649781 - Review Request: cortado - Java media framework
New Package SCM Request ======================= Package Name: miglayout Short Description: Versatile and flexible Swing and SWT layout manager Owners: brouhaha Branches: F13 F14
Git done (by process-git-requests).
Ping? Can we please get this build for at least rawhide? Thanks, Hans
I'm having trouble importing it into git; there's some problem with the lookaside upload of the sources failing. I've verified that my certificate is good, and even tried generating and installing a new certificate, but it's still not working. My laptop is running Fedora 12; perhaps there was some regression in one of the updates that broke the fedpkg stuff, which was working for me previously. I need to back it up and upgrade to Fedora 14. I'm hoping to have time to do that this weekend. Sorry about the delay.
F12 should work, but you do need the nss update that was released some time ago. I have nss-3.12.8-2.fc12.x86_64 and don't have any issues.
Thanks Jason, that was the problem. I thought I'd gotten all the updates, but somehow missed some. I've submitted a build for rawhide, and builds for F13 and F14 are in progress. Hans, if I have time this weekend I'll review your packages, if someone else hasn't already.
miglayout-3.7.3.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/miglayout-3.7.3.1-1.fc13
Hi, (In reply to comment #9) > Thanks Jason, that was the problem. I thought I'd gotten all the updates, but > somehow missed some. > > I've submitted a build for rawhide, and builds for F13 and F14 are in progress. > Thanks, great! > Hans, if I have time this weekend I'll review your packages, if someone else > hasn't already. jorbis has already been reviewed. But if you could do cortado that would be great: Bug 649781 - Review Request: cortado - Java media framework Note please don't feel obligated to do this, I reviewed miglayout because freecol needs it, iow for my own reasons. But if you could review cortado in return I would be very grateful. Regards, Hans
miglayout-3.7.3.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update miglayout'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/miglayout-3.7.3.1-1.fc13
miglayout-3.7.3.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: miglayout New Branches: el6 Owners: brouhaha
miglayout-4.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/miglayout-4.0-2.el6
miglayout-4.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.