Hide Forgot
Spec URL: http://mifo.sk/RPMS/rubygem-webrat.spec SRPM URL: http://mifo.sk/RPMS/rubygem-webrat-0.7.2-1.fc13.src.rpm Description: Webrat lets you quickly write expressive and robust acceptance tests for a Ruby web application. It supports simulating a browser inside a Ruby process to avoid the performance hit and browser dependency of Selenium or Watir, but the same API can also be used to drive real Selenium tests when necessary (eg. for testing AJAX interactions).
Some notes: * rpmlint issues - Please suppress the following rpmlint issues ---------------------------------------------------------- rubygem-webrat-doc.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/private/core/configuration_spec.rb rubygem-webrat-doc.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/private/core/link_spec.rb rubygem-webrat-doc.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/webrat-0.7.2/spec/integration/merb/tasks/merb.thor/app_script.rb 0644L /usr/bin/env ---------------------------------------------------------- * Documents - I guess %geminstdir/install.rb can be moved to -doc subpackage ! Vendorlized jar file - Vendorlized jar file unpacked from gem file are surely removed. However this jar file is still included in gem file installed under %{gemdir}/cache/ and this makes the rebuilt binary rpm unneededly large. Would you - remove vendor/ (as it is) - fix webrat.gemspec and remove vendor/ entry - and recreate gem file by "$ thor :build" to reduce the size of gem file?
Hi Mamoru, I've picked this up from Michal. I made the changes you suggested in Comment #1, and also updated the package to 0.7.3. I've put the spec and SRPM here: http://people.redhat.com/clalance/rubygem-webrat Can you take a look? Thanks, Chris Lalancette
Taking this one. Reviewing http://people.redhat.com/clalance/rubygem-webrat/rubygem-webrat-0.7.3-1.fc14.src.rpm
Looks good. Koji build is green, http://koji.fedoraproject.org/koji/taskinfo?taskID=3199987 A couple comments - "--ri" should be passed to gem install - as mamoru pointed out %geminstdir/install.rb is still not marked as %doc, not sure if this is intentional though - since specs are shipped with the gem a %check section really should be included and the spec suite run, not strictly required tho would be good to add before pushing if possible The rpmlint issues have been taken care of and the vendorized selenium was removed from the cached gem. This package passes guidelines. APPROVED rubygem-webrat [mmorsi]
New Package CVS Request ======================= Package Name: rubygem-webrat Short Description: Ruby Acceptance Testing for Web applications Owners: clalance mmorsi Branches:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: rubygem-webrat New Branches: f15 Owners: clalance mmorsi InitialCC: