Spec URL: http://rpms.damian.net/SPECS/php-pecl-mongo.spec SRPM URL: http://rpms.damian.net/SRPMS/php-pecl-mongo-1.0.10-1.fc13.src.rpm Description: This package provides an interface for communicating with the MongoDB database in PHP. rpmlint: php-pecl-mongo.x86_64: W: private-shared-object-provides /usr/lib64/php/modules/mongo.so mongo.so()(64bit) 3 packages and 1 specfiles checked; 0 errors, 1 warnings. I have also run the test suite (which is not included in the PECL package). It runs just three errors, which seem to be problems of the test suite itself. I am in contact with the author.
Quick notes before actual review. > BuildRequires: php-pear >= 1.4.3 even if package (upstream) requires only pear 1.4.3, you must BR upper BuildRequires: php-pear >= 1:1.4.9-1.2 which is the first release which provides the needed macros (%{pecl_xmldir}...) (or you must redefine default value for all this macros) > Requires: php-common >= 5.1.0 this is not needed as you BR php-devel >= 5.1.0, and zend-abi will be check it (that you install with the same "major" version that you build with) > %post If you plan to push this package to EPEL-5, you still need to use the conditional scriplet > W: private-shared-object-provides Yes, we probably need to work on an improvment of PHP Guidelines ;) From : http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Removing_items_from_the_provides_stream_.28post-scan_filtering.29 You should add : %{?filter_setup: %filter_from_provides /%{pecl_name}.so/d %filter_setup } (and yes, we need to fix all existing pecl packages in fedora)
(In reply to comment #1) > BuildRequires: php-pear >= 1:1.4.9-1.2 > > which is the first release which provides the needed macros (%{pecl_xmldir}...) > (or you must redefine default value for all this macros) I always forget about that one, sorry. I am going to use the package mainly on EPEL5, so I included the conditional. I have uploaded a new version: Spec URL: http://rpms.damian.net/SPECS/php-pecl-mongo.spec SRPM URL: http://rpms.damian.net/SRPMS/php-pecl-mongo-1.0.10-2.fc13.src.rpm
Your filter_setup doesn't work : $ rpm -qp --provides php-pecl-mongo-1.0.10-2.fc14.x86_64.rpm ... mongo.so()(64bit) ... Should use %{pecl_name}.so, not %{python_sitearch}.*\.so$ Usually this filter is set at the top of the spec (before %description) Well, the rpmlint warning has disappear.. (don't understand this, strange behaviour of filter_from_provides vs filter_provides_in). Nedd work (for me). I don't see the conditionnal stuff needed for EL-5 (which is not a blocker for the "fedora" review)
The %filter_provides_in works well with %filter_provides_in %{php_extdir}/.*\.so$ or %filter_from_provides /%{pecl_name}.so/d (first seems more simple, especially when various extensions provided, like for php itself) We have strange result with %{python_sitearch}, but this seems really a typo ;)
(In reply to comment #4) > %filter_provides_in %{php_extdir}/.*\.so$ > or %filter_from_provides /%{pecl_name}.so/d > > (first seems more simple, especially when various extensions provided, like for > php itself) I use that one, I am using the pecl_extdir also in the file section. > > We have strange result with %{python_sitearch}, but this seems really a typo ;) indeed. I uploaded a new version which I fixed to build in EPEL5 (mock). The check section didn't work before. And I added a better mongo.ini file, which includes examples for all the options and sensible defaults for the ones that will change with 1.1.0. Spec URL: http://rpms.damian.net/SPECS/php-pecl-mongo.spec SRPM URL: http://rpms.damian.net/SRPMS/php-pecl-mongo-1.0.10-3.fc13.src.rpm
> And I added a better mongo.ini file, Great idea (you could even have a link to http://us.php.net/manual/en/mongo.configuration.php, as in php.ini) === FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: F-14 x86_64 (with php-5.3.4-dev) [x] Rpmlint output: php-pecl-mongo.spec: I: checking-url http://pecl.php.net/get/mongo-1.0.10.tgz (timeout 10 seconds) php-pecl-mongo.src: I: checking php-pecl-mongo.src: I: checking-url http://pecl.php.net/package/mongo (timeout 10 seconds) php-pecl-mongo.src: I: checking-url http://pecl.php.net/get/mongo-1.0.10.tgz (timeout 10 seconds) php-pecl-mongo.x86_64: I: checking php-pecl-mongo.x86_64: I: checking-url http://pecl.php.net/package/mongo (timeout 10 seconds) php-pecl-mongo-debuginfo.x86_64: I: checking php-pecl-mongo-debuginfo.x86_64: I: checking-url http://pecl.php.net/package/mongo (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 0 warnings. [x] Package is not relocatable. [x] Buildroot is correct Used : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: Apache [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : 16c934d86c9f02d96af7651dba6a8f9f mongo-1.0.10.tgz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final requires - f14 /usr/bin/pecl php(zend-abi) = 20090626 php(api) = 20090626 [x] Final requires - el5 /usr/bin/pecl config(php-pecl-mongo) = 1.0.10-3.el5 php-api = 20041225 [x] Final provides - f14 php-pecl(mongo) = 1.0.10-3.fc14 php-pecl-mongo = 1.0.10-3.fc14 php-pecl-mongo(x86-64) = 1.0.10-3.fc14 [x] Final provides - el5 config(php-pecl-mongo) = 1.0.10-3.el5 mongo.so()(64bit) php-pecl(mongo) = 1.0.10-3.el5 php-pecl-mongo = 1.0.10-3.el5 === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: F14 i386 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: koji build --scratch dist-5E-epel http://koji.fedoraproject.org/koji/taskinfo?taskID=2550095 [x] Package functions as described. [x] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [x] File based requires are sane. [x] %check is present and the tests pass + Load fine, event with most of available extensions installed (so no conflict detected) *** APPROVED ***
(In reply to comment #6) > > And I added a better mongo.ini file, > Great idea (you could even have a link to > http://us.php.net/manual/en/mongo.configuration.php, as in php.ini) also a good idea. I will do that on import. > *** APPROVED *** thanks! New Package SCM Request ======================= Package Name: php-pecl-mongo Short Description: PHP MongoDB database driver Owners: cdamian Branches: f13 f14 el5 el6 InitialCC:
Git done (by process-git-requests).
php-pecl-mongo-1.0.10-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/php-pecl-mongo-1.0.10-4.fc13
php-pecl-mongo-1.0.10-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-pecl-mongo-1.0.10-4.fc14
php-pecl-mongo-1.0.10-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pecl-mongo'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-pecl-mongo-1.0.10-4.fc13
php-pecl-mongo-1.0.10-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
php-pecl-mongo-1.0.10-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.