Spec URL: http://dcr226.fedorapeople.org/SPECS/django-mptt.spec SRPM URL: http://dcr226.fedorapeople.org/SRPMS/django-mptt-0.4.1-1.fc13.src.rpm Description: Utilities for implementing Modified Preorder Tree Traversal (MPTT) with your Django Model classes and working with trees of Model instances.
Koji scratch build urls: http://koji.fedoraproject.org/koji/taskinfo?taskID=2546977 <- f13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546980 <- f14 rpmlint output: clean across spec, src.rpm and rpm
Created attachment 463417 [details] spec file
Created attachment 463418 [details] srpm
Attached both an srpm and a spec for the new 0.4.2 version of django-mptt. This is needed to fix the problem of a missing register() function needed for applications such as django-dpaste (BZ #627180). Please have a look at these as I've cleaned up the spec a little and removed some redundant lines in the %files section. When you have a working srpm, please add a link and I will review. Clint
Thanks for this. I made a slight change (removed a couple of redundant comment lines from the spec, which cleaned up the output from rpmlint on the spec) to the spec, other than that - works for me :-) http://dcr226.fedorapeople.org/SRPMS/django-mptt-0.4.2-2.fc13.src.rpm http://dcr226.fedorapeople.org/SPECS/django-mptt.spec
Hello, The much awaited review. Sorry David, I just received my system yesterday. [+] OK [-] NA [?] Issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [ankur@ankur SPECS]$ md5sum django-mptt-0.4.2.zip ../SOURCES/django-mptt-0.4.2.zip 25156bf76b434e844a6141b24c4929da django-mptt-0.4.2.zip 25156bf76b434e844a6141b24c4929da ../SOURCES/django-mptt-0.4.2.zip - Package needs ExcludeArch + BuildRequires correct + Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. ? Package has a correct %clean section. ? Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Not needed any more and can be removed. http://fedoraproject.org/wiki/PackagingGuidelines#.25clean + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. [ankur@ankur result]$ rpmlint *.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done [ankur@ankur result]$ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done django-mptt-0.4.2-2.fc15.noarch.rpm django-mptt = 0.4.2-2.fc15 = python(abi) = 2.7 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 django-mptt-0.4.2-2.fc15.src.rpm = python2-devel python-setuptools rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 SHOULD Items: + Should build in mock. - Should build on all supported archs ? Should function as described. I haven't checked this. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Package looks good. Approved!!
New Package SCM Request ======================= Package Name: django-mptt Short Description: Utilities for implementing Modified Preorder Tree Traversal Owners: dcr226 Branches: f13 f14 f15 el5 el6 InitialCC: herlo
This ticket seems to be assigned to the person who will own the package. It is supposed to be assigned to the reviewer, and you can't review your own packages. Please sort this out, obtain a proper review if necessary, and re-raise the fedora-cvs flag.
I'm not sure what happened and when for this to be assigned to me, and not Ankur - but its quite obvious that I haven't reviewed my own package, from the comments above. I'll get in touch with Ankur and get this rectified..
I got no clue either :$ Anyway, I've assigned it to myself. Please open the scm request etc Dave. Ankur
Git done (by process-git-requests).
I went ahead and processed this, but did anyone notice that the URL in the above-linked spec is incorrect? All you get is a note that the software has moved to github. https://github.com/django-mptt/django-mptt/ is probably a better URL to use.
Awesome, thanks!! I'll update the spec now.. Cheers Dave
Packaged now orphaned in devel. Closing