Spec URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects-1.1.4-1.fc13.src.rpm Description: Enables editing of ForeignKey, ManyToMany and simple text fields using the Autocomplete - jQuery plugin. django-ajax-selects will work in any normal form as well as in the admin.
New release with fixes to some rpmlint warnings. Spec URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects-1.1.4-2.fc13.src.rpm
As requested, picking up this review. Also, FE-NEEDSPONSOR is not needed anymore. Let's start from the basics. The md5 for the tarball in your src.rpm does not match the upstream one. Please be sure to include in the srpm the unmodified tar.gz from upstream. The easiest way is to use "spectool -g django-ajax-selects.spec" to download it. Upstream looks a bit confused about licensing: pypi lists lgpl, google code MIT, while the LICENSE.txt claims it's dual licensed MIT and GPL. However, what counts is what's actually in the tarball, so please advice him to include the licenses text in the package and, preferably, add an header on each source file with the indication of the license. Our License: tag should be "MIT or GPL+" since dual licensing means you can choose which one to apply (so the "or") and not stating explicitly which GPL version to use means you can pick any. Of course, upstream can consider to clear this up in a later release. The rest of the spec file looks fine, I'll probably have more remarks after a build.
(In reply to comment #2) > As requested, picking up this review. Also, FE-NEEDSPONSOR is not needed > anymore. Fixed. > Let's start from the basics. > > The md5 for the tarball in your src.rpm does not match the upstream one. Please > be sure to include in the srpm the unmodified tar.gz from upstream. The easiest > way is to use "spectool -g django-ajax-selects.spec" to download it. Fixed. New tarball downloaded with spectool -g > Upstream looks a bit confused about licensing: pypi lists lgpl, google code > MIT, while the LICENSE.txt claims it's dual licensed MIT and GPL. > > However, what counts is what's actually in the tarball, so please advice him to > include the licenses text in the package and, preferably, add an header on each > source file with the indication of the license. It will be informed upstream. > Our License: tag should be "MIT or GPL+" since dual licensing means you can > choose which one to apply (so the "or") and not stating explicitly which GPL > version to use means you can pick any. Fixed. Spec URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/django-ajax-selects-1.1.4-3.fc13.src.rpm
Builds correctly and rpmlint is silent, apart from: django-ajax-selects.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry django-ajax-selects.noarch: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging django-ajax-selects.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry django-ajax-selects.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging 2 packages and 0 specfiles checked; 0 errors, 4 warnings. which I think we can ignore. One question remains, the project website states: Requirements * Django 1.0 + * jquery 1.26 + * Autocomplete - jQuery plugin 1.0.2 http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/ * jquery.autocomplete.css (included with Autocomplete) and the tarball does not bundle jquery and Autocomplete so I'm wondering how this is going to work after installation. Maybe we need to create another package for jquery?
(In reply to comment #4) > django-ajax-selects.noarch: W: spelling-error %description -l en_US jQuery -> j > Query, query, equerry > django-ajax-selects.noarch: W: spelling-error %description -l en_US plugin -> > plug in, plug-in, plugging > django-ajax-selects.src: W: spelling-error %description -l en_US jQuery -> j > Query, query, equerry > django-ajax-selects.src: W: spelling-error %description -l en_US plugin -> plug > in, plug-in, plugging > 2 packages and 0 specfiles checked; 0 errors, 4 warnings. > > which I think we can ignore. > jQuery and plugin are not English words according to aspell dictionary, but they are of common use. > One question remains, the project website states: > > Requirements > * Django 1.0 + > * jquery 1.26 + > * Autocomplete - jQuery plugin 1.0.2 > http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/ > * jquery.autocomplete.css (included with Autocomplete) > By reading the source code, the dependencies are * Django * ajax_select This module is ajax_select. It includes itself. js/ajax_select.js is (or should be) part of the site's admin js stack. Django is mentioned in the dependencies as BuildRequires and Requires. > and the tarball does not bundle jquery and Autocomplete so I'm wondering how > this is going to work after installation. AutoCompleteXXX classes are introduced by this package. They are not dependencies. See file ajax_select/fields.py > Maybe we need to create another > package for jquery? This I don't know. jQuery is only mention in ajax_select/__init__.py as introduction text, but it's not used as a class or instance. Perhaps it's part of the site's admin js stack too.
Ok. I've found this text in docs.txt """ Make sure that these js/css files appear on your page: * jquery-1.2.6.js or greater * jquery.autocomplete.js * jquery.autocomplete.css * ajax_select.js (for pop up admin support) * iconic.css (optional, or use this as a starting point) """ so it seems individual pages are supposed to take care of loading jquery. I think we are done here. REVIEW * Package name is correct * license is acceptable * License field matches actual license * License text is not included * sources matches upstream * builds in mock for F14 * rpmlint warnings (see above) can be ignored The package is approved, but please remember to push upstream to include the text in the next release.
New Package SCM Request ======================= Package Name: django-ajax-selects Short Description: Enables editing of ForeignKey, ManyToMany and simple text fields Owners: beckerde Branches: f13 f14 el5 el6 InitialCC: glezos diegobz
Git done (by process-git-requests).
django-ajax-selects-1.1.4-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/django-ajax-selects-1.1.4-3.fc14
django-ajax-selects-1.1.4-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/django-ajax-selects-1.1.4-3.fc13
django-ajax-selects-1.1.4-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/django-ajax-selects-1.1.4-3.el5
django-ajax-selects-1.1.4-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-ajax-selects'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/django-ajax-selects-1.1.4-3.fc14
django-ajax-selects-1.1.4-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
django-ajax-selects-1.1.4-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
django-ajax-selects-1.1.4-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.