Bug 645910 - build of fmal broken on s390(x)
Summary: build of fmal broken on s390(x)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc
Version: 14
Hardware: s390x
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Andreas Schwab
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-22 21:17 UTC by Dan Horák
Modified: 2016-11-24 16:03 UTC (History)
3 users (show)

Fixed In Version: glibc-2.12.90-21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-12-17 13:58:37 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dan Horák 2010-10-22 21:17:42 UTC
glibc-2.12.90-17 doesn't build on s390(x)

ake -s subdir=math -C math ..=../ others
make[2]: Entering directory `/builddir/build/BUILD/glibc-2.12-192-g7c08a05/math'
make[2]: Leaving directory `/builddir/build/BUILD/glibc-2.12-192-g7c08a05/math'
make[2]: Entering directory `/builddir/build/BUILD/glibc-2.12-192-g7c08a05/math'
In file included from ../sysdeps/ieee754/ldbl-64-128/s_fmal.c:4:0:
../sysdeps/ieee754/ldbl-128/s_fmal.c: In function '__fmal':
../sysdeps/ieee754/ldbl-128/s_fmal.c:179:7: error: output operand constraint lacks '='
../sysdeps/ieee754/ldbl-128/s_fmal.c:179:7: error: output operand constraint lacks '='
../sysdeps/ieee754/ldbl-128/s_fmal.c:179:7: error: invalid lvalue in asm output 0
make[2]: *** [/builddir/build/BUILD/glibc-2.12-192-g7c08a05/build-s390-linuxnptl/math/s_fmal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/builddir/build/BUILD/glibc-2.12-192-g7c08a05/math'
make[1]: *** [math/others] Error 2
make[1]: Leaving directory `/builddir/build/BUILD/glibc-2.12-192-g7c08a05'
make: *** [all] Error 2

problematic code in s_fmal.c:
      if ((u.ieee.mantissa3 & 1) == 0)
        u.ieee.mantissa3 |= fetestexcept (FE_INEXACT) != 0;
      v.d = a1 + u.d;
      /* Ensure the addition is not scheduled after fetestexcept call.  */
==>>  asm volatile ("" : "m" (v));
      int j = fetestexcept (FE_INEXACT) != 0;
      feupdateenv (&env);

Comment 1 Dan Horák 2010-10-22 21:23:03 UTC
for full build log please see https://s390.koji.fedoraproject.org/koji/taskinfo?taskID=220823

Comment 2 Jakub Jelinek 2010-10-22 21:51:21 UTC
Fixed in the s_fmal.c part of:
http://sources.redhat.com/ml/libc-hacker/2010-10/msg00009.html

Comment 3 Dan Horák 2010-10-25 07:26:02 UTC
Andreas, when do you plan to release a new glibc package that will include this fix? I will have to create a temporary package for s390(x) if it should take some time.


Note You need to log in before you can comment on or make changes to this bug.