Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 646708

Summary: regression: bnx2i driver returns garbage in host param callout and could oops
Product: Red Hat Enterprise Linux 5 Reporter: Mike Christie <mchristi>
Component: kernelAssignee: Mike Christie <mchristi>
Status: CLOSED ERRATA QA Contact: Storage QE <storage-qe>
Severity: medium Docs Contact:
Priority: low    
Version: 5.6CC: dtian, hjia, kzhang, ohudlick
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 21:58:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 677384    
Attachments:
Description Flags
Patch to fix the issue.
none
New patch to fix the problem using NIPQUAD and NIP6 none

Description Mike Christie 2010-10-26 01:04:37 UTC 
Description of problem:

bnx2i driver added iscsi get host pram ip address support in 5.6, but the function is returning garbage because I4/I6 is not implemented in the RHEL 5.6 kernel and the function could oops due to a invalid struct reference.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Michael Chan 2010-10-26 16:15:10 UTC 
Created attachment 455804 [details]
Patch to fix the issue.
Comment 2 Michael Chan 2010-10-27 18:24:05 UTC 
Created attachment 456043 [details]
New patch to fix the problem using NIPQUAD and NIP6
Comment 3 RHEL Program Management 2010-11-08 22:19:26 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 5 Jarod Wilson 2010-11-09 17:13:15 UTC 
in kernel-2.6.18-231.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.
Comment 13 Dayong Tian 2010-12-09 06:52:30 UTC 
Since there is no available hardware to use this time and Mike had tested the patch, I just did code review with kernel 2.6.18-236.el5.

The patch was included and applied in kernel 2.6.18-236.el5:

[root@intel-s3e8132-01 SPECS]# grep 646708 kernel-2.6.spec
- [scsi] bnx2i: fix ip address formatting and oops (Mike Christie) [646708]

[root@intel-s3e8132-01 SPECS]# grep -i "Patch26074" kernel-2.6.spec
Patch26074: linux-2.6-scsi-bnx2i-fix-ip-address-formatting-and-oops.patch
%patch26074 -p1
Comment 15 errata-xmlrpc 2011-01-13 21:58:21 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html
Comment 16 Hushan Jia 2011-02-18 08:28:09 UTC 
Set to storage land for iscsi bugs.