The stage#2 install.img is going away for good. The image will no longer be available as of F-15 and newer. Preupgrade will need to be adjusted accordingly. I'll be happy to fiddle with some patches once F-15 test images are available.
I have some concerns on how best to handle the situation of limited disk space in /boot since the initrd.img now contains *both* loader and stage2.
For discussions on this feature see https://www.redhat.com/archives/anaconda-devel-list/2010-August/msg00020.html
Sure, it kinda complicates the small /boot case, although I'm not overly bothered with just saying to the user "sorry, you can't do that" given we've defaulted to lvm and a larger boot for some time now.
Ping me when there's a test compose tree and I'll see what breaks. Thanks.
Adding to F15Beta so we don't forget that this impacts the F15Beta release criteria (https://fedoraproject.org/wiki/Fedora_15_Beta_Release_Criteria).
Test composes are coming online now and are available from http://serverbeach1.fedoraproject.org/pub/alt/stage/
Created attachment 481921 [details]
A quick'n'dirty lazy patch to address this problem.
Created attachment 481922 [details]
A slightly less lazy fix. I've tested both fixes and they work ... but I'm sure there is a more appropriate and preferred way to add support. Note, these patches only fix preupgrade-gtk.py.
(In reply to comment #4)
> Created attachment 481922 [details]
I've applied this after removing the added error message. There's nothing the user can do about a missing stage2 in F15+, so we don't need to tell them anything.
(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 481922 [details]
> > less-lazy-fix.patch
> I've applied this after removing the added error message. There's nothing the
> user can do about a missing stage2 in F15+, so we don't need to tell them
Do you need me to also patch the preupgrade-cli.py version? If you can point me to the patch accepted, I'll be happy to provide a -cli version.
That would be most appreciated, thanks.
Discussed at 2011-03-11 blocker review meeting. This is a clear blocker under criterion "The installer must be able to successfully complete an upgrade installation from a clean, fully updated default installation of the previous stable Fedora release, either via preupgrade or by booting to the installer manually".
Created attachment 484187 [details]
(In reply to comment #7)
> That would be most appreciated, thanks.
Tested patch. Note, this patch also removes data/releases.txt from the git repository. I suspect a corresponding preupgrade.spec change will be needed if this portion of the patch is accepted?
Author: James Laska <firstname.lastname@example.org>
Date: Tue Mar 15 10:38:32 2011 +0000
Fix preupgrade-cli now stage2 is not shipped in F15
Signed-off-by: Richard Hughes <email@example.com>
Fixed in preupgrade-1.1.9-1. Pending test feedback from preupgrade test day, this issue will move to ON_QA and be included an a future bodhi update.
Discussed at the 2011-03-25 blocker review meeting. We note that we had the Test Day and it seems to have been 'successful' as far as this issue is concerned. Can the updated preupgrade be submitted as an update now?
So far we are testing upgrading to F15 beta, please submit preupgrade-1.1.9-1 in comment#11 as an update asap.
New preupgrade updates are available for testing ....
Verified the updates worked as expected. Thanks, James.
(In reply to comment #15)
> Verified the updates worked as expected. Thanks, James.
Nice work, thanks Hurry and Richard!
the update's gone stable in the two releases where it's critical atm, it'll go stable in f15 when freeze is listed: closing.