Bug 646876 - Non-ascii characters are not allowed in user password
Summary: Non-ascii characters are not allowed in user password
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-users
Version: 14
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-26 14:34 UTC by Kamil Páral
Modified: 2011-04-19 19:26 UTC (History)
2 users (show)

Fixed In Version: system-config-users-1.2.107-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-02 19:33:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
s-c-u disallowing non-ascii passwords (360.73 KB, image/png)
2010-10-26 14:43 UTC, Kamil Páral
no flags Details

Description Kamil Páral 2010-10-26 14:34:52 UTC
Description of problem:
system-config-users does not allow to create user with non-ascii password. On the other hand standard 'passwd' tool allows that. Is there any reason to prohibit non-ascii password?

Version-Release number of selected component (if applicable):
system-config-users-1.2.105-1.fc14.noarch

How reproducible:
always

Steps to Reproduce:
1. try to create a new user with non-ascii characters in his password (like ěščřžýá)
  
Actual results:
user is not created

Expected results:
user is created

Additional info:
This bug report relates to system-config-users and firstboot.

Comment 1 Kamil Páral 2010-10-26 14:43:46 UTC
Created attachment 455780 [details]
s-c-u disallowing non-ascii passwords

Comment 2 Nils Philippsen 2010-10-26 15:04:33 UTC
The problem may be two-fold:

- Ordinary users probably don't know what ASCII is. How about:

"The chosen password contains characters which may be hard or impossible to type in in certain situations. To ensure the password can be typed in everywhere please use only unaccented Latin letters (A-Z, a-z), digits (0-9), punctuation characters (e.g. comma, full stop) and the space character in the password."

- s-c-users probably should only warn about this and let the operator decide if this should be done regardless (after the appropriate admonition).

Comment 3 James Laska 2010-10-26 16:21:03 UTC
(In reply to comment #2)
> - s-c-users probably should only warn about this and let the operator decide if
> this should be done regardless (after the appropriate admonition).

I like this idea ... it fits naturally with the existing mechanism that warns whether a password is weak.

Comment 4 Nils Philippsen 2010-11-29 16:39:38 UTC
fixed in git:

commit 17ea8b8d64c4070ff3f5af460804850f154569a5
Author: Nils Philippsen <nils>
Date:   Mon Nov 29 17:38:08 2010 +0100

    ask if non-ASCII password should be used (#646876)

Comment 5 Fedora Update System 2011-01-26 16:57:12 UTC
system-config-users-1.2.106-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/system-config-users-1.2.106-1.fc14

Comment 6 Fedora Update System 2011-01-26 16:58:08 UTC
system-config-users-1.2.106-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/system-config-users-1.2.106-1.fc13

Comment 7 Fedora Update System 2011-01-26 20:54:47 UTC
system-config-users-1.2.106-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-users'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-users-1.2.106-1.fc14

Comment 8 Kamil Páral 2011-01-31 08:12:36 UTC
system-config-users-1.2.106-1.fc14 does not work for me:

Traceback (most recent call last):
  File "/usr/share/system-config-users/userWindow.py", line 215, in on_userWin_ok_button_clicked
    if createHomeDir and not userGroupCheck.isHomedirOk(homeDir, self.userWinHomeDir):
  File "/usr/share/system-config-users/userGroupCheck.py", line 276, in isHomedirOk
    if selinux.is_selinux_enabled():
AttributeError: 'module' object has no attribute 'is_selinux_enabled'


That happens when I receive warning about non-ascii password and hit "Yes" for "use anyway" question.

Comment 9 Nils Philippsen 2011-01-31 11:19:44 UTC
got hit by dead code:

commit b3fc3280cda4f69884b31f8103344092e4eeb8d4
Author: Nils Philippsen <nils>
Date:   Mon Jan 31 12:16:10 2011 +0100

    remove obsolete selinux module
    
    presence of this module blocks use of system-wide one (#646876)

Comment 10 Fedora Update System 2011-02-01 20:54:48 UTC
system-config-users-1.2.107-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-users'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-users-1.2.107-1.fc14

Comment 11 Fedora Update System 2011-02-02 19:33:49 UTC
system-config-users-1.2.107-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2011-04-19 19:26:52 UTC
system-config-users-1.2.107-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.