Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 647128

Summary: audit_encode_nv_string() will crash on NULL pointer on OOM
Product: Red Hat Enterprise Linux 6 Reporter: Daniel Berrangé <berrange>
Component: auditAssignee: Steve Grubb <sgrubb>
Status: CLOSED ERRATA QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: ebenes, syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: audit-2.1-1.el6 Doc Type: Bug Fix
Doc Text:
Previously, the audit_encode_nv_string() function was not checking if the memory allocation (malloc) it was performing succeeded. Consequently, if the malloc operation encountered an out of memory (OOM) error, audit_encode_nv_string() crashed attempting to reference a NULL pointer. With this update, audit_encode_nv_string() checks if the malloc is successful, which resolves this issue.
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:55:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daniel Berrangé 2010-10-27 10:09:54 UTC
Description of problem:
This code in audit_encode_nv_string() will crash in audit_encode_value() by referencing a NULL pointer if malloc() hits OOM.

                char *tmp = malloc(2*vlen + 1);
                audit_encode_value(tmp, value, vlen);
                asprintf(&str, "%s=%s", name, tmp);
                free(tmp);

It needs to check the malloc return value, and return NULL to the caller immediately upon malloc failure, so that the caller can take appropriate action.

Version-Release number of selected component (if applicable):
audit-2.0.4-1.el6

How reproducible:
On OOM only

Steps to Reproduce:
1. N/a
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 Steve Grubb 2010-11-04 20:36:17 UTC
Fix checked in upstream:
https://fedorahosted.org/audit/changeset/420

Should be in audit-2.0.6

Comment 4 Steve Grubb 2011-02-04 18:54:02 UTC
audit-2.0.6-1.el6 was built to fix this problem.

Comment 8 Steve Grubb 2011-03-30 16:17:23 UTC
audit-2.1-1.el6 was built to resolve this issue.

Comment 12 errata-xmlrpc 2011-05-19 13:55:34 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0653.html