Bug 647440 – install_process_keyring() may return wrong error code

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 647440 - install_process_keyring() may return wrong error code

Summary:	install_process_keyring() may return wrong error code

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	kernel (Show other bugs)
Sub Component:
Version:	6.0
Hardware:	Unspecified Unspecified

Priority	low Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	David Howells
QA Contact:	Red Hat Kernel QE team
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2010-10-28 07:56 EDT by David Howells
Modified:	2011-05-19 08:37 EDT (History)
CC List:	0 users

See Also:
Fixed In Version:	kernel-2.6.32-83.el6
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2011-05-19 08:37:28 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Error handling fix (465 bytes, patch) 2010-10-28 08:15 EDT, David Howells	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2011:0542	normal	SHIPPED_LIVE	Important: Red Hat Enterprise Linux 6.1 kernel security, bug fix and enhancement update	2011-05-19 07:58:07 EDT

Groups: None (edit)

Description David Howells 2010-10-28 07:56:21 EDT

install_process_keyring() may return a broken error code if it encounters an OOM condition.  The problem is this line:

                return ret != -EEXIST ?: 0;

which will return the result of the comparison if it succeeds (i.e. 1).  What it should return is ret.

This isn't too much of a problem.  The worst that can happen is that lookup_user_key() keeps looping around until the OOM condition goes away, but it is allowed to sleep whilst allocating memory.

Comment 2 David Howells 2010-10-28 08:15:09 EDT

Created attachment 456226 [details]
Error handling fix

Comment 3 RHEL Product and Program Management 2010-10-28 08:29:32 EDT

This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 4 Aristeu Rozanski 2010-11-17 14:46:55 EST

Patch(es) available on kernel-2.6.32-83.el6

Comment 8 errata-xmlrpc 2011-05-19 08:37:28 EDT

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0542.html

Note You need to log in before you can comment on or make changes to this bug.