This is my second package after atool (#647063), I would need a sponsor. Spec URL: http://pcarrier.fedorapeople.org/packages/nzbget/nzbget.spec SRPM URL: http://pcarrier.fedorapeople.org/packages/nzbget/nzbget-0.7.0-1.fc14.src.rpm Description: -- 8< -- NZBGet is a command-line based binary newsgrabber for nzb files, written in C++. It supports client/server mode, automatic par-check/-repair. NZBGet requires low system resources and runs great on routers and NAS-devices. NZBGet can be used in standalone and in server/client modes. In standalone mode NZBGet downloads listed files and then exits. In server/client mode NZBGet runs as server in background. Clients send requests such as downloading an NZB file, listing files in queue, etc. Standalone-tool, server and client are all contained in a single binary. -- >8 --
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2563121 fc14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2563129
I'll review it too (and will sponsor you).
Unblocking FE-NEEDSPONSOR - I just sponsored pcarrier.
Notes: a) You're installing config-file as a doc-file, but would it be better to install in into /etc/ ? User will get ready-to-go application right after installing then. However looking at the config-file I found that it has too many options which should be adjusted for that (directory paths, server's addresses an so on). Also I have no clue about typical workflow involving nzbget, so feel free to disregard this advice entirely if it would require too much manpower and offer only negligible income. b) You should add AUTHORS files (it a generally good idea to mention people who work hard on providing all that stuff for us) and you *MUST* add COPYING to %doc c) You decided not to install init-script (nzbgetd) - is it intentional? Maybe it's better to package it too. However (as I sated earlier) I have no clue how to use thos application. so I don't have strong opinion here. Please, comment these notes, and I'll continue.
a) It is an example configuration file. I would consider most sysadmins would not have a system-wide config file and let users have their own in ~/.nzbget b) Done for AUTHORS and COPYING, I feel sorry I missed those... Also added a reminder comment for NEWS (currently empty). c) As for a), I wouldn't expect system-wide use. If I get opposite feedback, I'll be happy to add a system-wide initscript and configuration file. Updated, no release bump as this package was not distributed yet.
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is not silent but all its mesaages may be ignored in this case (false positives): sulaco ~/Desktop: rpmlint nzbget-* nzbget.i686: W: spelling-error Summary(en_US) newsgrabber -> news grabber, news-grabber, newsgroup nzbget.i686: W: spelling-error Summary(en_US) nzb -> neb, nib, nab nzbget.i686: W: spelling-error %description -l en_US newsgrabber -> news grabber, news-grabber, newsgroup nzbget.i686: W: spelling-error %description -l en_US nzb -> neb, nib, nab nzbget.i686: W: no-manual-page-for-binary nzbget 2 packages and 0 specfiles checked; 0 errors, 5 warnings. sulaco ~/Desktop: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv2 or later). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum nzbget-0.7.0.tar.gz* b798bbcc9f6816b4e19a95f74df067440f7ad49e1c16a3f33f99bddf7916771e nzbget-0.7.0.tar.gz b798bbcc9f6816b4e19a95f74df067440f7ad49e1c16a3f33f99bddf7916771e nzbget-0.7.0.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. APPROVED
Thank you for the approval.
New Package SCM Request ======================= Package Name: nzbget Short Description: Command-line based binary newsgrabber for nzb files Owners: pcarrier Branches: f14 el6 InitialCC: pcarrier
Git done (by process-git-requests).