Spec URL: http://pcarrier.fedorapeople.org/packages/libMicro/libMicro.spec SRPM URL: http://pcarrier.fedorapeople.org/packages/libMicro/libMicro-0.4.0-1.fc14.src.rpm Description: --- 8< --- LibMicro is a portable set of micro-benchmarks that many Solaris engineers used during Solaris 10 development to measure the performance of various system and library calls. LibMicro was developed by Bart Smaalders and Phil Harman as part of their If Linux is faster it's a Solaris bug performance campaign. The libMicro sources include an awk script that generates color coded HTML pages to easily compare various OS revs, processors and other differences in a quick manner. --- >8 ---
I don't think we should use %{optflags} on this one, we don't want to impact the benchmark. Opinions appreciated.
Run rpmlint on the src.rpm and your built rpms. It's one of the things a packager ought to do. The ReviewGuidelines are not specific to the reviewer(s). ;) > %{_libexecdir}/%{name}/* What package owns %{_libexecdir}/%{name} then? http://fedoraproject.org/wiki/Packaging:UnownedDirectories > I don't think we should use %{optflags} on this one, we don't want > to impact the benchmark. Opinions appreciated. Not using %optflags and hence also creating a bad -debuginfo package doesn't fly. How much overhead do you expect from the code that does the measuring compared with the actual execution time of the system calls?
Thanks Michael. Updated. $ rpmlint -v RPMS/x86_64/libMicro-0.4.0-1.fc14.x86_64.rpm libMicro.x86_64: I: checking libMicro.x86_64: W: spelling-error %description -l en_US awk -> awl, aw, wk libMicro.x86_64: I: checking-url http://hub.opensolaris.org/bin/view/Project+libmicro/ (timeout 10 seconds) libMicro.x86_64: W: no-manual-page-for-binary multiview libMicro.x86_64: W: no-manual-page-for-binary bench 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
- rpmlint checks return: libMicro.spec: W: invalid-url Source0: http://hub.opensolaris.org/bin/download/Project+libmicro/Source+Archives/libmicro-0.4.0.tar.gz <urlopen error [Errno 104] Connection reset by peer> The value should be a valid, public HTTP, HTTPS, or FTP URL. libMicro.src: W: invalid-url URL: http://hub.opensolaris.org/bin/view/Project+libmicro/ <urlopen error [Errno 104] Connection reset by peer> The value should be a valid, public HTTP, HTTPS, or FTP URL. Is this upstream still valid? libMicro.x86_64: W: no-manual-page-for-binary multiview Each executable in standard binary directories should have a man page. libMicro.x86_64: W: no-manual-page-for-binary bench Each executable in standard binary directories should have a man page. If these exist, include them. Other than that and the awk spelling, it's quiet. ??? package meets naming guidelines If upstream is libmicro, why libMicro? OK package meets packaging guidelines OK license ( ) OK, text in %doc, matches source OK spec file legible, in am. english See above, can't check! source matches upstream OK on x86_64 package compiles on devel (x86) - no missing BR - no unnecessary BR OK no locales OK not relocatable OK owns all directories that it creates OK no duplicate files OK permissions ok OK %clean ok OK macro use consistent OK code, not content OK no need for -docs OK nothing in %doc affects runtime OK no need for .desktop file Mock build to chck BRs in progress.
Mock build good, BRs are Ok. So it's upstream URLs and name capitalization and that's it.
new upstream release 0.4.1 : http://hub.opensolaris.org/bin/view/Project+libmicro/Source+Archives
Any updates to your SRPM so I can finish this up?
Ping?
Closing due to lack of submitter response, if you still wish to get this package into Fedora please submit a new review. Thanks!