Description of problem: I have a cloned repo --feed=origin. I run repo sync on the cloned repo and try to cancel the repo sync. I get the sync for repository canceled. And I see the following error in the log. 2010-11-03 10:40:56,958 [CRITICAL][Thread-1] _dispatch() @ fifo.py:84 - Exception in FIFO Queue Dispatch Thread Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/pulp/server/tasking/queue/fifo.py", line 79, in _dispatch self._cancel_tasks() File "/usr/lib/python2.6/site-packages/pulp/server/tasking/queue/fifo.py", line 106, in _cancel_tasks task.thread.cancel() File "/usr/lib/python2.6/site-packages/pulp/server/tasking/queue/thread.py", line 250, in cancel self.raise_exception(CancelException) File "/usr/lib/python2.6/site-packages/pulp/server/tasking/queue/thread.py", line 235, in raise_exception for thread in get_descendants(self): File "/usr/lib/python2.6/site-packages/pulp/server/tasking/queue/thread.py", line 114, in get_descendants descendants.extend(_thread_tree.get(d(), [])) File "/usr/lib64/python2.6/weakref.py", line 260, in get return self.data.get(ref(key),default) TypeError: cannot create weak reference to 'NoneType' object But log shows that the sync is continuing.
removed race conditions in cancel code
Fixed in 0.83.
fails_qa [root@preethi ~]# rpm -qa |grep pulp pulp-common-0.0.108-1.fc13.noarch pulp-client-0.0.108-1.fc13.noarch pulp-0.0.108-1.fc13.noarch [root@preethi ~]# pulp-admin repo status --id=clone_f14 +------------------------------------------+ Status for clone_f14 +------------------------------------------+ Repository: clone_f14 Number of Packages: 0 Last Sync: never [root@preethi ~]# pulp-admin repo cancel_sync --id=clone_f14 No sync to cancel [root@preethi ~]# pulp-admin repo status --id=clone_f14 +------------------------------------------+ Status for clone_f14 +------------------------------------------+ Repository: clone_f14 Number of Packages: 0 Last Sync: never [root@preethi ~]# pulp-admin repo cancel_sync --id=clone_f14
Sending back to QE to take another look; the last comment doesn't look like it conveys what the bug is.
Looks like this is fixed verified [root@preethi ~]# rpm -q pulp pulp-0.0.122-1.fc14.noarch [root@preethi ~]# pulp-admin repo sync --id=f13-clone3 Sync for repository f13-clone3 started Use "repo status" to check on the progress [root@preethi ~]# pulp-admin repo sync --id=f13-clone -F Sync for repository f13-clone started You can safely CTRL+C this current command and it will continue [================= ] 34% (1041 of 3111 pkgs) Sync: Canceled Warning: 14 errors occurred [root@preethi ~]# pulp-admin repo status --id=f13-clone +------------------------------------------+ Status for f13-clone +------------------------------------------+ Repository: f13-clone Number of Packages: 3102 Last Sync: 2011-01-11 11:59:25.683000
Closing with Community Release 15 pulp-0.0.223-4.