RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
In RHEL5, semanage_commit() would return -1 on error or the new policy sequence number (> 0) on success.

However, in RHEL6, this has changed to returning 0 on success, but the header file still indicates that it should be returning a policy number.


Version-Release number of selected component (if applicable):
libsemanage-2.0.43-4.el6

How reproducible:
Every time


Steps to Reproduce:
1. Write a program that uses the semanage_commit() function
2. Check the return code of this function during success and failure
  
Actual results:
Returns zero on success

Expected results:
Returns a policy sequence number > 0

Additional info:
(03:40:15 PM) eparis: sgallagh: in RHEL5 we always called a function called semanage_install_sandbox() which returned the policy number.  Between RHEL5 and RHEL6 we only called that function if there were changes.
(03:40:27 PM) sgallagh: ahh
(03:40:59 PM) eparis: best fix would be to move the policy number lookup from that function up into semanage_direct_commit()

Given that this changes the expected return values of a public function, I think this bug should be catagorized as a regression.

This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.