Bug 649489
| Summary: | [Emulex 5.6 bug] Update lpfc driver to version 8.2.0.87 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Joseph Mann <joseph.mann> | ||||
| Component: | kernel | Assignee: | Rob Evers <revers> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.6 | CC: | andriusb, bdonahue, cvantuin, cward, dhoward, joseph.mann, jpirko, laurie.barry, marting, mgoodwin, plyons, revers, theo_nra, vaios.papadimitriou | ||||
| Target Milestone: | rc | Keywords: | OtherQA, ZStream | ||||
| Target Release: | 5.6 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-13 21:59:36 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 658864 | ||||||
| Attachments: |
|
||||||
Please provide the exact changelog here in this bugzilla. Red Hat does not accept wholesale driver updates post-Beta. This bug will close if the exact issues this patchset resolves are not stated. Features are also not allowed post-Beta. Andrius, The following changelog is included in the patchset tarball: r9295_r9294_CR111422.patch: Fixed crashes for NULL pnode dereference. (CR: 111422) r9335.patch: Properly handle devloss timeout during various phases of FIP engine state transactions (CR: 109955) r9336.patch: Abort all I/Os and wait XRI exchange busy complete before function reset ioctl in SLI4 driver unload (CR: 110980) r9339.patch: Fix locking issue for security mailbox commands. r9341_r9203_CR110683.patch: Fix regression error for handling SLI4 unsolicted ELS. Read Link Error Status Block (RLS) (CR: 110683) r9342.patch: Fix regression error for handling ECHO response support. (CR: 110683) r9343_r9254_CR110683.patch: Fix regression error for handling SLI4 unsolicted ELS. Read Timeout Value (RTV) (CR: 110683) This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Reviewing against latest upstream
The following code is still upstream:
@@ -7334,18 +7335,6 @@ lpfc_sli_issue_abort_iotag(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
(cmdiocb->iocb_flag & LPFC_DRIVER_ABORTED) != 0)
return 0;
- /* If we're unloading, don't abort iocb on the ELS ring, but change the
- * callback so that nothing happens when it finishes.
- */
- if ((vport->load_flag & FC_UNLOADING) &&
- (pring->ringno == LPFC_ELS_RING)) {
- if (cmdiocb->iocb_flag & LPFC_IO_FABRIC)
- cmdiocb->fabric_iocb_cmpl = lpfc_ignore_els_cmpl;
- else
- cmdiocb->iocb_cmpl = lpfc_ignore_els_cmpl;
- return 0;
- }
-
This function appears to have diverged some also.
Pointing this out in case Emulex needs to fix upstream.
---
r9341_r9203_CR110683.patch:Fix regression error for handling SLI4 unsolicted ELS. Read Link Error Status Block (RLS) (CR: 110683)
r9342.patch - Fix regression error for handling ECHO response support. (CR: 110683)
r9343_r9254_CR110683.patch - Fix regression error for handling SLI4 unsolicted ELS. Read Timeout Value (RTV) (CR: 110683)
I assume regressions in the above three patch titles means your regression test.
These are all new functionality from what I can tell.
First glance at the titles of these patches was somewhat misleading in that they appeared to be bug fixes. It would help if this were avoided in the future since assessing patches by reading the titles usually gets done somewhat before pushing them for inclusion into rhel, which is when the patches actually get inspected.
Thanks. And thanks for the updates.
Vaios and/or Joseph, or anyone from Emulex engineering - could you please provide more info (bug details, what's fixed, what's new) for each of the patches listed in comment #2, preferably with an explanation of some of the acronyms too? Are the CR:XXXXX bug reports visible outside Emulex? Thanks -- Mark Vaios, Could you tar up the CRXXXX reports for the patches included in this update and attach them here for Mark? Mark is looking for updates that could address some ongoing support issues. Thanks, Rob in kernel-2.6.18-233.el5 You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5 Detailed testing feedback is always welcomed. *** Bug 640225 has been marked as a duplicate of this bug. *** Reminder! There should be a fix present for this BZ in snapshot 3 -- unless otherwise noted in a previous comment. Please test and update this BZ with test results as soon as possible. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0017.html |
Created attachment 457569 [details] Patchset to update Emulex LPFC driver to 8.2.0.87 (applies on top of 8.2.0.86) The attached tarball contains: 1. The set of patches; each patch corresponds to an individual fix as per agreement. 2. A README file that describes the patch naming scheme, and directions and instructions on how to apply the patches. 3. The ChangeLog of the fixes included in this patchset.