Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-rspec-mocks/rubygem-rspec-mocks.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-rspec-mocks/rubygem-rspec-mocks-2.0.1-1.fc.src.rpm Description: rspec-mocks provides a test-double framework for rspec including support for method stubs, fakes, and message expectations.
Updated: http://mtasaka.fedorapeople.org/Review_request/rubygem-rspec-mocks/rubygem-rspec-mocks.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-rspec-mocks/rubygem-rspec-mocks-2.5.0-1.fc.src.rpm * Thu Feb 17 2011 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 2.5.0-1 - 2.5.0
Taking this one.
* Dependency - I see no reason for the sed at line 58. There is no dependency mentioned in any of the specified files. * Unnecessary prep section - If there is no "sed" in prep section, the "gem install" could be moved into install section. This is not MUST, however it would simplify the spec file a bit. * Test suite - Some specs are not executed (there are 7 specs missing). The test suite should be executed by following command preferably: ruby -rubygems -Ilib/ -S rspec spec - What about executing Cucumber test suite? But there is probably missing packaged Aruba gem :/ * Koji: - Builds fine on Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2859806 Neither one of the above is showstopper, so the package is APPROVED.
Thank you for review and comments. I will refrect them when I import this package into Fedora git. New Package SCM Request ======================= Package Name: rubygem-rspec-mocks Short Description: Rspec-2 doubles (mocks and stubs) Owners: mtasaka Branches: f15 f14 f13 InitialCC:
Git done (by process-git-requests).
Rebuilt for all branches, submitted push requests for F-15/14/13, closing. Thank you for the review and git procedure.
Package Change Request ====================== Package Name: rubygem-rspec-mock New Branches: el6 Owners: bkearney vondruch InitialCC:
Package does not appear to exist in pkgdb currently.
Clearing flag.
Package Change Request ====================== Package Name: rubygem-rspec-mocks New Branches: el6 Owners: bkearney vondruch InitialCC: