Spec URL: http://cheeselee.fedorapeople.org/SPECS/perl-PDF-Haru.spec SRPM URL: http://cheeselee.fedorapeople.org/SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm Description: Perl interface to Haru Free PDF Library.It supports the following features: 1. Generating PDF files with lines, text, images. 2. Outline, text annotation, link annotation. 3. Compressing document with deflate-decode. 4. Embedding PNG, Jpeg images. 5. Embedding Type1 font and TrueType font. 6. Creating encrypted PDF files. 7. Using various character sets (ISO8859-1~16, MSCP1250~8, KOI8-R). 8. Supporting CJK fonts and encodings. $ rpmlint ./RPMS/i686/perl-PDF-Haru-{,*}1.00-1.fc14.i686.rpm ./SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm SPECS/perl-PDF-Haru.spec perl-PDF-Haru.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl perl-PDF-Haru.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl perl-PDF-Haru.i686: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes 4 packages and 1 specfiles checked; 0 errors, 11 warnings.
Homepage Ok. Source URL Ok. Source tar ball is original. Ok. Summary verified from lib/PDF/Haru.pm. Ok. Licensed verified from lib/PDF/Haru.pm and README. Ok. FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in standalone package in the future (lib/PDF/Haru.pm:8, http://search.cpan.org/~ferreira/Exporter/). FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in standalone package in the future (lib/PDF/Haru.pm:9, http://search.cpan.org/~smueller/AutoLoader/). FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in standalone package in the future (lib/PDF/Haru.pm:172, http://search.cpan.org/~saper/XSLoader/). FIX: BuildRequire perl(constant) explicitly as it can dual-live in standalone package in the future (lib/PDF/Haru.pm:177, http://search.cpan.org/~saper/constant/). Unversioned libharu-devel BuildRequires (README: >= 2.1.0) as all Fedoras deliver it. Ok. Description verified from README. Ok. All tests pass. Ok. $ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.x86_64: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl perl-PDF-Haru.x86_64: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl perl-PDF-Haru.x86_64: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl perl-PDF-Haru.x86_64: W: spurious-executable-perm /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl 2 packages and 1 specfiles checked; 0 errors, 6 warnings. FIX: Remove executable bit from examples/* files (put chmod into %prep section). $ rpm -pq -lv ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm drwxr-xr-x 2 root root 0 lis 19 12:58 /usr/lib64/perl5/PDF -rw-r--r-- 1 root root 50487 zář 14 2008 /usr/lib64/perl5/PDF/Haru.pm drwxr-xr-x 2 root root 0 lis 19 12:58 /usr/lib64/perl5/auto/PDF drwxr-xr-x 2 root root 0 lis 19 12:58 /usr/lib64/perl5/auto/PDF/Haru -rwxr-xr-x 1 root root 247448 lis 19 12:58 /usr/lib64/perl5/auto/PDF/Haru/Haru.so -rw-r--r-- 1 root root 87 lis 19 12:58 /usr/lib64/perl5/auto/PDF/Haru/autosplit.ix drwxr-xr-x 2 root root 0 lis 19 12:58 /usr/share/doc/perl-PDF-Haru-1.00 -rw-r--r-- 1 root root 99 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/Changes -rw-r--r-- 1 root root 1115 zář 13 2008 /usr/share/doc/perl-PDF-Haru-1.00/README drwxr-xr-x 2 root root 0 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples drwxr-xr-x 2 root root 0 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/images -rw-r--r-- 1 root root 27778 kvě 27 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/images/gray.jpg -rw-r--r-- 1 root root 32651 kvě 27 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/images/rgb.jpg -rw-r--r-- 1 root root 62042 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pdf -rwxr-xr-x 1 root root 1310 zář 13 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl -rw-r--r-- 1 root root 3282 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pdf -rwxr-xr-x 1 root root 6665 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl -rw-r--r-- 1 root root 5540 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pdf -rwxr-xr-x 1 root root 6409 zář 13 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl -rw-r--r-- 1 root root 5328 zář 14 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pdf -rwxr-xr-x 1 root root 4023 zář 13 2008 /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl -rw-r--r-- 1 root root 14531 lis 19 12:58 /usr/share/man/man3/PDF::Haru.3pm.gz File permissions and layout Ok. $ rpm -pq --requires ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm |sort |uniq -c 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6()(64bit) 1 libhpdf-2.1.0.so()(64bit) 1 perl(AutoLoader) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 perl >= 0:5.008008 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 1 rtld(GNU_HASH) $ rpm -pq --provides ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm |sort |uniq -c 1 perl-PDF-Haru(x86-64) = 1.00-1.fc14 1 perl(PDF::Haru) = 1.00 1 perl-PDF-Haru = 1.00-1.fc14 Binary dependencies Ok. Otherwise, package is in line with Fedora and Perl packaging guidelines. Ok. Package builds in Fedora 15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2611027). Ok. Please correct all `FIX' prefixed issues and provide new spec file. Resolution: Package NOT approved.
(In reply to comment #1) > FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in standalone > package in the future (lib/PDF/Haru.pm:8, > http://search.cpan.org/~ferreira/Exporter/). > > FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in standalone > package in the future (lib/PDF/Haru.pm:9, > http://search.cpan.org/~smueller/AutoLoader/). > > FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in standalone > package in the future (lib/PDF/Haru.pm:172, > http://search.cpan.org/~saper/XSLoader/). > > FIX: BuildRequire perl(constant) explicitly as it can dual-live in standalone > package in the future (lib/PDF/Haru.pm:177, > http://search.cpan.org/~saper/constant/). All will be fixed. > $ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm > ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm > perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings -> > encoding, encoding s, encodes > perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings -> > encoding, encoding s, encodes > perl-PDF-Haru.x86_64: W: spurious-executable-perm > /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl > perl-PDF-Haru.x86_64: W: spurious-executable-perm > /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl > perl-PDF-Haru.x86_64: W: spurious-executable-perm > /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl > perl-PDF-Haru.x86_64: W: spurious-executable-perm > /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl > 2 packages and 1 specfiles checked; 0 errors, 6 warnings. > > FIX: Remove executable bit from examples/* files (put chmod into %prep > section). Is this necessary? Any guideline? The example scripts are intended to be executable.
Files under %doc should not be executable. User can call interpreter explicitly. If the files were in /usr/libexec it would be Ok. That's idea from rpmlint. However I understand documentation can contain executables and they should be easily usable by a user searching for a help. Formerly, I marked the issue as a TODO. Eventually, you can leave the files executable if you prefer usability to specification conformity. It's up to you. It's good question for Fedora Packaging Committee as I cannot find standard back-grounding rpmlint in this area.
OK. Specification conformity is more important. Changes: - BR: perl(Exporter), perl(AutoLoader), perl(XSLoader) and perl(constant) added - Removed executable bits from examples/*.pl scripts Spec URL: http://cheeselee.fedorapeople.org/SPECS/perl-PDF-Haru.spec SRPM URL: http://cheeselee.fedorapeople.org/SRPMS/perl-PDF-Haru-1.00-2.fc14.src.rpm
I asked Fedora Packaging Committee to explain it: <https://fedorahosted.org/fpc/ticket/36>. As spec file is old, I used the one from SRPM. Spec file changes: --- perl-PDF-Haru.spec.old 2010-11-07 13:12:01.000000000 +0100 +++ perl-PDF-Haru.spec 2010-11-22 12:41:46.058735112 +0100 @@ -1,6 +1,6 @@ Name: perl-PDF-Haru Version: 1.00 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Perl interface to Haru Free PDF Library Group: Development/Libraries @@ -9,6 +9,10 @@ Source0: http://search.cpan.org/CPAN/authors/id/B/BU/BUTILW/PDF-Haru-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) +BuildRequires: perl(Exporter) +BuildRequires: perl(AutoLoader) +Buildrequires: perl(XSLoader) +Buildrequires: perl(constant) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Test::More) BuildRequires: libharu-devel @@ -30,6 +34,7 @@ %prep %setup -q -n PDF-Haru-%{version} +chmod -x examples/*.pl %build @@ -62,5 +67,9 @@ %changelog +* Fri Nov 19 2010 Robin Lee <cheeselee> - 1.00-2 +- BR: perl(Exporter), perl(AutoLoader), perl(XSLoader) and perl(constant) added +- Removed executable bits from examples/*.pl scripts + * Sun Nov 7 2010 Robin Lee <cheeselee> - 1.00-1 - Initial packaging > > FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:8, > > http://search.cpan.org/~ferreira/Exporter/). > > > > FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:9, > > http://search.cpan.org/~smueller/AutoLoader/). > > > > FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:172, > > http://search.cpan.org/~saper/XSLoader/). > > > > FIX: BuildRequire perl(constant) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:177, > http://search.cpan.org/~saper/constant/). > +BuildRequires: perl(Exporter) > +BuildRequires: perl(AutoLoader) > +Buildrequires: perl(XSLoader) > +Buildrequires: perl(constant) Ok. > > FIX: Remove executable bit from examples/* files (put chmod into %prep > > section). > +chmod -x examples/*.pl Ok. $ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-2.fc14.src.rpm ../RPMS/x86_64/perl-PDF-Haru-1.00-2.fc14.x86_64.rpm perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint Ok. Package builds in F-15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2615655). Ok. Package is in line with Fedora and perl packaging guidelines. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-PDF-Haru Short Description: Perl interface to Haru Free PDF Library Owners: cheeselee Branches: f13 f14 InitialCC: perl-sig
Git done (by process-git-requests).