Bug 651097 - Review Request: levien-museum-fonts - a font based on historical metal Centaur fonts
Summary: Review Request: levien-museum-fonts - a font based on historical metal Centau...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-08 20:11 UTC by Susmit
Modified: 2010-11-18 08:01 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-11-18 08:01:06 UTC
Type: ---
Embargoed:
dueno: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Susmit 2010-11-08 20:11:14 UTC
Spec URL: 
http://susmit.fedorapeople.org/packaging/museum/museum-fonts.spec

SRPM URL: 
http://susmit.fedorapeople.org/packaging/museum/museum-fonts-0.1-4.fc14.src.rpm

Description: 

http://fedoraproject.org/wiki/Levien_Museum_fonts

* Checked with rpmlint.
* No documentation
* No separate licence file with source
* No version info from upstream
* Bad source archive format.

Upstream contacted regarding these.

Comment 1 Daiki Ueno 2010-11-10 09:14:30 UTC
Looks mostly OK.  Here are some comments:

1. foundry name
Probably better to prepend a foundry name:
http://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming
Since there is already "levien-inconsolata-fonts", I would suggest "levien-museum-fonts".

Perhaps you could try repo-font-audit.
http://fedoraproject.org/wiki/Font_package_lifecycle#2.a

2. fontconfig priority
Choose the right fontconfig priority:
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#ruleset-prefix

3. BuildRoot is not necessary since F-13
You can get rid of %clean and "rm -rf %{buildroot}" in %install.

Comment 2 Susmit 2010-11-12 03:04:17 UTC
I am not sure about the correct fontconfig priority and the link in the packaging page[1][2]   is broken. 

[1] http://fedoraproject.org/wiki/Fontconfig_packaging_tips#ruleset-prefix
[2] https://admin.fedoraproject.org/pkgdb/packages/name/fontconfig

Comment 3 Daiki Ueno 2010-11-12 03:20:42 UTC
I think we could use 61-64 (Low priority LGC fonts) here, while levien-inconsolata-fonts uses 75.

Anyway the correct link would be:
https://admin.fedoraproject.org/pkgdb/acls/name/fontconfig

Comment 4 Susmit 2010-11-12 03:48:31 UTC
Thanks.

I am not sure what should be the font family. I have set the font family as monospace. The rest is taken care of. 

rpmlint is complaining though.

[makerpm@susmit rpmbuild]$ rpmlint SRPMS/levien-museum-fonts-0.1-4.fc14.src.rpm 
levien-museum-fonts.src: W: no-cleaning-of-buildroot %clean
levien-museum-fonts.src: W: no-%clean-section


The new url is:

http://susmit.fedorapeople.org/packaging/museum/levien-museum-fonts.spec

http://susmit.fedorapeople.org/packaging/museum/levien-museum-fonts-0.1-4.fc14.src.rpm

Comment 5 Daiki Ueno 2010-11-12 08:18:30 UTC
(In reply to comment #4)
 
> I have set the font family as monospace.

I think it's serif rather than monospace:
http://www.w3.org/TR/css3-fonts/#serif

> levien-museum-fonts.src: W: no-cleaning-of-buildroot %clean
> levien-museum-fonts.src: W: no-%clean-section

These warnings are harmless I think:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

APPROVED.

Comment 6 Susmit 2010-11-12 15:30:43 UTC
Thanks.

I did not set the FE-NEEDSPONSOR flag when submitting. But to commit the package, I need someone to sponsor me.

Comment 7 Susmit 2010-11-12 16:21:16 UTC
The version should really be 1.0-1, not 0.1-4...fixed.

Comment 8 Parag AN(पराग) 2010-11-15 04:28:52 UTC
I have sponsored susmit now. He should now continue from step7 given in http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess

Comment 9 Susmit 2010-11-15 06:26:20 UTC
Thanks a lot Parag.

New Package SCM Request
=======================
Package Name: levien-museum-fonts
Short Description: A font based on historical metal Centaur fonts.
Owners: susmit
Branches: f13, f14
InitialCC: none

Comment 10 Jason Tibbitts 2010-11-15 14:32:49 UTC
Oh, and "initialCC none" is not valid.  Please read and follow http://fedoraproject.org/wiki/Package_SCM_admin_requests exactly when submitting requests, since they are processed by scripts.  This includes not making up things like a nonexistent "none" account, thanks.

Comment 11 Susmit 2010-11-15 14:56:46 UTC
Thanks for the pointers. However, it is not clear from the guideline if InitialCC field is not needed, whether to remove the field altogether, to leave it blank or do something else. Please let me know. I shall update the wiki.

Thanks

Comment 12 Susmit 2010-11-15 14:59:35 UTC
New Package SCM Request
=======================
Package Name: levien-museum-fonts
Short Description: A font based on historical metal Centaur fonts.
Owners: susmit
Branches: f13, f14
InitialCC: fonts-bugs-lists.fedoraproject.org

Comment 13 Jason Tibbitts 2010-11-15 15:21:51 UTC
I already processed the original request with a blank initialCC field.  The request you just made (although the scripts will not see it, because you did not raise the fedora-cvs flag) is also not valid, becuase "fonts-bugs-lists.fedoraproject.org" is not a valid Fedora account.

I also updated the wiki to attempt to add additional clarification, though I'm hard-pressed to understand how adding "none" was a reasonable inference from the language which was there previously.

Comment 14 Susmit 2010-11-15 15:38:38 UTC
I did not raise the flag because I found that you have already processed it. 

I was just clarifying the SCM request format, because I had a suspicion that some informations in the wiki page are wrong. 

For example, the one you just mentioned. fonts-bugs-lists.fedoraproject.org is indeed listed under: 
http://fedoraproject.org/wiki/Package_SCM_admin_requests#Pseudo-users_for_SIGs. 

I do understand that it was probably meant to obfuscate the mail-id, but there are other addresses which uses @, for example, fedora-hams.

Lastly, I have no idea why I used "none". :)

Comment 15 Jason Tibbitts 2010-11-15 15:46:58 UTC
The table in the wiki to which you refer shows the username on the left under the "username" heading, and (perhaps obsfucated) email addresses under the "email" heading.  The fields are documented directly above to take usernames.  I can add additional language in bold italics saying that the fields don't take email addresses, but at this point I'm not sure that it would help.  Perhaps if I underline it as well....

Comment 16 Daiki Ueno 2010-11-18 08:01:06 UTC
Closing.


Note You need to log in before you can comment on or make changes to this bug.