Bug 651350 - B43 open firmware placed in worng directory
Summary: B43 open firmware placed in worng directory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: b43-openfwwf
Version: 14
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-09 11:08 UTC by ufa
Modified: 2010-11-19 22:37 UTC (History)
3 users (show)

Fixed In Version: b43-openfwwf-5.2-5.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-19 22:29:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description ufa 2010-11-09 11:08:31 UTC
Description of problem:
The b43-openfwwf is placed in /lib/firmware/b43, but it should be in /lib/firmware/b43-open , as upstream is. 
Driver message:
b43-phy0 ERROR: Firmware file "b43-open/ucode5.fw" not found


Version-Release number of selected component (if applicable):
b43-openfwwf-5.2-4.fc14.noarch

How reproducible:
Always

Steps to Reproduce:
1.Install the Linux-libre or vanilla kernel
2.check logs

  
Actual results:
Broadcom Wifi doesn't work

Expected results:
Broadcom wifi working like it does with Fedora stock Kernel

Additional info:
If I change the directory name (b43 -> b43-open), it works

Comment 1 Peter Lemenkov 2010-11-09 11:17:28 UTC
I wasn't aware of such change in kernel.

Comment 2 Peter Lemenkov 2010-11-09 11:22:47 UTC
Before moving firnware into b43-open we must check that this won't break existing setups. For example, b43 kernel module searches for firmware in /lib/firmware/b43 on my Fedora 12.

John, could you, please, clarify this - which Fedora kernels are searching for openfwwf in /lib/firmware/b43-open and which - in /lib/firmware/b43 ?

Comment 3 John W. Linville 2010-11-09 15:06:47 UTC
The patch that added searching in b43-open went in a long time ago -- probably all active Fedora kernels can find it there.  The purpose is to allow for both the open firmware and the proprietary firmware to be installed on the same system.

That said, I don't see any reason why having the openfwwf stuff in /lib/firmware/b43 should be a problem either.  I don't have my b43 card handy, but ISTRC having it "just work" within the past few weeks on a 2.6.36 kernel and my F13 userland.

Reading the opening comment indicates that the user is using a linux-libre kernel.  I suspect the linux-libre folks have patched b43 to refuse to load from the "proprietary" directory (and therefore have caused their own problem).

That said, moving the b43-openfwwf package to install in /lib/firmware/b43-open seems like a fine idea to me.  I don't think it will cause a problem for anyone.  Even the F12 kernels should find it there (after looking in /lib/firmware/b43 first).

Comment 4 ufa 2010-11-09 16:15:43 UTC
Thank you everyone fot the attention.

I just want to say that the vanilla kernel uses b43-open directory, so Fedora is diverging from upstream. Is it a good idea? 

/me thinks that changing upstream directory contribute to increase incompatibility among different kernels.

Comment 5 John W. Linville 2010-11-09 16:31:43 UTC
Please check the code -- the upstream kernel looks in both directories for firmware, looking in /lib/firmware/b43 first.

Comment 6 ufa 2010-11-09 16:39:29 UTC
Yes, it does. But shouldn't different firmwares be in different directories?
That is why the code searchs for the b43-open.

Comment 7 John W. Linville 2010-11-09 16:41:39 UTC
home/linville
[linville-8530p.local]:> dmesg
[10352.923846] pci 0000:04:00.0: [14e4:4311] type 0 class 0x000280
[10352.923896] pci 0000:04:00.0: reg 10: [mem 0x00000000-0x00003fff]
[10352.924182] pci 0000:04:00.0: supports D1 D2
[10352.924235] pci 0000:04:00.0: disabling ASPM on pre-1.1 PCIe device.  You can enable it with 'pcie_aspm=force'
[10352.948216] pci 0000:04:00.0: BAR 0: assigned [mem 0xd80fc000-0xd80fffff]
[10352.948238] pci 0000:04:00.0: BAR 0: set to [mem 0xd80fc000-0xd80fffff] (PCI address [0xd80fc000-0xd80fffff])
[10353.022654] b43-pci-bridge 0000:04:00.0: enabling device (0000 -> 0002)
[10353.022665] b43-pci-bridge 0000:04:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
[10353.022678] b43-pci-bridge 0000:04:00.0: setting latency timer to 64
[10353.030127] ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x11, vendor 0x4243)
[10353.030137] ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0A, vendor 0x4243)
[10353.030146] ssb: Core 2 found: USB 1.1 Host (cc 0x817, rev 0x03, vendor 0x4243)
[10353.030156] ssb: Core 3 found: PCI-E (cc 0x820, rev 0x01, vendor 0x4243)
[10353.046715] ssb: WARNING: Invalid SPROM CRC (corrupt SPROM)
[10353.046717] ssb: Unsupported SPROM  revision 255 detected. Will extract v1
[10353.054236] ssb: Sonics Silicon Backplane found on PCI device 0000:04:00.0
[10353.237079] b43-phy1: Broadcom 4311 WLAN found (core revision 10)
[10353.252305] b43-phy1 debug: Found PHY: Analog 4, Type 2, Revision 8
[10353.252334] b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2
[10353.262689] ieee80211 phy1: Selected rate control algorithm 'minstrel_ht'
[10353.265810] Registered led device: b43-phy1::tx
[10353.265916] Registered led device: b43-phy1::rx
[10353.266097] Registered led device: b43-phy1::radio
[10353.266140] Broadcom 43xx driver loaded [ Features: PMLS, Firmware-ID: FW13 ]
[10353.349677] udev: renamed network interface wlan1 to wlan2
[10353.487349] b43-phy1: Loading OpenSource firmware version 410.31754
[10353.487364] b43-phy1: Hardware crypto acceleration not supported by firmware
[10353.487371] b43-phy1: QoS not supported by firmware
[10353.522388] b43-phy1 debug: Chip initialized
[10353.525153] b43-phy1 debug: 32-bit DMA initialized
[10353.525165] b43-phy1 debug: QoS disabled
[10353.534627] b43-phy1 debug: Wireless interface started
[10353.537462] b43-phy1 debug: Adding Interface type 2
[10353.544998] ADDRCONF(NETDEV_UP): wlan2: link is not ready
[10354.891385] wlan2: direct probe to 00:18:39:5b:82:ca (try 1)
[10354.893630] wlan2: direct probe responded
[10354.893796] wlan2: authenticate with 00:18:39:5b:82:ca (try 1)
[10354.897717] wlan2: authenticated
[10354.897894] wlan2: associate with 00:18:39:5b:82:ca (try 1)
[10354.899976] wlan2: RX AssocResp from 00:18:39:5b:82:ca (capab=0x411 status=0 aid=6)
[10354.899984] wlan2: associated
[10354.907223] ADDRCONF(NETDEV_CHANGE): wlan2: link becomes ready
[10365.434288] wlan2: no IPv6 routers present

/home/linville
[linville-8530p.local]:> ls /lib/firmware/b43/
b0g0bsinitvals5.fw  b0g0initvals5.fw  ucode5.fw

/home/linville
[linville-8530p.local]:> ls /lib/firmware/b43-open
ls: cannot access /lib/firmware/b43-open: No such file or directory

/home/linville
[linville-8530p.local]:> uname -a
Linux linville-8530p.local 2.6.37-rc1-wl #3 SMP Mon Nov 8 19:40:52 EST 2010 x86_64 x86_64 x86_64 GNU/Linux

But again, I think moving b43-openfwwf to /lib/firmware/b43-open is a fine idea -- just not a necessary one.

Comment 8 Peter Lemenkov 2010-11-09 17:16:30 UTC
Ok, I'll provide new build shortly.

Comment 9 ufa 2010-11-09 17:39:45 UTC
Thank you everyone :)

Comment 10 Fedora Update System 2010-11-11 11:36:04 UTC
b43-openfwwf-5.2-5.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/b43-openfwwf-5.2-5.fc13

Comment 11 Fedora Update System 2010-11-11 11:36:11 UTC
b43-openfwwf-5.2-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/b43-openfwwf-5.2-5.fc14

Comment 12 Fedora Update System 2010-11-11 11:36:17 UTC
b43-openfwwf-5.2-5.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/b43-openfwwf-5.2-5.fc12

Comment 13 Fedora Update System 2010-11-11 22:16:06 UTC
b43-openfwwf-5.2-5.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update b43-openfwwf'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/b43-openfwwf-5.2-5.fc12

Comment 14 Fedora Update System 2010-11-19 22:29:09 UTC
b43-openfwwf-5.2-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-11-19 22:30:00 UTC
b43-openfwwf-5.2-5.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2010-11-19 22:37:34 UTC
b43-openfwwf-5.2-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.