Bug 651668 - cannot remove path when cwd is /tmp/.cvsweb.XXXXXX
Summary: cannot remove path when cwd is /tmp/.cvsweb.XXXXXX
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: cvsweb
Version: 14
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-10 03:37 UTC by Ralf Corsepius
Modified: 2012-08-16 22:07 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-08-16 22:07:56 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed patch (507 bytes, patch)
2010-11-10 03:41 UTC, Ralf Corsepius
no flags Details | Diff

Description Ralf Corsepius 2010-11-10 03:37:33 UTC
Description of problem:

cvsweb.cgi fails to remove the temporary /tmp/.cvsweb.XXXXXX directories it creates during "Download this directory in tarball or zip archive".

/var/log/httpd/error_log:
[Wed Nov 10 03:01:57 2010] [error] [client 192.168.1.104] 
cannot remove path when cwd is /tmp/.cvsweb.IxntOedV for /tmp/.cvsweb.IxntOedV:  at /usr/share/cvsweb/cvsweb.cgi line 778, referer: http://<non-disclosed>/cvsweb/cvsweb.cgi/work/

Version-Release number of selected component (if applicable):
cvsweb-3.0.6-9.fc12.noarch

How reproducible:
Always.

Steps to Reproduce:
1. Set up a cvs server + apache + cvsweb
2. Browse a cvs repo and click on "Download this directory in tarball or zip archive"

Actual results:
- Downloading tarballs/zip-balls fails
- cvsweb is failing to cleanup its temporary directories from /tmp, /tmp/ is gradually filling up with .cvsweb.XXXXX directories
- /var/log/httpd/error_log fills up with error messages.

Expected results:
- Downloads to work.
- /tmp/ not filling up.

Additional info:
- This is a security issue, because it allows arbitrary remote users to 
fill up /tmp.

Comment 1 Ralf Corsepius 2010-11-10 03:41:23 UTC
Created attachment 459308 [details]
Proposed patch

This patch attempts to fix this issue by cd'ing to ".." before removing $tmpexportdir.

Comment 2 Bug Zapper 2010-12-03 12:02:12 UTC
Fedora 12 changed to end-of-life (EOL) status on 2010-12-02. Fedora 12 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 3 Ralf Corsepius 2010-12-03 12:55:52 UTC
Reopening - Bug still is present.

Comment 4 Bug Zapper 2011-05-30 13:57:03 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 5 Ralf Corsepius 2011-05-30 16:22:09 UTC
(In reply to comment #4)

> Bug Reporter: Thank you for reporting this issue and we are sorry that 
> we may not be able to fix it before Fedora 13 is end of life.
Please stop pretending somebody was looking into this bug - It's obviously untrue.

Bug is still present in all released versions of Fedora,

Comment 6 Fedora End Of Life 2012-08-16 22:07:58 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.