Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.7-1.fc14.src.rpm Description: BoxGrinder Build (http://www.jboss.org/boxgrinder) to Fedora. BoxGrinder is a command line tool for building appliances (virtual machines) to various platforms (KVM, Xen, VMware, EC2). This package contains files required to build appliances based on RPMs.
Below updated spec files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-1.fc15.src.rpm We need to wait for rubygem-boxgrinder-build (BZ#652400) to be pushed to rawhide to build it.
Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src.rpm Scratch build on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2621826
Some notes: ! Source --------------------------------------------------------------- a440ee244f272cfa1a2ef680b8beb199 Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem e6d7d2503e9655bb36f73a1ff881cea4 rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem --------------------------------------------------------------- - The source in your srpm does not match the one I could download from the URL written as Source0. Would you explain why? ! No longer needed stuff - %clean section is no longer needed on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * rpmlint issue --------------------------------------------------------------- rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init 0664L /bin/sh --------------------------------------------------------------- - This warning comes because this script does not have executable permission while the script has shebang. While I think this script need not have executable permission because this file seems something like a template, however I think 0644 permission is more proper.
By the way I would appreciate it if you have some time to review my review request (bug 657591)
(In reply to comment #3) > Some notes: > > ! Source > --------------------------------------------------------------- > a440ee244f272cfa1a2ef680b8beb199 > Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem > e6d7d2503e9655bb36f73a1ff881cea4 > rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem > --------------------------------------------------------------- > - The source in your srpm does not match the one I could download > from the URL written as Source0. Would you explain why? The src.rpm uses a regenerated gem, but from the same source as pushed to rubygems.org. When checking into git I'm overriding the .gem with the proper version (from rubygems.org). Currently - all my src.rpm have this issue. I'll change the way I build my src.rpm for review for the next submissions. Sorry for confusion! > ! No longer needed stuff > - %clean section is no longer needed on Fedora: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean Going to remove it, thanks! > * rpmlint issue > --------------------------------------------------------------- > rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script > /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init > 0664L /bin/sh > --------------------------------------------------------------- > - This warning comes because this script does not have executable permission > while the script has shebang. While I think this script need not have > executable > permission because this file seems something like a template, however I > think > 0644 permission is more proper. Yes this is just a template. I'll post updated spec and review your package shortly.
Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc15.src.rpm Koji scratch build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2628716 Changelog: * Fri Nov 26 2010 <mgoldman> - 0.0.8-3 - Removed clean section, updated URL, fixed attr for motd.init file
No blockers, approving. ------------------------------------------------------------------ This package (rubygem-boxgrider-build-rpm-based-os-plugin) is APPROVED by mtasaka ------------------------------------------------------------------
Thanks! New Package SCM Request ======================= Package Name: rubygem-boxgrider-build-rpm-based-os-plugin Short Description: Files required to build appliances based on RPMs Owners: goldmann Branches: f13 f14
The requested package name does not match the name in the ticket summary. Please either correct the ticket summary or submit a new SVM request and re-raise the fedora-cvs flag.
Right, I ate one letter, sorry for that! New Package SCM Request ======================= Package Name: rubygem-boxgrinder-build-rpm-based-os-plugin Short Description: Files required to build appliances based on RPMs Owners: goldmann Branches: f13 f14
Git done (by process-git-requests).
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc14
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-build-rpm-based-os-plugin'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13
Closing.
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: rubygem-boxgrinder-build-rpm-based-os-plugin New Branches: el5 el6 Owners: goldmann