Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin-0.0.4-2.fc14.src.rpm Description: BoxGrinder Build (http://www.jboss.org/boxgrinder) to Fedora. BoxGrinder is a command line tool for building appliances (virtual machines) to various platforms (KVM, Xen, VMware, EC2). This package contains files required to deliver appliances to path specified on local filesystem.
Updated spec files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin-0.0.4-3.fc15.src.rpm Changelog: * Tue Nov 23 2010 <mgoldman> - 0.0.4-3 - Cleaned Requires/Build Requires - Added BR: rubygem(rake), BR: rubygem(echoe), BR: rubygem(rspec)
2 issues ! Sources - The gem file in your srpm does not match what I could download from the URL written in your spec. Looks like after 0.0.4 gem was uploaded to rubygems.org, you modified gem file locally. * Usability - It seems that "boxgrinder-build-local-delivery-plugin" cannot be loaded directly: ---------------------------------------------------- $ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "boxgrinder-build-local-delivery-plugin" NoMethodError: undefined method `plugin' for main:Object from /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-local-delivery-plugin-0.0.4/lib/boxgrinder-build-local-delivery-plugin.rb:21 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 irb(main):003:0> ---------------------------------------------------- As this script seems the "main" script for this gem, I think this should be fixed. Perhaps this script should have requirement for "boxgrinder-build/managers/plugin-manager" ---------------------------------------------------- $ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "boxgrinder-build/managers/plugin-manager" => true irb(main):003:0> require "boxgrinder-build-local-delivery-plugin" => true irb(main):004:0> ----------------------------------------------------
By the way I would appreciate it if you would have some time for reviewing my review package (bug 639638)
(In reply to comment #2) > 2 issues > > ! Sources > - The gem file in your srpm does not match what I could download > from the URL written in your spec. Looks like after 0.0.4 gem was > uploaded to rubygems.org, you modified gem file locally. Fixed :) > * Usability > - It seems that "boxgrinder-build-local-delivery-plugin" cannot > be loaded directly: > ---------------------------------------------------- > $ irb > irb(main):001:0> require "rubygems" > => true > irb(main):002:0> require "boxgrinder-build-local-delivery-plugin" > NoMethodError: undefined method `plugin' for main:Object > from > /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-local-delivery-plugin-0.0.4/lib/boxgrinder-build-local-delivery-plugin.rb:21 > from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in > `gem_original_require' > from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' > from (irb):2 > irb(main):003:0> > ---------------------------------------------------- > As this script seems the "main" script for this gem, I think > this should be fixed. Perhaps this script should have requirement for > "boxgrinder-build/managers/plugin-manager" > > ---------------------------------------------------- > $ irb > irb(main):001:0> require "rubygems" > => true > irb(main):002:0> require "boxgrinder-build/managers/plugin-manager" > => true > irb(main):003:0> require "boxgrinder-build-local-delivery-plugin" > => true > irb(main):004:0> > ---------------------------------------------------- True, this should work with requiring directly the main require, although it's not usable without the full BG stack. Same goes to all other plugins, will add there require too: [goldmann@work git]$ irb irb(main):001:0> require 'rubygems' => true irb(main):002:0> require 'boxgrinder-build-local-delivery-plugin' => true irb(main):003:0> Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc15.src.rpm Changelog: * Mon Nov 29 2010 <mgoldman> - 0.0.5-1 - Upstream release: 0.0.5 - [BGBUILD-105] No plugin-manager require for local delivery plugin Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2631639 Thanks!
Looks okay. --------------------------------------------------------- This package (rubygem-build-local-delivery-plugin) is APPROVED by mtasaka ---------------------------------------------------------
Thank you! Will review your package shortly. New Package SCM Request ======================= Package Name: rubygem-boxgrinder-build-local-delivery-plugin Short Description: BoxGrinder plugin to deliver appliance to local filesystem Owners: goldmann Branches: f13 f14
Git done (by process-git-requests).
rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc14
rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc13
rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-build-local-delivery-plugin'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc14
Closing.
rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: rubygem-boxgrinder-build-local-delivery-plugin New Branches: el5 el6 Owners: goldmann