Bug 652835 - Review Request: ktikz - Editor for the TikZ language
Summary: Review Request: ktikz - Editor for the TikZ language
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dmitrij S. Kryzhevich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-12 22:04 UTC by Mohamed El Morabity
Modified: 2010-11-24 22:44 UTC (History)
3 users (show)

Fixed In Version: ktikz-0.10-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-24 22:36:23 UTC
Type: ---
Embargoed:
kryzhev: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Mohamed El Morabity 2010-11-12 22:04:33 UTC
Spec URL: http://melmorabity.fedorapeople.org/packages/ktikz/ktikz.spec
SRPM URL: http://melmorabity.fedorapeople.org/packages/ktikz/ktikz-0.10-1.fc14.src.rpm
Description:
KTikZ and Qtikz are small applications to assist in the creation of diagrams and drawings
using the TikZ macros from the LaTeX package "pgf". They consist of a text editor
pane in which the TikZ code for the drawing is edited and a preview pane showing
the drawing as rendered by LaTeX. The preview pane can be updated in
real-time. Common drawing tools, options and styles are available from the menus
to assist the coding process.

Note that this package provides two versions of the same program:
- qtikz, a QT desktop-independant version,
- ktikz, a KDE-integrated version, with a KPart.

Build logs: http://koji.fedoraproject.org/koji/taskinfo?taskID=2598104
rpmlint runs silently on all RPMs (except false-positive spelling issues).

Comment 1 Dmitrij S. Kryzhevich 2010-11-15 04:27:28 UTC
Any example file to test?

Comment 2 Mohamed El Morabity 2010-11-15 05:36:36 UTC
(In reply to comment #1)
> Any example file to test?
Sure. Any example avaible in the 320-page PGF manual, in /usr/share/texmf/doc/generic/pgf/version-for-pdftex/en/pgfmanual.pdf

Comment 3 Dmitrij S. Kryzhevich 2010-11-15 06:26:42 UTC
Ah, 175M to download. This will take a while.

Comment 4 Dmitrij S. Kryzhevich 2010-11-15 06:59:39 UTC
OK, here is.

"+" - OK, "0" - not require.

[+]: rpmlint is almost silent but wrong possitive spelling warning.
[+]: The package must be named according to the  Package Naming Guidelines .
[+]: The spec file name must match the base package %{name}. 
[+]: The package must meet the  Packaging Guidelines .
[+]: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines .
[+]: The License field in the package spec file must match the actual license.
[+]: File, containing the text of the license(s) for the package, included in %doc.
[+]: The spec file must be written in American English.
[+]: The spec file for the package MUST be legible.
[+]: The sources used to build the package must match the upstream source, as provided in the spec URL.
[+]: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[0]: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]: All build dependencies must be listed in BuildRequires.
[+]: The spec file MUST handle locales properly.
[0]: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+]: Packages must NOT bundle copies of system libraries.
[0]: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]: A package must own all directories that it creates.
[+]: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+]: Permissions on files must be set properly.
[+]: Each package must consistently use macros.
[+]: The package must contain code, or permissable content.
[0]: Large documentation files must go in a -doc subpackage.
[+]: If a package includes something as %doc, it must not affect the runtime of the application.
[0]: Header files must be in a -devel package.
[0]: Static libraries must be in a -static package.
[0]: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[0]: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}.
[+]: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[+]: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.
[+]: Packages must not own files or directories already owned by other packages.
[+]: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] The reviewer should test that the package builds in mock.
[+] The package should compile and build into binary rpms on all supported architectures.
[+] The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[+] If scriptlets are used, those scriptlets must be sane.
[+] your package should contain man pages for binaries/scripts.

/===========/
/ APPROVED. /
/===========/

Comment 5 Mohamed El Morabity 2010-11-15 07:28:43 UTC
Thanks for your efficient review :)

Comment 6 Mohamed El Morabity 2010-11-15 07:29:59 UTC
New Package SCM Request
=======================
Package Name: ktikz
Short Description: Editor for the TikZ language
Owners: melmorabity
Branches: f13 f14
InitialCC:

Comment 7 Jason Tibbitts 2010-11-15 14:44:57 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2010-11-15 19:41:32 UTC
ktikz-0.10-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ktikz-0.10-1.fc14

Comment 9 Fedora Update System 2010-11-15 20:30:47 UTC
ktikz-0.10-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/ktikz-0.10-1.fc13

Comment 10 Fedora Update System 2010-11-16 23:12:09 UTC
ktikz-0.10-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ktikz'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ktikz-0.10-1.fc13

Comment 11 Fedora Update System 2010-11-24 22:36:18 UTC
ktikz-0.10-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-11-24 22:44:42 UTC
ktikz-0.10-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.