Bug 653317 - Confusing watchdog-extend exception
Summary: Confusing watchdog-extend exception
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: command line
Version: 0.7
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: 21.0
Assignee: matt jia
QA Contact: tools-bugs
URL:
Whiteboard: CommandLineEnhancement
Depends On: 1103582
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-15 09:30 UTC by Vojtech Juranek
Modified: 2018-02-06 00:41 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-26 06:17:09 UTC
Embargoed:


Attachments (Terms of Use)

Description Vojtech Juranek 2010-11-15 09:30:25 UTC
Exception thrown by beaker cli task watchdog-extend, when e.g. job ID is entered instead of task ID, is little bit confusing. The exception is 
Exception: bkr.server.bexceptions.BX:'No watchdog exists for recipe 12345'
suggesting, that recipe ID should be entered (correct is to enter task ID).

Comment 1 Nick Coghlan 2012-10-17 04:34:48 UTC
Bulk reassignment of issues as Bill has moved to another team.

Comment 3 wangjing 2013-07-04 07:37:20 UTC
reproduced on beaker-devel Version - 0.13.2

steps:

#bkr watchdog-extend 789(job ID)
XML-RPC fault: <class 'bkr.common.bexceptions.BX'>:'No watchdog exists for recipe 311'

Comment 5 Dan Callaghan 2014-05-26 07:08:20 UTC
For consistency with all the other client commands, bkr watchdog-extend would ideally accept a "taskspec" style argument giving either a recipe (R:123) or a recipe-task (T:123). That makes things a bit less ambiguous, and lets us giving better a clearer error.

We will have to continue accepting unqualified task ID for compatibility as well though.

Comment 6 Dan Callaghan 2014-05-26 07:09:17 UTC
(In reply to Dan Callaghan from comment #5)
> and lets us giving better a clearer error.

Wow... I will make the error message clearer than that, I promise!

Comment 7 Dan Callaghan 2015-08-07 05:30:03 UTC
Is this fixed by bug 1103582?

Comment 8 Dan Callaghan 2015-08-17 00:02:11 UTC
(In reply to Dan Callaghan from comment #7)
> Is this fixed by bug 1103582?

Indeed it is. Output is now:

$ bkr watchdog-extend 999999999999
HTTP error: 404 Client Error: NOT FOUND
999999999999 is not a valid RecipeTask id

Comment 10 Dan Callaghan 2015-08-26 06:17:09 UTC
Beaker 21.0 has been released.


Note You need to log in before you can comment on or make changes to this bug.