Spec URL: https://fedorahosted.org/released/libpagemap/libpagemap.spec SRPM URL: https://fedorahosted.org/released/libpagemap/libpagemap-0.0.1-1.src.rpm Description: This package consists of libpagemap library that utilizes kernel pagemap interface and provides functions for memory statistics, walking through processes and more. The package contains also pgmap utility which demonstrates using of library and provides memory statistics about system memory. In the future I'd like to add my pagevisual utility that runs on PyGTK and visualize memory pages statistics by charts or pixmaps. But this utility is still under developing and not completed. BTW, it's my first package and I am seeking a sponsor.
formal review is here, see the notes explaining OK* and BAD statuses below: BAD source files match upstream: upstream: 0ef5d79e4910a78ac5f469317e0e30da0c88130a libpagemap-0.0.1.tar.gz srpm: eef5d2f4ca658cb48b4f42f4c636c6ec7dca815b libpagemap-0.0.1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. BAD dist tag is present. OK license field matches the actual license. BAD license is open source-compatible (GPLv3+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. BAD file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - the checksum doesn't match between the source included in the srpm and the one downloaded from Source0 URL - you should use dist tag in the Release unless you have strong reason for not doing that (https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag and https://fedoraproject.org/wiki/Packaging:DistTag) - the license text must be included as %doc - the Fedora compiler flags are not used (https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags) - use the same %defattr(-,root,root,-) for both (sub-)packages - the man page should use the default permission 0644 inherited from %defattr, no need to mark it as %doc, it's done automatically by rpm - the man page should be included in source archive in unpacked form, rpm will pack it itself, then use "pmap.1*" in the %files section - be careful when setting the soname for the library as it represents API/ABI version and is used in autogenerated dependencies - README should be included as %doc
Spec URL: https://fedorahosted.org/released/libpagemap/libpagemap.spec SRPM URL: https://fedorahosted.org/released/libpagemap/libpagemap-0.0.1-1.src.rpm Thanks for review, I've fixed things you pointed out. Only man page permissions I set explicitly to 0644, because %defattr installed pgmap.1.gz as 0755 and rpmlint reported 'executable man page' error.
Fixed issues: - source archive matches upstream c8bbf78fc43f74e14582f4451672e1a521c519a6 libpagemap-0.0.1.tar.gz - dist tag is used - license text is included - proper compiler flags are used - upstream man page is not compressed Remaining issues: - the development library "libpagemap.so" is not installed and included in the -devel subpackage - drop the %doc attribute from the man page, it's done automatically by rpm - rpmlint still complains a bit: libpagemap.x86_64: W: spelling-error Summary(en_US) Pagemap -> Page map, Page-map, Pageant libpagemap.x86_64: W: spelling-error %description -l en_US pagemap -> page map, page-map, pageant libpagemap.src: W: spelling-error Summary(en_US) Pagemap -> Page map, Page-map, Pageant libpagemap.src: W: spelling-error %description -l en_US pagemap -> page map, page-map, pageant => false positives libpagemap.x86_64: W: manual-page-warning /usr/share/man/man1/pgmap.1.gz 1: warning: macro `�' not defined => please check libpagemap-devel.x86_64: W: no-documentation => can be ignored libpagemap-devel.x86_64: W: spurious-executable-perm /usr/include/libpagemap.h => best to use "-m 0644" in the install target in the Makefile, see below These issues should be solved in upstream code: - using "-p" and "-m <perms>" options when installing files is preferred Also increase the release and add a changelog entry summarizing the changes for every package iteration, it's hard to track the changes when not doing so.
SRPM URL: https://fedorahosted.org/released/libpagemap/libpagemap-0.0.1-2.src.rpm Spec URL: https://fedorahosted.org/released/libpagemap/libpagemap.spec I'm really sorry for missing changelog, I've fixed it.
All issues are fixed, this package is APPROVED.
New Package SCM Request ======================= Package Name: libpagemap Short Description: Library for utilizing kernel pagemap interface Owners: pholasek Branches: f14 InitialCC:
Git done (by process-git-requests).
package is imported and built, closing
Package Change Request ====================== Package Name: libpagemap New Branches: el6 Owners: pholasek aarapov