RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 653530 - virsh freecell does not offer a way to list free memory per node
Summary: virsh freecell does not offer a way to list free memory per node
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 693963
TreeView+ depends on / blocked
 
Reported: 2010-11-15 16:54 UTC by Jes Sorensen
Modified: 2015-09-28 02:21 UTC (History)
10 users (show)

Fixed In Version: libvirt-0.8.7-8.el6
Doc Type: Bug Fix
Doc Text:
An "--all" option has been added to the "virsh freecell" command to allow the command to iterate across all nodes instead of forcing users to run the command manually on each node. "virsh freecell --all" will list the free memory on all available nodes.
Clone Of:
Environment:
Last Closed: 2011-05-19 13:24:09 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0596 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2011-05-18 17:56:36 UTC

Description Jes Sorensen 2010-11-15 16:54:46 UTC 
Description of problem:
virsh freecell lacks the ability to list free memory for each node. Instead
one has to manually do 'virsh freecell 0', 'virsh freecell 1' etc.

Either changing virsh freecell to iterate over all the notes, or adding a
-all flag would make sense.

IMHO the best solution would be for virsh freecell to iterate over the
nodes per default and then print a summary of total memory as the last
output line.

The lack of this feature is a pain for the RHEL6 virt guide section 24.4

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 2 Dave Allan 2011-01-25 15:31:39 UTC 
The upstream community has the final say, but I favor the approach of adding a flag --all so that we don't change the existing default behavior.
Comment 3 Michal Privoznik 2011-01-31 10:00:04 UTC 
pushed into upstream:

commit 30e21374ea30b5b70fdc0a101e3002a8c78498c9
Author: Michal Privoznik <mprivozn>
Date:   Fri Jan 28 19:21:57 2011 +0100

    virsh: added --all flag to freecell command
    
    This will iterate over all NUMA nodes, showing
    free memory for each and sum at the end.
    Existing default behavior is not changed.


v0.8.7-148-g30e2137
Comment 4 Eric Blake 2011-02-03 19:56:38 UTC 
moving into POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-February/msg00408.html
Comment 7 Cui Chun 2011-02-14 10:33:13 UTC 
Test environment:
libvirt-0.8.7-6.el6


Steps:

1. check the help of "freecell". "--all" option is added.
# virsh help freecell
  NAME
    freecell - NUMA free memory

  SYNOPSIS
    freecell [--cellno <number>] [--all]

  DESCRIPTION
    display available free memory for the NUMA cell.

  OPTIONS
    --cellno <number>  NUMA cell number
    --all            show free memory for all NUMA cells



2. There are 3 cells in testing machine 

# virsh capabilities

............
 <topology>
      <cells num='3'>
        <cell id='0'>
          <cpus num='4'>
            <cpu id='0'/>
            <cpu id='4'/>
            <cpu id='8'/>
            <cpu id='12'/>
          </cpus>
        </cell>
        <cell id='1'>
          <cpus num='4'>
            <cpu id='1'/>
            <cpu id='5'/>
            <cpu id='9'/>
            <cpu id='13'/>
          </cpus>
        </cell>
        <cell id='2'>
          <cpus num='8'>
            <cpu id='2'/>
            <cpu id='3'/>
            <cpu id='6'/>
            <cpu id='7'/>
            <cpu id='10'/>
            <cpu id='11'/>
            <cpu id='14'/>
            <cpu id='15'/>
          </cpus>
        </cell>
      </cells>
    </topology>
...........


3. Check with specified cell number

# virsh freecell --cellno 0
0: 32164532 kB

# virsh freecell --cellno 1
1: 32372352 kB

# virsh freecell --cellno 2
2: 32387296 kB


4. Check "--all" option

# virsh freecell --all
    0:   32164556 kB
--------------------
Total:   32164556 kB



The question in step4: 
Only cellno 0 can be listed. Is it right?
Comment 8 Michal Privoznik 2011-02-15 08:26:25 UTC 
no. it is not. it seems like --all is getting wrong number of numa cells. which driver are you using? qemu?
Comment 9 Cui Chun 2011-02-15 09:18:23 UTC 
Packages info:

qemu:
qemu-img-0.12.1.2-2.144.el6.x86_64
gpxe-roms-qemu-0.9.7-6.3.el6.noarch
qemu-kvm-0.12.1.2-2.144.el6.x86_64

libvirt:
libvirt-0.8.7-6.el6.x86_64
libvirt-client-0.8.7-6.el6.x86_64
libvirt-python-0.8.7-6.el6.x86_64
libvirt-devel-0.8.7-6.el6.x86_64

kernel:
kernel-2.6.32-113.el6.x86_64
Comment 10 Cui Chun 2011-02-17 05:26:13 UTC 
Hi Michal,

Any update for this bug?

I rechecked it on qemu-kvm-0.12.1.2-2.145.el6.x86_64 and libvirt-0.8.7-6.el6.x86_64. The result of "--all" is same with comment 7.


# virsh freecell --all
    0:   32162144 kB
--------------------
Total:   32162144 kB
Comment 13 Cui Chun 2011-02-25 03:09:41 UTC 
Re checked it on the following environment as per steps of comment7, it is passed.

Test environment:
libvirt-0.8.7-8.el6
qemu-kvm-0.12.1.2-2.147.el6
kernel-2.6.32-117.el6

# virsh freecell --all
    0:   32015228 kB
    1:   32409956 kB
    2:   32387124 kB
--------------------
Total:   96812308 kB
Comment 14 Eric Blake 2011-04-12 16:14:56 UTC 
The two patches pushed for this bug introduced a regression tracked in bug 693963
Comment 15 Michal Privoznik 2011-04-28 08:18:29 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:
 missing virsh functionality
Consequence:
 virsh does not offer a way to list free memory per node
Fix:
 created new option to virsh command (freecell --all)
Result:
 virsh does list free memory per node
Comment 16 Michal Privoznik 2011-04-28 08:25:36 UTC 
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,8 +1,8 @@
 Cause:
- missing virsh functionality
+ users want to list free memory per node
 Consequence:
- virsh does not offer a way to list free memory per node
-Fix:
+ because of missing feature in virsh, users were unable to list it
+Change:
  created new option to virsh command (freecell --all)
 Result:
  virsh does list free memory per node
Comment 19 Laura Bailey 2011-05-04 06:39:19 UTC 
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,8 +1 @@
-Cause:
+An "--all" option has been added to the "virsh freecell" command to allow the command to iterate across all nodes instead of forcing users to run the command manually on each node. "virsh freecell --all" will list the free memory on all available nodes.- users want to list free memory per node
-Consequence:
- because of missing feature in virsh, users were unable to list it
-Change:
- created new option to virsh command (freecell --all)
-Result:
- virsh does list free memory per node
Comment 20 Michal Privoznik 2011-05-04 08:17:25 UTC 
* We didn't offer way to list free memory per node at once, because of missing code

* So people needed to use a workaround: manually run command against each node and compose output themselves

* We've created option which allows this

* And thus people can list summary as requested
Comment 21 errata-xmlrpc 2011-05-19 13:24:09 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0596.html
Note You need to log in before you can comment on or make changes to this bug.