Spec URL: http://hubbitus.net.ru/rpm/Fedora13/lde/lde.spec SRPM URL: http://hubbitus.net.ru/rpm/Fedora13/lde/lde-2.6.1-2.fc13.src.rpm Description: de is a disk editor for Linux, originally written to help recover deleted files. It has a simple ncurses interface that resembles an old version of Norton Disk Edit for DOS. P.S. Spec file formatted by tabs with 5 space width ( http://fedoraproject.org/wiki/PavelAlexeev/tabsize ). Please, do not start review if it is a problem for you.
Minor modification. http://hubbitus.net.ru/rpm/Fedora13/lde/lde.spec http://hubbitus.net.ru/rpm/Fedora13/lde/lde-2.6.1-3.fc13.src.rpm
The last release has been made 5 years ago. This software really looks deprecated, I would think twice before importing it in Fedora..
I known what last release was many times ago. But I do not known better alternatives really. Some time ago I was search deeply. And it just works, even no any computability patches needed. I think it is good idea have its great software in Fedora.
(In reply to comment #2) > The last release has been made 5 years ago. This software really looks > deprecated, I would think twice before importing it in Fedora.. Doesn't matter, I'm packaging WindowMaker dockapps which are sometimes even longer down than five years. Some initial issues: - The tab indents in the header should be tweaked a bit, for better readability. - Use macros wherever possible: Replace all occurences of the package name with %{name}. - Add a -p switch to the install calls to keep timestamps. - The file allfs.h has the executable bit set, please remove it (of course the bit itself, not the file ;-)
Just FYI, Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2950919
Mario, thank you for the support words. (In reply to comment #4) > - The tab indents in the header should be tweaked a bit, for better > readability. No. You just use another tab width :) Please see initial my comment. > - Use macros wherever possible: Replace all occurences of the package name > with %{name}. Good catch. Fixed. > - Add a -p switch to the install calls to keep timestamps. Fixed. > - The file allfs.h has the executable bit set, please remove it (of course > the bit itself, not the file ;-) And it fixed also. http://hubbitus.info/rpm/Fedora13/lde/lde-2.6.1-4.fc13.src.rpm http://hubbitus.info/rpm/Fedora13/lde/lde.spec
Formal review will follow soon.
Mario thank you. I think you forgot fire fedora-review flag and status to assigned. I have set its.
$ rpmlint -v * lde.src: I: checking lde.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses lde.src: I: checking-url http://lde.sourceforge.net/ (timeout 10 seconds) lde.src: I: checking-url http://dl.sf.net/lde/lde-2.6.1.tar.gz (timeout 10 seconds) lde.i686: I: checking lde.i686: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses lde.i686: I: checking-url http://lde.sourceforge.net/ (timeout 10 seconds) lde.i686: W: no-manual-page-for-binary grep-inode lde-debuginfo.i686: I: checking lde-debuginfo.i686: I: checking-url http://lde.sourceforge.net/ (timeout 10 seconds) lde.spec: I: checking-url http://dl.sf.net/lde/lde-2.6.1.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 3 warnings. Besides the issues from the spellchecker, this package looks good now. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2968774 --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2 [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 7cd3a798cafc07d084db240fd1d1c830 lde-2.6.1.tar.gz 7cd3a798cafc07d084db240fd1d1c830 lde-2.6.1.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - See Koji build above. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it... [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. Currently no man page available. -------------------------------------- PACKAGE APPROVED --------------------------------------
Mario, thank you very much! New Package SCM Request ======================= Package Name: lde Short Description: Linux disk editor Owners: hubbitus Branches: F-13 F-14 EL-5 EL-6 InitialCC:
Git done (by process-git-requests).
lde-2.6.1-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/lde-2.6.1-4.el5
lde-2.6.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lde-2.6.1-4.el6
lde-2.6.1-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/lde-2.6.1-4.fc13
lde-2.6.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/lde-2.6.1-4.fc14
lde-2.6.1-4.el6 has been pushed to the Fedora EPEL 6 testing repository.
lde-2.6.1-4.fc14 has been pushed to the Fedora 14 stable repository.
lde-2.6.1-4.fc13 has been pushed to the Fedora 13 stable repository.
lde-2.6.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.
lde-2.6.1-4.el5 has been pushed to the Fedora EPEL 5 stable repository.