SRPM: http://liangsuilong.fedorapeople.org/openfetion-2.0.2-2.fc13.src.rpm SPEC: http://liangsuilong.fedorapeople.org/openfetion.spec Description: Openfetion is a Fetion client written using GTK2+, based on Fetion v4 protocol. Koji Result: F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2604205 Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2604091 On koji, it is built for F-14 target. But for Rawhide target, It does not work. I guess there is some problem of dbus-glib for Rawhide branch.
A brief look at the spec file told me the following: > Summary: A Fetion client written using GTK2+ > %description > Openfetion is a Fetion client written using GTK2+, > based on Fetion v4 protocol. Both %summary and %description could try to explain what "Fetion" is. For example: Summary: GTK2+ based client for the Fetion instant messaging protocol And %description should expand on that. Just repeating a "Name" isn't helpful. > %setup -q -n %{name}-%{version} Option -n %{name}-%{version} is the default. > %files -f %{name}.lang > %defattr(-,root,root,-) [...] %{_datadir}/%{name}/resource/newmessage.wav %{_datadir}/%{name}/skin/* [...] %{_datadir}/%{name}/resource/license.txt Several directories are not included in the package correctly: %{_datadir}/%{name}/ %{_datadir}/%{name}/resource/ %{_datadir}/%{name}/skin/ http://fedoraproject.org/wiki/Packaging:UnownedDirectories As a directory added to a %files section will be included recursively, you may need to include directories only with the %dir attribute. > %files -n %{libname} > %defattr(-,root,root,-) > %{_datadir}/%{name}/resource/city.xml > %{_datadir}/%{name}/resource/province.xml Same here. Plus, you need to decide on directory ownership between this %libname package and the main %name package. > %{_libdir}/libofetion.so* This is wrong. Only the *.so.* files belong into the %libname package. The *.so symlink belongs into the -devel package.
Ping? Any progress here? Or we can close this review?
Stalled Review. Closing per: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews If you ever want to continue in this review, please reopen or submit new review.