Description of problem:# I asked SoundConverter to batch convert a number of files found in ~/Music/Artist, and told it to dump the output in a new folder, ~/Desktop/new, creating sub-folders using the Artist/Album structure. The example path shown below was correct. However, when the job finished, the files were stored in ~/Desktop/new/Album/Artist/Album instead. Version-Release number of selected component (if applicable): soundconverter-1.5.3-2.fc14.noarch
Currently being tracked at http://developer.berlios.de/bugs/?func=detailbug&bug_id=17473&group_id=3213
Cannot reproduce it yet. With source: ~/Music/Artist/ target: ~/Desktop/new/ and a tree like ~/Music/Artist/Album1/foo.wav ~/Music/Artist/Album2/foo.wav ~/Music/Artist/... the result is like: ~/Desktop/new/Album1/foo.wav This is with "Create subfolders" disabled. [...] In the Preferences, what are your settings for the "Where to place results?" section?
It happens if you start by clicking Add Folder, then select a folder (in my case in ~/Music) pertaining to an artist that contains *more than one sub-folder*, one for each different album. But: if the artist's folder contains *only one* sub-folder, the bug doesn't happen. Preferences: Where to place results? -> Into folder /home/james/Desktop/foo (This folder really exists.) Create subfolders checked, artist/album How to name files? -> Same as input, replace suffix Example filename: /home/james/Desktop/foo/{Artist}/{Album}/bar.mp3
Confirmed. The "[X] Create subfolders" setting is the important detail, not just the multiple source subdirs to convert. It's easy to get the test-case wrong. ;) What's written in the upstream ticket about get_target_name() is almost right. The complete patch makes sure the target folder isn't broken if "Create subfolders" isn't checked. A clear definition of SoundConverter behaviour will be needed for a final/safe implementation. I will add this comment to the upstream ticket, too. If SoundConverter is asked to create artist/album subfolders, obviously it should not prepend any portion of the "old" source directory, since that leads to duplication of "album" in your target tree. In other cases, it would duplicate an "artist" dir. That depends on what a file's parent dir name is supposed to be. It could be anything, not just album or artist. E.g. genre or the music collection's title, or the collector's personal name. SoundConverter *cannot* know how many dirs to strip off, though. E.g. imagine your added source folder(s) contained a "foo/CD-1", "foo/CD-2", "bar/CD-1", "bar/CD-2" tree. How would it know whether to remove just the "CD-x" subdir parts, if it wanted to keep the top "foo" and "bar" subdirs that were in your source folder tree? It could not get that right and really would need to strip off *all* old dirs. Theoretically, it is possible to Add Folder(s) which contain files in separate paths, which lead to a conflicting artist/album/name.ext target path. Currently, SoundConverter will open an error dialog during conversion only when it fails to (re-)write a target file. Preferably, such conflicts in target file names are found prior to starting conversion.
soundconverter-1.5.3-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/soundconverter-1.5.3-4.fc14
soundconverter-1.5.3-4.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update soundconverter'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/soundconverter-1.5.3-4.fc14
soundconverter-1.5.3-5.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update soundconverter'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/soundconverter-1.5.3-5.fc14
soundconverter-1.5.3-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/soundconverter-1.5.3-6.fc14
soundconverter-1.5.3-7.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.