Bug 654233 - [RFE] One-pass creation using TarFile
Summary: [RFE] One-pass creation using TarFile
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: sos
Version: rawhide
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ---
Assignee: Bryn M. Reeves
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-17 09:37 UTC by Pierre Carrier
Modified: 2017-02-23 17:05 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-23 17:05:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github sosreport sos issues 944 0 None None None 2017-02-23 17:05:15 UTC

Description Pierre Carrier 2010-11-17 09:37:08 UTC
Problem:
- sosreport currently creates a directory, put everything there THEN compress it
- This is CPU-intensive, involves an awful lot of unnecessary system calls, involves way more storage than necessary
- When a sosreport fails, users willing to provide files to their support team have to create the tarball themselves, when they know how to do that

Solution:
- Use Tarfile http://docs.python.org/library/tarfile.html
- Symlinks and commands outputs can be provided directly through TarFile.add() and TarInfo
- All signals need to be catched when possible, to make sure we have a consistent tarball

Positive effects:
- Less I/O, less operations
- A lot less disk space being used
- Virtually no temporary files

Negative effects:
- Back to gzip/bzip2 as TarFile does NOT expose the xz algorithm
-- or --
- Compression happens afterwards (partially defeats the purpose of this RFE)

Super-cool effect:
- (In the long term?) we can stop using /tmp and use the current directory.
- Users would have to be very explicitely notified about this change.

... Stuff I didn't think about yet, but please discuss in the comments.

Comment 1 Fedora Admin XMLRPC Client 2012-02-25 13:50:16 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Fedora Admin XMLRPC Client 2012-02-27 13:59:31 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 3 Bryn M. Reeves 2012-12-10 12:51:23 UTC
Fixed upstream.

Comment 4 Bryn M. Reeves 2014-04-01 11:34:32 UTC
Reverted due to https://github.com/sosreport/sosreport/issues/86

Comment 5 Sandro Bonazzola 2017-02-23 17:05:15 UTC
The problem described has been moved upstream in
https://github.com/sosreport/sos/issues/944


Note You need to log in before you can comment on or make changes to this bug.