Bug 654344 - F14 breaks aircrack-ng, fix found and tested.
Summary: F14 breaks aircrack-ng, fix found and tested.
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 14
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: John W. Linville
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 647800 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-17 16:17 UTC by Gilboa Davara
Modified: 2012-08-16 22:05 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-08-16 22:04:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Channel lock patch. (495 bytes, patch)
2010-11-17 16:17 UTC, Gilboa Davara
no flags Details | Diff
Updated Channel lock patch (558 bytes, patch)
2010-11-17 16:35 UTC, Gilboa Davara
no flags Details | Diff
monitor-channel-switch.patch (1.27 KB, patch)
2011-08-30 18:50 UTC, John W. Linville
no flags Details | Diff

Description Gilboa Davara 2010-11-17 16:17:52 UTC
Created attachment 461101 [details]
Channel lock patch.

Description of problem:
Upon upgrading to F14, I could no longer force my TP-Link USB wifi dongle to lock to a certain channel.
A short web search found this [1] patch.
I've created my own cfg80211_new module (coupled with custom Makefile and a patched chan.c [diff attached]) and it seems to working just fine.

Any change of getting this integrated into the next kernel drop?

Version-Release number of selected component (if applicable):
kernel-2.6.35.6-48.fc14.x86_64

How reproducible:
Always.

[1] http://www.spinics.net/lists/linux-wireless/msg51193.html

Comment 1 Gilboa Davara 2010-11-17 16:33:54 UTC
After reading the rest of the thread, there seems to be a newer (somewhat cleaner?) patch. [1, attached].

[1] http://www.spinics.net/lists/linux-wireless/msg51493.html

Comment 2 Gilboa Davara 2010-11-17 16:35:16 UTC
Created attachment 461106 [details]
Updated Channel lock patch

Comment 3 Brendan Jones 2010-11-18 20:38:08 UTC
Thanks for the report.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 4 Dave Jones 2011-08-30 14:42:08 UTC
John, is this ok to add ?

Comment 5 John W. Linville 2011-08-30 18:23:15 UTC
I would rather not add it, since there has been no resolution upstream.

What is the use case here?  Is there just a single monitor interface?

Comment 6 John W. Linville 2011-08-30 18:50:07 UTC
Created attachment 520666 [details]
monitor-channel-switch.patch

Are you (reporter) in a position to test a patch?  Compile tested only.

Comment 7 Josh Boyer 2011-08-31 15:39:22 UTC
*** Bug 647800 has been marked as a duplicate of this bug. ***

Comment 8 Gilboa Davara 2011-09-13 11:16:41 UTC
I no longer have an F14 machine to test it on.
Would F15 do?

- Gilboa

Comment 9 John W. Linville 2011-09-13 13:48:22 UTC
Sure -- the patch might even apply there. :-)  If you can't make it apply, let me know and I'll take another swipe at it...

Comment 10 Gilboa Davara 2011-10-02 16:50:43 UTC
OK. Thanks. Working on it.

- Gilboa

Comment 11 Gilboa Davara 2011-10-02 17:05:54 UTC
I've rebuilt only the mac80211 module using a local Makefile; thus far it seems to work just fine.

- Gilboa

Comment 12 John W. Linville 2011-10-04 18:20:04 UTC
So says Johannes Berg <johannes>:

> @@ -131,5 +153,8 @@ int cfg80211_set_freq(struct cfg80211_registered_device
>       if (wdev)
>               wdev->channel = chan;
>
> +     if (mon_wdev)
> +             mon_wdev->channel = chan;

This is the issue, it doesn't work. I'm finally getting to a point where
I'm not sure I care any more though, if the people who user monitor mode
are happy with this patch and don't care about getting the wrong results
then who am I to complain?

Maybe you should respin this patch with just the last bit. The checking
above is pretty much useless. Also please add *huge* warnings to it that
this *will* give the wrong results.

Alternatively, it could be fixed up properly, but I think to do that we
need a cfg80211 get_channel op to ask mac80211 what channel it really is
using. Not that this will help much once we go multi-channel :-)

Comment 13 Gilboa Davara 2011-10-08 18:07:50 UTC
Most likely I don't fully understand the internal complexities of the different driver/802.11/etc layers (hence I don't really understand the problem with the second part of the patch) - but at least in my use case I only monitor a single pre-selected AP with a fixed channel, so the patch works wonders.

- Gilboa

Comment 14 Fedora End Of Life 2012-08-16 22:05:01 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.