Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 656008

Summary: [Qlogic 5.6 bug] qlcnic: Fix kdump issues
Product: Red Hat Enterprise Linux 5 Reporter: Chad Dupuis (Cavium) <cdupuis>
Component: kernelAssignee: Chad Dupuis (Cavium) <cdupuis>
Status: CLOSED ERRATA QA Contact: Network QE <network-qe>
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: andriusb, cward, GR-Linux-NIC-Dev, hjia, nhorman, rajesh.borundia, vgoyal
Target Milestone: rcKeywords: OtherQA
Target Release: 5.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 22:02:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
0001-PCI-Block-on-access-to-temporarily-unavailable-pci.patch
none
Fix for kdump
none
Avoid use of reset_devices parameter
none
Contains two patches that fixes kdump and avoid use of reset_devices parameter none

Description Chad Dupuis (Cavium) 2010-11-22 20:46:57 UTC
Especially when entering a kdump or kexec kernel, the current PCI function may need to be reset via a PCI function level reset.  The attach patches add the necessary checks to perform the function level reset if necessary.

Comment 1 RHEL Program Management 2010-11-22 21:39:38 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Chad Dupuis (Cavium) 2010-11-22 22:25:03 UTC
Created attachment 462165 [details]
0001-PCI-Block-on-access-to-temporarily-unavailable-pci.patch

This is a back port of the upstream commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7ea7e98fd8d02351c43ef4ab35d70f3aaa26c31d.

This is needed to fix some semantics in pci_reset_function().

Comment 3 Chris Ward 2010-11-23 10:10:00 UTC
@Chad, @Qlogic, 

once test bits are available, we'll need you to provide test feedback to this BZ. Thanks!

Comment 4 Chad Dupuis (Cavium) 2010-11-23 16:31:11 UTC
(In reply to comment #2)
> Created attachment 462165 [details]
> 0001-PCI-Block-on-access-to-temporarily-unavailable-pci.patch
> 
> This is a back port of the upstream commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7ea7e98fd8d02351c43ef4ab35d70f3aaa26c31d.
> 
> This is needed to fix some semantics in pci_reset_function().

Test builds of this patch against the latest RHEL 5 kernel succeeded; there were no problems seen.

Comment 5 rajesh.borundia 2010-11-24 15:26:20 UTC
Created attachment 462664 [details]
Fix for kdump

Fix for kdump , it resets the pci function based on reset_devices
parameter.

Comment 6 rajesh.borundia 2010-11-24 15:31:04 UTC
Created attachment 462669 [details]
Avoid use of reset_devices parameter

This patch Avoid reset_devices parameter and uses a driver
mechanism to detect when to reset a device.

Above two patches should be applied one after other.

This patch is sent to upstream but not accepted yet.
http://permalink.gmane.org/gmane.linux.network/178814

Comment 7 rajesh.borundia 2010-11-30 11:24:54 UTC
Created attachment 463695 [details]
Contains two patches that fixes kdump and avoid use of reset_devices parameter

The Attachement contains a tar of two patches
1. 0001-qlcnic-Fix-for-kdump.patch (Fixes kdump issue)
2. 0002-qlcnic-avoid-using-reset_devices-as-it-may-become-ob.patch (Avoids use of reset_devices parameter)

These patches are with Dave M's Signature.

Comment 8 Andrius Benokraitis 2010-11-30 16:18:32 UTC
So Chad, which patches were POSTed? I noticed more patches were added today, after you set it to POST. Can you clear this up? Thanks!

Comment 9 Chad Dupuis (Cavium) 2010-11-30 17:00:36 UTC
(In reply to comment #8)
> So Chad, which patches were POSTed? I noticed more patches were added today,
> after you set it to POST. Can you clear this up? Thanks!

Afaict, the code in the patches is the same as were POSTed.  The difference is that the ones Rajesh just posted were signed off by David Miller who is the maintainer of the upstream net-2.6 tree.  These just signify that they were accepted into a maintainer's tree.  The original patch set has been ACK'd already so I'm not going to repost the new patches.

In other words I think we're good here.

Comment 10 rajesh.borundia 2010-11-30 17:34:04 UTC
Yes I re posted the same patches as they are now signed off by David Miller.

Comment 14 Andrius Benokraitis 2010-11-30 22:59:34 UTC
(In reply to comment #10)
> Yes I re posted the same patches as they are now signed off by David Miller.

Great, thanks for the clarification.

Comment 15 Jarod Wilson 2010-12-02 15:16:24 UTC
in kernel-2.6.18-235.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 17 Hushan Jia 2010-12-13 06:15:28 UTC
@Qlogic,

This fix is in RHEL5.6 beta kernels, could you test and post your feedback?
The packages can be found in Comment #15.

Thanks.

Comment 18 Marvell Linux NIC Driver 2010-12-13 09:29:38 UTC
Verified on kernel-2.6.18-235.el5 and kernel-2.6.18-236.el5 from comment #15.
I was abe to capture dump.

Comment 19 Marvell Linux NIC Driver 2010-12-13 10:32:46 UTC
Clearing the needinfo through Comment #18

Comment 21 errata-xmlrpc 2011-01-13 22:02:22 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html