Spec URL: http://honzaf.fedorapeople.org/omping/omping.spec SRPM URL: http://honzaf.fedorapeople.org/omping/omping-0.0.1-1.fc14.src.rpm Description: Omping (Open Multicast Ping) is tool to test IP multicast functionality primarily in local network.
Just a comment, because I'm no sponsor: - Please use %{_prefix} istead of /usr: ("rpm --eval %{_prefix}"...)
since I'm not sponzor, here is only formal review: Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [1] [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [?] Spec file is legible and written in American English. [x] Spec file lacks Packager, Vendor, PreReq tags. [!] Spec uses macros instead of hard-coded directory names. I would suggest: -make DESTDIR="%{buildroot}" PREFIX="/usr" install +make DESTDIR="%{buildroot}" PREFIX="%{_prefix}" install [x] Package consistently uses macros. [x] Macros in Summary, %description expandable at SRPM build time. [x] PreReq is not used. [x] Requires correct, justified where necessary. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [2] [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)). [x] Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. [x] Package use %makeinstall only when ``make install DESTDIR=...'' doesn't work. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [-] The spec file handles locales properly. [x] Changelog in prescribed format. [!] Rpmlint output is silent. serious: omping.src: W: invalid-url Source0: http://fedorahosted.org/releases/o/m/omping/omping-0.0.1.tar.gz HTTP Error 404: Not Found omping.x86_64: W: manual-page-warning /usr/share/man/man8/omping.8.gz 66: warning: macro `ni' not defined ok: omping.src: W: spelling-error Summary(en_US) multicast -> Multics, multicolor, multichannel omping.src: W: spelling-error %description -l en_US multicast -> Multics, multicolor, multichannel [x] License field in the package spec file matches the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] License file installed when any subpackage combination is installed. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [3,4] [x] Sources contain only permissible code or content. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. http://fedorahosted.org/releases/o/m/omping/omping-0.0.1.tar.gz HTTP Error 404: Not Found [x] Compiler flags are appropriate. [x] %build honors applicable compiler flags or justifies otherwise. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not own files or directories owned by other packages. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Each %files section contains %defattr. [x] No %config files under /usr. [x] %config files are marked noreplace or the reason is justified. [-] Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [5] [-] Package contains a valid .desktop file. [x] Package contains code, or permissable content. [-] Package contains a SysV-style init script if in need of one. [x] File names are valid UTF-8. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Package contains no bundled libraries. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [x] Package contains no static executables. [x] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Useful -debuginfo package or justification otherwise. [x] Rpath absent or only used for internal libs. [x] Package does not genrate any conflict. [x] Package does not contains kernel modules. [x] Package is not relocatable. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] Package is not known to require ExcludeArch. [x] Package installs properly. [x] Package obeys FHS, except libexecdir and /usr/target. [x] Package meets the Packaging Guidelines. [6] [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines [2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines [4] https://fedoraproject.org/wiki/Licensing:Main [5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [6] https://fedoraproject.org/wiki/Packaging:Guidelines
Petr, Thomas, thanks for very quick review. Fixed SPEC: http://honzaf.fedorapeople.org/omping/omping.spec SRPM: http://honzaf.fedorapeople.org/omping/omping-0.0.1-2.fc14.src.rpm Thanks, Honza
Buildroot is not needed since F-12. Also rm -rf in build part was obsoleted but you can leave both if you need this package also for EL-5. Otherwise they can be safely removed.
[x] Sources used to build the package matches the upstream source, as provided in the spec URL. upstream tarball: 9d1c4e66ae6f35b4ace6dbcc94eb66cb omping-0.0.1.tar.gz src.rpm tarball: 9d1c4e66ae6f35b4ace6dbcc94eb66cb omping-0.0.1.tar.gz [x] Rpmlint output is silent. [x] Spec uses macros instead of hard-coded directory names. It seems ok now.
(In reply to comment #4) > Buildroot is not needed since F-12. Also rm -rf in build part was obsoleted but > you can leave both if you need this package also for EL-5. Otherwise they can > be safely removed. Marcela, thanks for review. Packages is targeted for EL-5 too, so I would rather keep rm -rf and buildroot there. Thanks, Honza
APPROVED
New Package SCM Request ======================= Package Name: omping Short Description: Utility to test IP multicast functionality Owners: honzaf Branches: InitialCC:
New Package SCM Request ======================= Package Name: omping Short Description: Utility to test IP multicast functionality Owners: honzaf Branches: f14 InitialCC:
Git done (by process-git-requests).
omping-0.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/omping-0.0.1-2.fc14
omping-0.0.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update omping'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/omping-0.0.1-2.fc14
omping-0.0.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: omping New Branches: el5 Owners: honzaf InitialCC: Package should be included in RHEL 5, to allow customers to test their network environment cooperation with OpenAIS/RHCS.
omping-0.0.4-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/omping-0.0.4-1.el5
omping-0.0.4-1.el5 has been pushed to the Fedora EPEL 5 stable repository.