Bug 657097
| Summary: | [Broadcom 5.6 bug] tg3: Fix 5719 bugs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Matt Carlson <mcarlson> | ||||
| Component: | kernel | Assignee: | John Feeney <jfeeney> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Network QE <network-qe> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.6 | CC: | andriusb, benlu, gideonn, hjia, jfeeney, mcarlson | ||||
| Target Milestone: | rc | Keywords: | OtherQA | ||||
| Target Release: | 5.6 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-13 22:02:37 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Okay, I have looked at and tried to apply the patches and this is what I have determined: The following can be done: d309a46e42542223946d3a9e4e239fdc945cb53e Prevent tx data corruption (10/1/2010) b75cc0e4c1caac63941d96a73b2214e8007b934b Assign correct tx margin for 5719 (11/24/2020) 88075d915b51d9a17cc7436c868013a3113a849a Don't access phy test ctrl reg for 5719+ (8/2/2010) 5093eedc8bdfd7d906836a44a248f66a99e27d22 Apply 10Mbps fix to all 67776 revisions (11/24/2010) Also need: c885e824699f49bc3758a0dec760e189cd774e79 tg3: Create TG3_FLG3_5717_PLUS flag (8/2/2010) 41a8a7ee4a78216962f3afcea5968c04d0ab3b08 tg3: Fix read DMA FIFO overruns on recent devices (9/15/2010) But cf79003d598b1f82a4caa0564107283b4f560e14 Fix 5719 internal FIFO overflow (11/24/2010) needs PCI_EXP_LNKSTA* defines which isn't in RHEL5.6. Not sure if I can get this in at this time. How important is this one? This is probably the most important one. I have the following code in the out-of-tree driver, should you find it useful. #ifndef PCI_EXP_LNKSTA #define PCI_EXP_LNKSTA 18 #endif #ifndef PCI_EXP_LNKSTA_CLS #define PCI_EXP_LNKSTA_CLS 0x000f #endif #ifndef PCI_EXP_LNKSTA_CLS_2_5GB #define PCI_EXP_LNKSTA_CLS_2_5GB 0x01 #endif #ifndef PCI_EXP_LNKSTA_CLS_5_0GB #define PCI_EXP_LNKSTA_CLS_5_0GB 0x02 #endif #ifndef PCI_EXP_LNKSTA_NLW #define PCI_EXP_LNKSTA_NLW 0x03f0 #endif #ifndef PCI_EXP_LNKSTA_NLW_SHIFT #define PCI_EXP_LNKSTA_NLW_SHIFT 4 #endif Thanks Matt. I just wanted to get a feel for its importance before taking the plunge, so to speak. I'll see what I can do. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. I included all the upstream patches listed in comment #2, as well as part of the patch that added the PCI_LNKSTA* defines upstream: "igb: add support for reporting 5GT/s during probe on PCIe Gen2" Duyck Apr 27, 2010 commit: ff846f52935e6c8dfb0c97df7c2c1bf777454684. The x86_64 built rpm can be found on my people page at http://people.redhat.com/jfeeney/.rhel-5.6 Given a pressing deadline, a quick turn around on testing would be very much appreciated. Will do. (In reply to comment #7) > Will do. "Quick turnaround" means Wed. (tomorrow) if at all possible, thanks! *** Bug 640061 has been marked as a duplicate of this bug. *** We have done a quick sanity tests includes 1. IPv4 netperf test: Pass 2. Ethtool sleftest test: Pass 3. LED test: Pass 4. Speed/Dpulex test: Pass in kernel-2.6.18-236.el5 You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5 Detailed testing feedback is always welcomed. @Broadcom, 5.6 beta kernels now are available at Comment #13, could you test and post your feedback? Thanks. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0017.html |
Created attachment 462763 [details] Additional fixups Description of problem: During testing we discovered several 5719 related bugs. Please apply the following upstream commits and the attached patches. d309a46e42542223946d3a9e4e239fdc945cb53e b75cc0e4c1caac63941d96a73b2214e8007b934b cf79003d598b1f82a4caa0564107283b4f560e14 88075d915b51d9a17cc7436c868013a3113a849a 5093eedc8bdfd7d906836a44a248f66a99e27d22 Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: