Bug 657142 - Review Request: ghc-syb - Scrap Your Boilerplate
Summary: Review Request: ghc-syb - Scrap Your Boilerplate
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Narasimhan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-25 03:40 UTC by Jens Petersen
Modified: 2012-05-11 12:30 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-26 10:22:29 UTC
Type: ---
Embargoed:
lakshminaras2002: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jens Petersen 2010-11-25 03:40:26 UTC
Spec URL: http://petersen.fedorapeople.org/ghc-syb/ghc-syb.spec
SRPM URL: http://petersen.fedorapeople.org/ghc-syb/ghc-syb-0.2.2-1.fc14.src.rpm
Description: 
This package contains the generics system described in the Scrap Your Boilerplate papers (see http://www.cs.uu.nl/wiki/GenericProgramming/SYB). It defines the Data class of types permitting folding and unfolding of constructor applications, instances of this class for primitive types, and a variety of traversals.

Comment 1 Jens Petersen 2010-11-25 03:41:53 UTC
syb is no longer in ghc-7 and is needed at least by ghc-X11.

Comment 3 Jens Petersen 2010-11-25 09:45:34 UTC
Also needed by latest haskell-src.

Comment 4 Narasimhan 2010-11-25 14:43:53 UTC
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.

rpmlint  -i ghc-syb*.rpm ghc-syb.spec 
ghc-syb.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-syb.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-syb-devel.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-syb-prof.i686: E: devel-dependency ghc-syb-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-syb-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-syb-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/syb-0.2.2/libHSsyb-0.2.2_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

4 packages and 1 specfiles checked; 1 errors, 5 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK, BSD
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Buildroot is ignored - present anyway. OK
        %clean is ignored - present anyway. OK
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, present in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
License BSD, mentioned in cabal and source files.

[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
[~]md5sum syb-0.2.2.tar.gz 
34cb1911dd3efc05eb23b68ac82b6621  syb-0.2.2.tar.gz

[~/Downloads]md5sum syb-0.2.2.tar.gz
34cb1911dd3efc05eb23b68ac82b6621  ~/Downloads/syb-0.2.2.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on i686 and x86_64

[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Validated with rpmquery --whatprovides 

[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissable content.
[+]MUST: Large documentation files must go in a -doc subpackage.
Developer documentation in -devel package.

[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section

[+]MUST: Packages must not own files or directories already owned by other packages.
Validated with rpmquery --list

[+]MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installed the package.Went fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

APPROVED.

Comment 5 Jens Petersen 2010-11-26 01:58:21 UTC
Thank you for the speedy review.


New Package SCM Request
=======================
Package Name: ghc-syb
Short Description: Scrap Your Boilerplate
Owners: petersen
Branches: 
InitialCC: haskell-sig

Comment 6 Jens Petersen 2010-11-26 07:03:37 UTC
Git done (by process-git-requests).

Comment 7 Jens Petersen 2010-11-26 10:22:29 UTC
Thanks again

Comment 8 Jens Petersen 2012-05-11 10:39:24 UTC
Package Change Request
======================
Package Name: ghc-syb
New Branches: el6
Owners: petersen
InitialCC: haskell-sig

Comment 9 Gwyn Ciesla 2012-05-11 12:30:50 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.