Description of problem: The output message is a little confused when starting xendomains with invalid image and regular saved domain. Version-Release number of selected component (if applicable): host: x86_64, kernel-xen-2.6.18-233.el5, xen-3.0.3-119.el5 guest: rhel5.5-32bit-pv How reproducible: always Steps to Reproduce: 1.Set the XENDOMAINS_SAVE option to /var/lib/xen/save 2.Set the XENDOMAINS_RESTORE option to true 3.Set the XENDOMAINS_RESTOREFAILTYPE to 'rename' 4.Create a regular domain 5.Create the invalid image under $XENDOMAINS_SAVE #dd if=/dev/zero of=/var/lib/xen/save/invalid bs=1M count=50 6.Stop xendomains service 7.Start xendomains service Actual results: After step 7, the output message is a little confused. The "!" stands alone. Whether the "[failed]" shows the regular domain rhel5u5-32-pv restore failure or this "start xendomains service" operation failure? ...... [host]# /etc/init.d/xendomains start Restoring Xen domains: invalid FAILED: Invalid restore image /var/lib/xen/save/invalid Restore image has been renamed to /var/lib/xen/save/.invalid An error occured while restoring domain invalid: Error: Restore failed ! rhel5u5-32-pv. [failed] [FAILED] Expected results: Devel can design and make the output more clear. Additional info: 1.The output message is also not neat when stoping xendomains to shutdown auto-created domain, because "[ OK ]" mixed with ".....[done]" [host]# /etc/init.d/xendomains stop Shutting down Xen domains: rhel5u5-64-pv(shut).............[ OK ]...[done]
If devel think this is not a problem, just feel free to close it.
(In reply to comment #0) > Description of problem: > The output message is a little confused when starting xendomains with invalid > image and regular saved domain. > > > Version-Release number of selected component (if applicable): > host: x86_64, kernel-xen-2.6.18-233.el5, xen-3.0.3-119.el5 > guest: rhel5.5-32bit-pv > > > How reproducible: > always > > Steps to Reproduce: > 1.Set the XENDOMAINS_SAVE option to /var/lib/xen/save > 2.Set the XENDOMAINS_RESTORE option to true > 3.Set the XENDOMAINS_RESTOREFAILTYPE to 'rename' > 4.Create a regular domain > 5.Create the invalid image under $XENDOMAINS_SAVE > #dd if=/dev/zero of=/var/lib/xen/save/invalid bs=1M count=50 > 6.Stop xendomains service > 7.Start xendomains service > > > Actual results: > After step 7, the output message is a little confused. The "!" stands alone. > Whether the "[failed]" shows the regular domain rhel5u5-32-pv restore failure > or this "start xendomains service" operation failure? > > ...... > [host]# /etc/init.d/xendomains start > Restoring Xen domains: invalid > FAILED: Invalid restore image /var/lib/xen/save/invalid > Restore image has been renamed to /var/lib/xen/save/.invalid > > An error occured while restoring domain invalid: > Error: Restore failed > ! > rhel5u5-32-pv. > [failed] > [FAILED] > > > Expected results: > Devel can design and make the output more clear. > > > Additional info: > 1.The output message is also not neat when stoping xendomains to shutdown > auto-created domain, because "[ OK ]" mixed with ".....[done]" > [host]# /etc/init.d/xendomains stop > Shutting down Xen domains: rhel5u5-64-pv(shut).............[ OK ]...[done] Hi Binbin, I've tried to design and implement some better output and here are the results but I'm not sure it's good enough from the user's perspective. This example output is done for 2 guests, rhel5-32pv and rhel5-64fv, that are both running on the host and also we need to create the invalid file. Touch command is good enough to create the invalid save file so here's the output including the commands used: # touch /var/lib/xen/save/invalid; /etc/init.d/xendomains start Restoring Xen domains: invalid FAILED: Invalid restore image /var/lib/xen/save/invalid Restore image has been renamed to /var/lib/xen/save/.invalid An error occured while restoring domain invalid: Error: Restore failed ! Going on... Restoring domain rhel5-32pv Domain rhel5-32pv restored successfully rhel5-64fv Domain rhel5-64fv restored successfully . # Is that good? What do you think? Thanks, Michal
Hi Michal, I think the improved output show more clear information and enough for the enhancement.
Created attachment 483122 [details] Improve xendomains output Hi, this is the patch for to implement a better xendomains script output. It's been tested on RHEL-5 x86_64 dom0 with the patch applied and the formatting seems to be a little better and not that much confused now. Also, the output has been reviewed by Qixiang Wan <qwan> and according to Qixiang the output is improved and the information output are more clear now. Michal
Fix built into xen-3.0.3-126.el5
verified the output has been improved with xen-3.0.3-129.el5. $ /etc/init.d/xendomains start Restoring Xen domains: invalid FAILED: Invalid restore image /var/lib/xen/save/invalid Restore image has been renamed to /var/lib/xen/save/.invalid An error occured while restoring domain invalid: Error: Restore failed! [failed] [FAILED]
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: When starting or stopping the xendomains service with an invalid image and a regular saved domain, the formatting of the output messages was confusing and hard to read. With this update, the output has been clarified.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-1070.html