Bug 657783 - [abrt] SwRenderData points to dead ViewShell after canceled print
Summary: [abrt] SwRenderData points to dead ViewShell after canceled print
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: openoffice.org
Version: 14
Hardware: x86_64
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:00847740774bef398cb25064c9a...
: 666641 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-27 21:28 UTC by tomas
Modified: 2012-03-27 09:57 UTC (History)
3 users (show)

Fixed In Version: openoffice.org-3.3.0-20.7.fc14
Clone Of:
Environment:
Last Closed: 2012-03-27 09:57:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (221.08 KB, text/plain)
2010-11-27 21:28 UTC, tomas
no flags Details


Links
System ID Private Priority Status Summary Last Updated
FreeDesktop.org 39159 0 None None None Never

Description tomas 2010-11-27 21:28:17 UTC
abrt version: 1.1.14
architecture: x86_64
Attached file: backtrace
cmdline: /usr/lib64/openoffice.org3/program/scalc.bin -calc file:///home/tomas/Desktop/vse/def/intrastat/intrastat1010.ods
component: openoffice.org
crash_function: StartAction
executable: /usr/lib64/openoffice.org3/program/scalc.bin
kernel: 2.6.35.6-48.fc14.x86_64
package: openoffice.org-calc-1:3.3.0-15.2.fc14
rating: 4
reason: Process /usr/lib64/openoffice.org3/program/scalc.bin was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
time: 1290857717
uid: 500

How to reproduce
-----
1pri startu oof?
2.
3.

Comment 1 tomas 2010-11-27 21:28:37 UTC
Created attachment 463276 [details]
File: backtrace

Comment 2 David Tardon 2010-11-28 07:50:05 UTC
I think I know how that happened. The SwRenderData object is only cleaned up when the last page is printed, not when print is cancelled, which means it tries to use already dead ViewShell later when it is destroyed (which happens on exit, or, presumably, on subsequent print). There are several places in VCL that try to avoid that by faking printing of the last page. I have a rough patch somewhere that derives the SwRenderData from SfxListener registered at its ViewShell, so it can clean up itself when the ViewShell is destroyed, which should be better solution (I really think this is an impl. detail that has no business being exposed outside of its module.)

Comment 3 David Tardon 2010-11-30 07:21:40 UTC
Bah, this isn't as simple as I imagined :-( I can avoid the crash just fine, but I haven't found any way to restore the original view settings after a cancelled print without the VCL workaround yet... Anyway, the crash after cancelling a print job I mentioned in my previous comment has been fixed at least since 3.3.0-14.1 (Philip has also moved all the workaround code to one place, which is nice), so the situation is not as bad as I thought.

I'll return to this later, hopefully with some fresh idea. It would help if I knew how it happened: do you remember what you were doing before the crash? (You can speak Czech :-)

Comment 4 tomas 2010-11-30 09:28:29 UTC
I'm sorry. I mean, that OOO crashed in the start time without print. I remember nothing about cancelling a print job. Since this time goes OOO and print well.
I don't know, how to reproduce this problem. I mean, that in the my system may be a bug. F14 is upgrade from F13 and a few packages stay from fc13.

Comment 5 David Tardon 2010-11-30 09:45:44 UTC
Well, the backtrace is clearly from update of print preview in the print dialog.

Comment 6 David Tardon 2011-01-02 07:22:39 UTC
*** Bug 666641 has been marked as a duplicate of this bug. ***

Comment 7 Caolan McNamara 2011-08-22 12:57:22 UTC
This may be http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd690d2e72be410058376c416a40ff5d918fb0f7

i.e. the "selection" option makes a temp document with a temp viewshell which can go away when you click through the options.

Comment 8 Caolan McNamara 2011-08-23 09:56:52 UTC
yeah, I think it is, I'll backport this fix

Comment 9 Caolan McNamara 2011-08-23 11:59:56 UTC
will try that in >= openoffice.org-3.3.0-20.7.fc14

Comment 10 Caolan McNamara 2012-03-27 09:57:21 UTC
Fedora 14 is EOL


Note You need to log in before you can comment on or make changes to this bug.