This package is new for Fedora. Spec URL: http://www.geofrogger.net/review/esniper.spec SRPM URL: http://www.geofrogger.net/review/esniper-2.24.0-1.fc13.src.rpm Description: Esniper is a lightweight console application for sniping eBay auctions.
Hi Volker, here are some initial comments on your spec: - adapt Source0 according to http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net - If you plan to maintain this package for EPEL < 6 too, please add a BuildRoot tag. Otherwise, you can also drop the %clean section and rm -rf %{buildroot} from %install. - replace %{_mandir}/man1/%{name}.1.gz with %{_mandir}/man1/%{name}.1* since you should not rely on a specific compression format applied by rpmbuild because it might change - add the %doc files NEWS, README, TODO - I also recommend to add the sample configuration files as %doc
Spec URL: http://www.geofrogger.net/review/esniper.spec SRPM URL: http://www.geofrogger.net/review/esniper-2.24.0-2.fc13.src.rpm I excluded NEWS, README and TODO on purpose, because their content is dead-old. Should I add them anyway? The sample configuration is also on the man page. Do you think I should add it still? I did the rest.
(In reply to comment #2) > I excluded NEWS, README and TODO on purpose, because their content is dead-old. > Should I add them anyway? No. Sorry, I obviously didn't read them properly enough. > The sample configuration is also on the man page. Do you think I should add it > still? Yes, I think so. It doesn't hurt to have them as separate files.
Done I also added a frontend script, I haven't noticed before. Spec URL: http://www.geofrogger.net/review/esniper.spec SRPM URL: http://www.geofrogger.net/review/esniper-2.24.0-3.fc13.src.rpm
More specific files section and added another sample file. Spec URL: http://www.geofrogger.net/review/esniper.spec SRPM URL: http://www.geofrogger.net/review/esniper-2.24.0-4.fc13.src.rpm [makerpm@fedora14 SPECS]$ rpmlint ../SRPMS/esniper-2.24.0-4.fc14.src.rpm ../RPMS/x86_64/esniper-*4.fc14.x86_64.rpm esniper.x86_64: W: no-manual-page-for-binary snipe 3 packages and 0 specfiles checked; 0 errors, 1 warnings. http://koji.fedoraproject.org/koji/taskinfo?taskID=2864490
Sorry: http://www.geofrogger.net/review/esniper-2.24.0-4.fc14.src.rpm
Hi Volker, the package looks almost fine. Please preserve the timestamp of the manpage. You can accomplish this by extending the iconv line this way: iconv -f iso8859-1 -t utf-8 esniper.1 > esniper.1.conv \ && touch -r esniper.1 esniper.1.conv \ && mv esniper.1.conv esniper.1 Also, append INSTALL="install -p" to "make install".
Thank you! http://www.geofrogger.net/review/esniper.spec http://www.geofrogger.net/review/esniper-2.24.0-5.fc14.src.rpm
The definition of INSTALL is still missing. ;)
Argh! Deleted the wrong line. http://www.geofrogger.net/review/esniper.spec http://www.geofrogger.net/review/esniper-2.24.0-6.fc14.src.rpm
OK, the package looks good now. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm esniper.x86_64: W: no-manual-page-for-binary snipe 3 packages and 0 specfiles checked; 0 errors, 1 warnings. There's no manpage available for snipe, so the warning can be ignored. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - BSD (two-clause variant) [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum esniper-2-24-0.tgz* aae4b24cc37b9bbb6ba78e017e127ded esniper-2-24-0.tgz aae4b24cc37b9bbb6ba78e017e127ded esniper-2-24-0.tgz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied. [.] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, ... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ----------------
New Package SCM Request ======================= Package Name: esniper Short Description: A lightweight console application for sniping eBay auctions Owners: volter Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
Package esniper-2.24.0-6.fc14: * should fix your issue, * was pushed to the Fedora 14 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing esniper-2.24.0-6.fc14' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc14 then log in and leave karma (feedback).
Package esniper-2.24.0-6.fc15: * should fix your issue, * was pushed to the Fedora 15 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing esniper-2.24.0-6.fc15' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc15 then log in and leave karma (feedback).
esniper-2.24.0-6.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update esniper'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/esniper-2.24.0-6.fc15
esniper-2.24.0-6.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
esniper-2.24.0-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.