Spec URL: http://static.zapletalovi.com/fedora/rpm/launchy/2.5-1/launchy.spec SRPM URL: http://static.zapletalovi.com/fedora/rpm/launchy/2.5-1/launchy-2.5-1.fc14.src.rpm Description: Launchy is a free cross-platform utility designed to help you forget about your start menu, the icons on your desktop, and even your file manager. Launchy indexes the programs in your start menu and can launch your documents, project files, folders, and bookmarks with just a few keystrokes! $ rpmlint launchy-2.5-1.fc14.i686.rpm launchy-debuginfo-2.5-1.fc14.i686.rpm launchy-devel-2.5-1.fc14.i686.rpm launchy.i686: W: no-manual-page-for-binary launchy 3 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint launchy-2.5-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Correcting XDG icon path issue causing some icons incorrectly loaded: http://static.zapletalovi.com/fedora/rpm/launchy/2.5-2/
missing buildrequires: gcc-c++ Please try to build in koji as scretch build to find possible missing build requires. rpmlint -i /home/mirek/rpmbuild/RPMS/i686/launchy-2.5-2.fc14.i686.rpm launchy.i686: E: explicit-lib-dependency libX11 You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. launchy.i686: W: no-manual-page-for-binary launchy Each executable in standard binary directories should have a man page even without specifying libX11 you automatically get libX11.so.6 as requirement. The same probably apply on qt, rpmbuild will give you: libQtCore.so.4 libQtGui.so.4 libQtNetwork.so.4 so you most probably do not need to require qt and qt-x11, you "just" need those 3 libraries. you use there once /usr/share, you may want to replace it with: %{_datadir} Apart from this it seems ok (for first sight).
@Mirek: Thanks. I have corrected libraries and added GCC dep and fixed the datadir. http://koji.fedoraproject.org/koji/taskinfo?taskID=2729101 http://koji.fedoraproject.org/koji/getfile?taskID=2729102&name=launchy-2.5-3.fc15.src.rpm
SRC.RPM: [13:10] <lzap> http://lzap.fedorapeople.org/fedora-packaging/launchy/2.5-3/
>* Mon Sep 06 2010 Lukas Zapletal <lzap+rpm> - 2.5-3 >- review by msuchy This is inappropriate. In changelog we write what we done, why you done it should be written in BZ. I would recommend: - 657948 - fix requires and buildrequires
============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f16/i686, x86_64 [!] Rpmlint output: rpmlint /tmp/launchy-*.rpm launchy-debuginfo.x86_64: W: only-non-binary-in-usr-lib launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/precompiled.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/common/DropListWidget.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/platforms/unix/platform_unix.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/InputDataList.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/icon_delegate.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/SettingsManager.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/globals.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/common/FileBrowserDelegate.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/common/FileBrowserDelegate.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/FileSearch.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/main.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/plugin_handler.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog_types.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/verby/Verby.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/options.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CharListWidget.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/calcy/gui.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/platform_base.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/calcy/gui.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/Fader.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/main.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/gui.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/runner.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/InputDataList.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/calcy/calcy.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/gcalc/gcalc.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog_builder.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CommandHistory.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/gui.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/FileSearch.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/verby/gui.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/precompiled.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/runner.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/platforms/unix/platform_unix.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/AnimationLabel.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CommandHistory.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/options.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CharLineEdit.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/SettingsManager.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/common/DropListWidget.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/AnimationLabel.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/icon_extractor.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CharListWidget.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/platform_base_hotkey.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/plugin_interface.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/CharLineEdit.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/precompiled.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/platforms/unix/platform_x11_hotkey.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/Fader.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/icon_delegate.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/globals.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/platform_base_hotkey.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog_builder.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/verby/Verby.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/globals.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/runner/gui.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/gcalc/precompiled.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/weby.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/calcy/calcy.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/globals.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/catalog_types.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/verby/gui.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/plugin_handler.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/platform_base_hottrigger.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/plugin_interface.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/calcy/precompiled.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/gui.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/icon_extractor.cpp launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/gcalc/gcalc.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/plugins/weby/weby.h launchy-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/launchy-2.5/src/Directory.h launchy-devel.x86_64: E: incorrect-fsf-address /usr/include/launchy/plugin_interface.h launchy-devel.x86_64: E: incorrect-fsf-address /usr/include/launchy/catalog.h launchy.x86_64: E: incorrect-fsf-address /usr/share/doc/launchy-2.5/LICENSE.txt launchy.x86_64: W: no-manual-page-for-binary launchy 4 packages and 0 specfiles checked; 76 errors, 2 warnings. [x] Package is not relocatable. [x] Buildroot is correct %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Note: if you do not intend to package for EPEL5, then Buildroot is not needed at all. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. GPL+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. ca9de9e165d6c327f48aa81dd0ee1a6f launchy-2.5.tar.gz ca9de9e165d6c327f48aa81dd0ee1a6f ../SOURCES/launchy-2.5.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji scratch build [x] Package should compile and build into binary rpms on all supported architectures. Tested on:koji scratch build [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [!] %check is present and the tests pass All MUST items are resolved. However I strongly suggest you to: 1) Contact upstream and fix FSF address in GPL license 2) write man page of launchy and sent it to upstream. If you have problem writing man page or you never done it, I recommend you: http://www.methods.co.nz/asciidoc/ http://www.methods.co.nz/asciidoc/asciidoc.1.txt You can look in spec file of "tito" how you can handle it. 3) contact upstream an move /usr/lib64/launchy/plugins/icons/* to /usr/share/launchy/ These two items are minor and can be fixed during live in Fedora. ================ *** APPROVED *** ================
Thank you, contacted upstream: https://sourceforge.net/tracker/?func=detail&aid=3419790&group_id=132975&atid=725839 This program was really difficult to package, very non-standard. New Package SCM Request ======================= Package Name: launchy Short Description: Free cross-platform utility designed to start apps Owners: lzap Branches: f16 InitialCC:
Git done (by process-git-requests).
@Jon - I am unable to clone it: [lzap@lzapx fedpkg]$ fedpkg clone launchy Cloning into launchy... R access for launchy DENIED to lzap (Or there may be no repository at the given path. Did you spell it correctly?) fatal: The remote end hung up unexpectedly Could not clone: Command '['git', 'clone', 'ssh://lzap.org/launchy']' returned non-zero exit status 128
Lukas. I do not think rel-eng monitor this bugzilla. If you need their attention, you have to either reset fedora-cvs to ? or (rather preferable) contact them dirctly using: http://fedoraproject.org/wiki/ReleaseEngineering#Contact_Information IRC: #fedora-devel Mailing List: rel-eng.org Issue tracker: https://fedorahosted.org/rel-eng/newticket
https://fedorahosted.org/rel-eng/ticket/4995
Can we close it now Lukas?
Finally submitting builds.
launchy-2.5-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/launchy-2.5-5.fc16
launchy-2.5-5.fc16 has been pushed to the Fedora 16 testing repository.