Bug 658125 - Review Request: perl-CGI - Handle Common Gateway Interface requests and responses
Summary: Review Request: perl-CGI - Handle Common Gateway Interface requests and respo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 657950 671352
TreeView+ depends on / blocked
 
Reported: 2010-11-29 12:58 UTC by Marcela Mašláňová
Modified: 2011-01-21 11:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-12-01 14:36:10 UTC
Type: ---
Embargoed:
psabata: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)
Spec file patch (451 bytes, patch)
2010-11-29 13:46 UTC, Petr Šabata
no flags Details | Diff

Description Marcela Mašláňová 2010-11-29 12:58:16 UTC
SRPM: http://mmaslano.fedorapeople.org/review/perl-CGI-3.50-1.fc14.src.rpm
SPEC: http://mmaslano.fedorapeople.org/review/perl-CGI.spec
Description:
CGI.pm is a stable, complete and mature solution for processing and preparing
HTTP requests and responses. Major features including processing form
submissions, file uploads, reading and writing cookies, query string generation
and manipulation, and processing and preparing HTTP headers. Some HTML
generation utilities are included as well.

CGI.pm performs very well in in a vanilla CGI.pm environment and also comes
with built-in support for mod_perl and mod_perl2 as well as FastCGI.

Question is: on cpan it is as CGI.pm. Should we package it as perl-CGI.pm?

Comment 1 Marcela Mašláňová 2010-11-29 13:00:36 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=2631849

Comment 2 Petr Šabata 2010-11-29 13:46:15 UTC
Created attachment 463486 [details]
Spec file patch

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Package is named according to the Package Naming Guidelines. [1]
[x]  Spec file name must match the base package %{name}, in the format %{name}.spec.
[x]  Spec file is legible and written in American English.
[x]  Spec file lacks Packager, Vendor, PreReq tags.
[x]  Spec uses macros instead of hard-coded directory names.
[x]  Package consistently uses macros.
[-]  Macros in Summary, %description expandable at SRPM build time.
[x]  PreReq is not used.
[x]  Requires correct, justified where necessary.
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [2]
[-]  Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)).
[-]  Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install.
[x]  Package use %makeinstall only when ``make install DESTDIR=...'' doesn't work.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[-]  The spec file handles locales properly.
[x]  Changelog in prescribed format.
[x]  Rpmlint output is silent.
[x]  License field in the package spec file matches the actual license.
[-]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[-]  License file installed when any subpackage combination is installed.
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [3,4]
[x]  Sources contain only permissible code or content.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
     MD5SUM this package     : 51d62c74b83e5b6a8b6f88b4e9334387
     MD5SUM upstream package : 51d62c74b83e5b6a8b6f88b4e9334387
[-]  Compiler flags are appropriate.
[-]  %build honors applicable compiler flags or justifies otherwise.
[-]  ldconfig called in %post and %postun if required.
[x]  Package must own all directories that it creates.
[x]  Package does not own files or directories owned by other packages.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Each %files section contains %defattr.
[x]  No %config files under /usr.
[-]  %config files are marked noreplace or the reason is justified.
[-]  Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [5]
[-]  Package contains a valid .desktop file.
[x]  Package contains code, or permissable content.
[-]  Package contains a SysV-style init script if in need of one.
[x]  File names are valid UTF-8.
[-]  Large documentation files are in a -doc subpackage, if required.
[x]  Package uses nothing in %doc for runtime.
[x]  Package contains no bundled libraries.
[-]  Header files in -devel subpackage, if present.
[-]  Static libraries in -static subpackage, if present.
[-]  Package contains no static executables.
[-]  Package requires pkgconfig, if .pc files are present.
[-]  Development .so files in -devel subpackage, if present.
[-]  Fully versioned dependency in subpackages, if present.
[x]  Package does not contain any libtool archives (.la).
[-]  Useful -debuginfo package or justification otherwise.
[-]  Rpath absent or only used for internal libs.
[x]  Package does not genrate any conflict.
[x]  Package does not contains kernel modules.
[x]  Package is not relocatable.
[-]  Package successfully compiles and builds into binary rpms on at least one supported architecture.
[x]  Package is not known to require ExcludeArch.
[x]  Package installs properly.
[x]  Package obeys FHS, except libexecdir and /usr/target.
[x]  Package meets the Packaging Guidelines. [6]

=== SUGGESTED ITEMS ===
[?]  Package functions as described.
[x]  Latest version is packaged.
[x]  Package does not include license text files separate from upstream.
[?]  If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[x]  Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[x]  SourceX is a working URL.
[-]  SourceX / PatchY prefixed with %{name}.
[x]  Final provides and requires are sane (rpm -q --provides and rpm -q --requires).
[x]  %check is present and all tests pass.
[-]  Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[x]  Reviewer should test that the package builds in mock.
[-]  Package should compile and build into binary rpms on all supported architectures.
[x]  Dist tag is present.
[-]  Spec use %global instead of %define.
[-]  Scriptlets must be sane, if used.
[-]  The placement of pkgconfig(.pc) files are correct.
[x]  No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]  Packages should try to preserve timestamps of original installed files.
[-]  File based requires are sane.
[x]  Man pages included for all executables.
[x]  Uses parallel make.
[-]  Patches link to upstream bugs/comments/lists or are otherwise justified.

=== Issues ===
1. Line 35 expects Changes file to be in Latin2 for no explicit reason.

=== Final Notes ===
1. Attached patch corrects line 35 to expect Latin1 and changes line 37 to avoid LTS (just a suggestion).
2. I'll approve this package once the only issue is corrected.

================
*** REJECTED ***
================

[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines
[2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 
[3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
[4] https://fedoraproject.org/wiki/Licensing:Main
[5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
[6] https://fedoraproject.org/wiki/Packaging:Guidelines

Comment 3 Petr Šabata 2010-11-29 13:48:06 UTC
> Question is: on cpan it is as CGI.pm. Should we package it as perl-CGI.pm?

I would keep the perl-CGI name since it makes more sense.

Comment 4 Marcela Mašláňová 2010-11-29 14:23:57 UTC
Updated SRPM: http://mmaslano.fedorapeople.org/review/perl-CGI-3.50-1.fc14.src.rpm

Comment 5 Petr Šabata 2010-11-29 14:38:20 UTC
Looks okay now.

================
*** APPROVED ***
================

Comment 6 Marcela Mašláňová 2010-11-30 09:01:54 UTC
New Package SCM Request
=======================
Package Name: perl-CGI
Short Description: Handle Common Gateway Interface requests and responses
Owners: mmaslano psabata ppisar
Branches: F-13 F-14 devel
InitialCC: perl-sig

(We need branches for all Fedoras, because we'd like to update CGI for security reason).

Comment 7 Jason Tibbitts 2010-11-30 15:19:15 UTC
Git done (by process-git-requests).

Comment 8 Paul Howarth 2010-12-01 12:53:12 UTC
This package includes a -tests subpackage, but the version built from the main perl package does not. This is likely to lead to situations like Bug #640752 in the future.

I suggest either removing the -tests subpackage or adding a -CGI-tests subpackage to the main perl package for consistency.

Comment 9 Marcela Mašláňová 2010-12-01 14:11:50 UTC
Thanks, but I don't like idea that we would have -test sub-package for everything in perl core. I'd rather obsoleted this CGI-tests.

Comment 10 Paul Howarth 2010-12-01 14:25:43 UTC
That's fine; just be consistent.

Comment 11 Marcela Mašláňová 2010-12-01 14:36:10 UTC
Built without -test sub-package on all branches.


Note You need to log in before you can comment on or make changes to this bug.