Bug 658431 - Asterisk syn-floods 192.168.0.24
Summary: Asterisk syn-floods 192.168.0.24
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: asterisk
Version: rawhide
Hardware: Unspecified
OS: Unspecified
low
high
Target Milestone: ---
Assignee: Jeffrey C. Ollie
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 716747 731963 732957 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-30 11:06 UTC by Benny Amorsen
Modified: 2011-10-11 02:04 UTC (History)
6 users (show)

Fixed In Version: asterisk-1.8.6.0-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-10-03 18:09:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Benny Amorsen 2010-11-30 11:06:04 UTC
Description of problem:
Asterisk syn-floods 192.168.0.24

Version-Release number of selected component (if applicable):
asterisk-1.8.0-3.fc15.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. Install Asterisk
2. tcpdump to see the syn flood

Additional info:
The problem is the sample /etc/asterisk/res_pktccops.conf. It contains entries which by default contact 192.168.0.24. The extra neat thing is that this affects even upgrades, because the file does not exist in older versions of Asterisk...

We caught this in our testing environment, it would have been no fun at all in production.

Proposed resolution:
When building, sed -i -e 's/^/;/' /etc/asterisk/res_pktccops.conf

Also, even example configuration files should not refer to networks which are likely to be used in production.

Comment 1 Jeffrey C. Ollie 2010-11-30 14:57:32 UTC
Is there an upstream report for this?

Comment 2 Benny Amorsen 2010-12-01 10:35:12 UTC
No, there are AFAIK no upstream reports for this.

Comment 3 Jeffrey C. Ollie 2011-09-20 13:19:41 UTC
*** Bug 732957 has been marked as a duplicate of this bug. ***

Comment 4 Jeffrey C. Ollie 2011-09-20 13:38:54 UTC
As reported by David Woodhouse these packets are coming from res_pktccopts.  If you add the following to /etc/asterisk/modules.conf do the packets go away?

noload => chan_mgcp.so
noload => res_pktccops.so

I plan on adding these lines to the Asterisk package in the next release.

Comment 5 Benny Amorsen 2011-09-20 15:11:55 UTC
Yes, the res_pktccopts module causes the problem, which is why editing res_pktccops.conf fixes the it. Yes, the problem goes away if you noload the module. Why not fix the example configuration instead though? Otherwise you leave a ticking time bomb for someone editing /etc/asterisk/modules.conf.

Or do both, for extra brownie points. It is a really obscure feature with very bad consequences, so it should be somewhat difficult to enable.

Comment 6 Jeffrey C. Ollie 2011-09-20 16:53:36 UTC
*** Bug 716747 has been marked as a duplicate of this bug. ***

Comment 7 Jeffrey C. Ollie 2011-09-20 16:54:25 UTC
Yes, that would make sense to comment out everything in res_pktccops.conf, I'll add that to the packages.

Comment 8 Fedora Update System 2011-09-20 20:20:45 UTC
asterisk-1.8.6.0-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/asterisk-1.8.6.0-4.fc16

Comment 9 Fedora Update System 2011-09-20 20:25:03 UTC
asterisk-1.8.6.0-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/asterisk-1.8.6.0-4.fc15

Comment 10 Fedora Update System 2011-09-20 20:25:57 UTC
asterisk-1.8.6.0-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/asterisk-1.8.6.0-4.el6

Comment 11 David Woodhouse 2011-09-20 21:31:48 UTC
There should definitely be two separate upstream bugs. One for the fact that it's enabled by default, and a second for the fact that it syn-floods. Even if it's *supposed* to be enabled, there's no excuse for that.

Comment 12 Fedora Update System 2011-09-21 22:14:54 UTC
Package asterisk-1.8.6.0-4.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing asterisk-1.8.6.0-4.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/asterisk-1.8.6.0-4.fc16
then log in and leave karma (feedback).

Comment 13 Russell Bryant 2011-09-23 00:16:40 UTC
Did the upstream bugs get created for this?  I'd like to follow up on them.

Comment 14 Russell Bryant 2011-09-23 00:48:41 UTC
I at least commented out all of the entries in the sample configuration file so that Asterisk won't eat the CPU/network by default of this module gets loaded ...

http://svnview.digium.com/svn/asterisk?view=revision&revision=337774

That commit should land in the 1.8.8.0 release.

Comment 15 Jeffrey C. Ollie 2011-09-23 03:03:23 UTC
(In reply to comment #13)
> Did the upstream bugs get created for this?  I'd like to follow up on them.

I haven't created any.

Comment 16 Jeffrey C. Ollie 2011-09-26 18:19:02 UTC
*** Bug 731963 has been marked as a duplicate of this bug. ***

Comment 17 Fedora Update System 2011-10-03 18:08:51 UTC
asterisk-1.8.6.0-4.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2011-10-03 23:56:39 UTC
asterisk-1.8.6.0-4.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2011-10-11 02:04:50 UTC
asterisk-1.8.6.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.