Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 658455

Summary:	[RFE] accept and store recipe-level parameters
Product:	[Retired] Beaker	Reporter:	Marian Csontos <mcsontos>
Component:	general	Assignee:	beaker-dev-list
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	0.5	CC:	bpeck, cbeer, cbouchar, mcsontos, tools-bugs
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	UX
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-19 22:22:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	658449

Description Marian Csontos 2010-11-30 12:45:33 UTC

allow recipe (and optionally recipeset and job) elements to accept and use params element similar to task.

The task params will override recipe's and recipe params will override recipeset's and job's.

Some support on Scheduler/Command line site will be required.

Optionally the parameters copying could be implemented entirely on Scheduler's site (or even at the XML create time) but this would create larger jobs and (depending on implementation) the difficulties changing the XML (e.g. bkr job-clone uses results.) IMO this is not worth the trouble...

Comment 1 Nick Coghlan 2012-10-17 04:40:34 UTC

Bulk reassignment of issues as Bill has moved to another team.

Comment 3 Dan Callaghan 2018-08-01 04:34:22 UTC

It turns out Restraint has supported recipe-level params since way back in 2013:

https://git.beaker-project.org/cgit/restraint/commit/?id=ae073373f8064f8f90c19332ff9a9f97ba2e0ee0

although I somehow never noticed this.

So let's consider this WONTFIX for Beah, already implemented for Restraint, and thus this RFE is purely about the Beaker server side of things.

Specifically, the server should accept <params/> directly inside the <recipe/> element. Just like for task params, the <params/> will accept zero or more individal <param name="" value=""/> children. Beaker should persist the recipe params, it should include them in the cloned job XML and in the job results XML, including when the harness fetches the recipe.

At that point, if the recipe is using Restraint, the params should "just work". Verifying this bug should include verifying that we get the desired behaviour end-to-end in a recipe running Restraint.

Comment 4 Tomas Klohna 🔧 2019-04-04 16:44:59 UTC

Changed the component to general